diff mbox

[v5,2/5] doc: bindings: Document for hi655x regulator driver

Message ID 1452514817-118311-3-git-send-email-puck.chen@hisilicon.com
State Superseded
Headers show

Commit Message

Chen Feng Jan. 11, 2016, 12:20 p.m. UTC 
Add Document for hi655x pmic regulator driver

Signed-off-by: Chen Feng <puck.chen@hisilicon.com>

Signed-off-by: Fei Wang <w.f@huawei.com>

Signed-off-by: Xinwei Kong <kong.kongxinwei@hisilicon.com>

---
 .../regulator/hisilicon,hi655x-regulator.txt       | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt

-- 
1.9.1

Comments

Mark Brown Jan. 11, 2016, 6:17 p.m. UTC | #1 
On Mon, Jan 11, 2016 at 08:20:14PM +0800, Chen Feng wrote:
> Add Document for hi655x pmic regulator driver


As I said in reply to v4:

| Please also use subject lines reflecting the normal style for the
| subsystem.
Chen Feng Jan. 12, 2016, 2:07 a.m. UTC | #2 
Mark,

On 2016/1/12 2:17, Mark Brown wrote:
> On Mon, Jan 11, 2016 at 08:20:14PM +0800, Chen Feng wrote:

>> Add Document for hi655x pmic regulator driver

> 

> As I said in reply to v4:

> 

> | Please also use subject lines reflecting the normal style for the

> | subsystem.

> 

Sorry, I don't understand your Prior advice.

I will change it like this.
regulator: hisilicon: Add Document for hi655x PMIC regulator
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
new file mode 100644
index 0000000..6f94c42
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/hisilicon,hi655x-regulator.txt
@@ -0,0 +1,30 @@ 
+Hisilicon Hi655x Voltage regulators
+
+Note:
+The hi655x regulator control is managed by hi655x Power IC.
+So the node of this regulator must be child node of hi655x
+pmic node.
+
+The driver uses the regulator core framework, so please also
+take the bindings of regulator.txt for reference.
+
+The valid names for regulators are:
+
+ldo2 ldo7 ldo10 ldo13 ldo14 ldo15 ldo17 ldo19 ldo21 ldo22
+
+Example:
+        pmic: pmic@f8000000 {
+                compatible = "hisilicon,hi655x-pmic";
+		...
+		regulators {
+			ldo2: ldo2@a21 {
+				compatible = "hisilicon,hi655x-regulator";
+				regulator-name = "ldo2";
+				regulator-min-microvolt = <2500000>;
+				regulator-max-microvolt = <3200000>;
+				regulator-valid-modes-mask = <0x02>;
+				regulator-enable-ramp-delay = <120>;
+			};
+			...
+		}
+	}