| Message ID | 1308566325-11600-3-git-send-email-shawn.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Jun 20, 2011 at 06:38:43PM +0800, Shawn Guo wrote: > The function esdhc_readl_le intends to clear bit SDHCI_CARD_PRESENT, > when the card detect gpio tells there is no card. But it does not > clear the bit actually. The patch gives a fix on that. > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> For the third time ;) Acked-by: Wolfram Sang <w.sang@pengutronix.de> Should go to stable.
Hi Shawn, On Tue, Jun 21 2011, Shawn Guo wrote: >> Acked-by: Wolfram Sang <w.sang@pengutronix.de> >> > Sorry, my bad. Will add in v4. > >> Should go to stable. >> > I suppose that Chris will take care of it, otherwise please let me > know what I should do. (I'm still new to the process) Just add: Cc: <stable@kernel.org> to the commit message, please. (That's all that's necessary to get a patch seen by the stable@ maintainers.) Thanks, - Chris.
On Tue, Jun 21, 2011 at 01:52:36PM +0200, Wolfram Sang wrote: > On Mon, Jun 20, 2011 at 06:38:43PM +0800, Shawn Guo wrote: > > The function esdhc_readl_le intends to clear bit SDHCI_CARD_PRESENT, > > when the card detect gpio tells there is no card. But it does not > > clear the bit actually. The patch gives a fix on that. > > > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org> > > For the third time ;) > > Acked-by: Wolfram Sang <w.sang@pengutronix.de> > Sorry, my bad. Will add in v4. > Should go to stable. > I suppose that Chris will take care of it, otherwise please let me know what I should do. (I'm still new to the process)
> > Should go to stable. > > > I suppose that Chris will take care of it, That's correct. You can add the cc as Chris suggested, so the maintainer knows that you think it should go to stable. The final decission is up to the maintainer, though.
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 248b8e5..94097c0 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -84,7 +84,7 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg) if (boarddata && gpio_is_valid(boarddata->cd_gpio) && gpio_get_value(boarddata->cd_gpio)) /* no card, if a valid gpio says so... */ - val &= SDHCI_CARD_PRESENT; + val &= ~SDHCI_CARD_PRESENT; else /* ... in all other cases assume card is present */ val |= SDHCI_CARD_PRESENT;
The function esdhc_readl_le intends to clear bit SDHCI_CARD_PRESENT, when the card detect gpio tells there is no card. But it does not clear the bit actually. The patch gives a fix on that. Signed-off-by: Shawn Guo <shawn.guo@linaro.org> --- drivers/mmc/host/sdhci-esdhc-imx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)