| Message ID | 1450178282-18869-1-git-send-email-stuart.haslam@linaro.org |
|---|---|
| State | Accepted |
| Commit | 68cac553dc39316bf4678f95758b65a1f5f056e0 |
| Headers | show |
On Tue, Dec 15, 2015 at 5:18 AM, Stuart Haslam <stuart.haslam@linaro.org> wrote: > The netmap header file has some dubious casts that generate errors when > -Wcast-qual is enabled. Include it as a system header so that the > compiler ignores those errors without having to ignore errors in our own > source files. > > Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org> > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org> > --- > platform/linux-generic/m4/odp_netmap.m4 | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/platform/linux-generic/m4/odp_netmap.m4 > b/platform/linux-generic/m4/odp_netmap.m4 > index 72c3fab..d39301f 100644 > --- a/platform/linux-generic/m4/odp_netmap.m4 > +++ b/platform/linux-generic/m4/odp_netmap.m4 > @@ -14,7 +14,7 @@ AC_ARG_WITH([netmap-path], > AC_HELP_STRING([--with-netmap-path=DIR path to netmap root directory], > [(or in the default path if not specified).]), > [NETMAP_PATH=$withval > - AM_CPPFLAGS="$AM_CPPFLAGS -I$NETMAP_PATH/sys" > + AM_CPPFLAGS="$AM_CPPFLAGS -isystem $NETMAP_PATH/sys" > netmap_support=yes],[]) > > ########################################################################## > @@ -35,13 +35,7 @@ else > netmap_support=no > fi > > -# Disable cast errors until the problem in netmap_user.h is fixed upstream > -if test x$netmap_support = xyes > -then > -ODP_CFLAGS_EXTRA="$ODP_CFLAGS_EXTRA -Wno-cast-qual" > -fi > - > ########################################################################## > # Restore old saved variables > ########################################################################## > -CPPFLAGS=$OLD_CPPFLAGS > \ No newline at end of file > +CPPFLAGS=$OLD_CPPFLAGS > -- > 2.1.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
Merged, Maxim. On 12/17/2015 03:31, Bill Fischofer wrote: > > > On Tue, Dec 15, 2015 at 5:18 AM, Stuart Haslam > <stuart.haslam@linaro.org <mailto:stuart.haslam@linaro.org>> wrote: > > The netmap header file has some dubious casts that generate errors > when > -Wcast-qual is enabled. Include it as a system header so that the > compiler ignores those errors without having to ignore errors in > our own > source files. > > Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org > <mailto:stuart.haslam@linaro.org>> > > > Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org > <mailto:bill.fischofer@linaro.org>> > > --- > platform/linux-generic/m4/odp_netmap.m4 | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/platform/linux-generic/m4/odp_netmap.m4 > b/platform/linux-generic/m4/odp_netmap.m4 > index 72c3fab..d39301f 100644 > --- a/platform/linux-generic/m4/odp_netmap.m4 > +++ b/platform/linux-generic/m4/odp_netmap.m4 > @@ -14,7 +14,7 @@ AC_ARG_WITH([netmap-path], > AC_HELP_STRING([--with-netmap-path=DIR path to netmap root > directory], > [(or in the default path if not specified).]), > [NETMAP_PATH=$withval > - AM_CPPFLAGS="$AM_CPPFLAGS -I$NETMAP_PATH/sys" > + AM_CPPFLAGS="$AM_CPPFLAGS -isystem $NETMAP_PATH/sys" > netmap_support=yes],[]) > > ########################################################################## > @@ -35,13 +35,7 @@ else > netmap_support=no > fi > > -# Disable cast errors until the problem in netmap_user.h is fixed > upstream > -if test x$netmap_support = xyes > -then > -ODP_CFLAGS_EXTRA="$ODP_CFLAGS_EXTRA -Wno-cast-qual" > -fi > - > ########################################################################## > # Restore old saved variables > ########################################################################## > -CPPFLAGS=$OLD_CPPFLAGS > \ No newline at end of file > +CPPFLAGS=$OLD_CPPFLAGS > -- > 2.1.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
diff --git a/platform/linux-generic/m4/odp_netmap.m4 b/platform/linux-generic/m4/odp_netmap.m4 index 72c3fab..d39301f 100644 --- a/platform/linux-generic/m4/odp_netmap.m4 +++ b/platform/linux-generic/m4/odp_netmap.m4 @@ -14,7 +14,7 @@ AC_ARG_WITH([netmap-path], AC_HELP_STRING([--with-netmap-path=DIR path to netmap root directory], [(or in the default path if not specified).]), [NETMAP_PATH=$withval - AM_CPPFLAGS="$AM_CPPFLAGS -I$NETMAP_PATH/sys" + AM_CPPFLAGS="$AM_CPPFLAGS -isystem $NETMAP_PATH/sys" netmap_support=yes],[]) ########################################################################## @@ -35,13 +35,7 @@ else netmap_support=no fi -# Disable cast errors until the problem in netmap_user.h is fixed upstream -if test x$netmap_support = xyes -then -ODP_CFLAGS_EXTRA="$ODP_CFLAGS_EXTRA -Wno-cast-qual" -fi - ########################################################################## # Restore old saved variables ########################################################################## -CPPFLAGS=$OLD_CPPFLAGS \ No newline at end of file +CPPFLAGS=$OLD_CPPFLAGS
The netmap header file has some dubious casts that generate errors when -Wcast-qual is enabled. Include it as a system header so that the compiler ignores those errors without having to ignore errors in our own source files. Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org> --- platform/linux-generic/m4/odp_netmap.m4 | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)