| Message ID | 1449142052-10973-1-git-send-email-ivan.khoronzhuk@linaro.org |
|---|---|
| State | New |
| Headers | show |
ping On 03.12.15 13:27, Ivan Khoronzhuk wrote: > No need to include all headers in hashtable and lineartable. > rwlock and shared_memory is enough. It allows to see which odp > parts are used. > > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> > --- > helper/hashtable.c | 3 ++- > helper/lineartable.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/helper/hashtable.c b/helper/hashtable.c > index 1121beb..07f4c59 100644 > --- a/helper/hashtable.c > +++ b/helper/hashtable.c > @@ -10,7 +10,8 @@ > #include "odph_hashtable.h" > #include "odph_list_internal.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/shared_memory.h> > +#include <odp/rwlock.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 > diff --git a/helper/lineartable.c b/helper/lineartable.c > index b0759f9..133f70d 100644 > --- a/helper/lineartable.c > +++ b/helper/lineartable.c > @@ -10,7 +10,8 @@ > > #include "odph_lineartable.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/rwlock.h> > +#include <odp/shared_memory.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 >
On 3 December 2015 at 06:27, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote: > No need to include all headers in hashtable and lineartable. > rwlock and shared_memory is enough. It allows to see which odp > parts are used. > > To make all of the helpers lib clean of the general odp.h we also need to fix include/odp/helper/linux.h:#include <odp.h> Presumably the tests are considered applications and they only include odp.h test/odp_chksum.c:#include <odp.h> test/odp_process.c:#include <odp.h> test/odp_table.c:#include <odp.h> test/odp_thread.c:#include <odp.h> > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- > helper/hashtable.c | 3 ++- > helper/lineartable.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/helper/hashtable.c b/helper/hashtable.c > index 1121beb..07f4c59 100644 > --- a/helper/hashtable.c > +++ b/helper/hashtable.c > @@ -10,7 +10,8 @@ > #include "odph_hashtable.h" > #include "odph_list_internal.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/shared_memory.h> > +#include <odp/rwlock.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 > diff --git a/helper/lineartable.c b/helper/lineartable.c > index b0759f9..133f70d 100644 > --- a/helper/lineartable.c > +++ b/helper/lineartable.c > @@ -10,7 +10,8 @@ > > #include "odph_lineartable.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/rwlock.h> > +#include <odp/shared_memory.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
On 14.12.15 21:15, Mike Holmes wrote: > > > On 3 December 2015 at 06:27, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>> wrote: > > No need to include all headers in hashtable and lineartable. > rwlock and shared_memory is enough. It allows to see which odp > parts are used. > > > To make all of the helpers lib clean of the general odp.h we also need to fix > include/odp/helper/linux.h:#include <odp.h> > > Presumably the tests are considered applications and they only include odp.h > test/odp_chksum.c:#include <odp.h> > test/odp_process.c:#include <odp.h> > test/odp_table.c:#include <odp.h> > test/odp_thread.c:#include <odp.h> > Yep > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org <mailto:ivan.khoronzhuk@linaro.org>> > > --- > helper/hashtable.c | 3 ++- > helper/lineartable.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/helper/hashtable.c b/helper/hashtable.c > index 1121beb..07f4c59 100644 > --- a/helper/hashtable.c > +++ b/helper/hashtable.c > @@ -10,7 +10,8 @@ > #include "odph_hashtable.h" > #include "odph_list_internal.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/shared_memory.h> > +#include <odp/rwlock.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 > diff --git a/helper/lineartable.c b/helper/lineartable.c > index b0759f9..133f70d 100644 > --- a/helper/lineartable.c > +++ b/helper/lineartable.c > @@ -10,7 +10,8 @@ > > #include "odph_lineartable.h" > #include "odph_debug.h" > -#include <odp.h> > +#include <odp/rwlock.h> > +#include <odp/shared_memory.h> > > #define ODPH_SUCCESS 0 > #define ODPH_FAIL -1 > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > > __ > >
diff --git a/helper/hashtable.c b/helper/hashtable.c index 1121beb..07f4c59 100644 --- a/helper/hashtable.c +++ b/helper/hashtable.c @@ -10,7 +10,8 @@ #include "odph_hashtable.h" #include "odph_list_internal.h" #include "odph_debug.h" -#include <odp.h> +#include <odp/shared_memory.h> +#include <odp/rwlock.h> #define ODPH_SUCCESS 0 #define ODPH_FAIL -1 diff --git a/helper/lineartable.c b/helper/lineartable.c index b0759f9..133f70d 100644 --- a/helper/lineartable.c +++ b/helper/lineartable.c @@ -10,7 +10,8 @@ #include "odph_lineartable.h" #include "odph_debug.h" -#include <odp.h> +#include <odp/rwlock.h> +#include <odp/shared_memory.h> #define ODPH_SUCCESS 0 #define ODPH_FAIL -1
No need to include all headers in hashtable and lineartable. rwlock and shared_memory is enough. It allows to see which odp parts are used. Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> --- helper/hashtable.c | 3 ++- helper/lineartable.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)