diff mbox

[API-NEXT/PATCH,1/1] validation: classification: add odp_pktio_param_init() API

Message ID 1444889718-9545-1-git-send-email-bala.manoharan@linaro.org
State Accepted
Commit b8d0b5f3f4b9d5e35e1be777dae7e518b4f20a71
Headers show

Commit Message

Balasubramanian Manoharan Oct. 15, 2015, 6:15 a.m. UTC
odp_pktio_param_init() API is used to initialize odp_pktio_param_t params

Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
---
 test/validation/classification/odp_classification_test_pmr.c | 2 +-
 test/validation/classification/odp_classification_tests.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Balasubramanian Manoharan Oct. 15, 2015, 6:23 a.m. UTC | #1
This patch needs to be merged after https://patches.linaro.org/54903/

Regards,
Bala

On 15 October 2015 at 11:45, Balasubramanian Manoharan
<bala.manoharan@linaro.org> wrote:
> odp_pktio_param_init() API is used to initialize odp_pktio_param_t params
>
> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
> ---
>  test/validation/classification/odp_classification_test_pmr.c | 2 +-
>  test/validation/classification/odp_classification_tests.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/validation/classification/odp_classification_test_pmr.c b/test/validation/classification/odp_classification_test_pmr.c
> index 37de892..e794bda 100644
> --- a/test/validation/classification/odp_classification_test_pmr.c
> +++ b/test/validation/classification/odp_classification_test_pmr.c
> @@ -80,7 +80,7 @@ odp_pktio_t create_pktio(odp_queue_type_t q_type)
>         if (pool == ODP_POOL_INVALID)
>                 return ODP_PKTIO_INVALID;
>
> -       memset(&pktio_param, 0, sizeof(pktio_param));
> +       odp_pktio_param_init(&pktio_param);
>         if (q_type == ODP_QUEUE_TYPE_POLL)
>                 pktio_param.in_mode = ODP_PKTIN_MODE_POLL;
>         else
> diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c
> index 74d1060..fe55419 100644
> --- a/test/validation/classification/odp_classification_tests.c
> +++ b/test/validation/classification/odp_classification_tests.c
> @@ -71,7 +71,7 @@ int classification_suite_init(void)
>                 return -1;
>         }
>
> -       memset(&pktio_param, 0, sizeof(pktio_param));
> +       odp_pktio_param_init(&pktio_param);
>         pktio_param.in_mode = ODP_PKTIN_MODE_SCHED;
>
>         pktio_loop = odp_pktio_open("loop", pool_default, &pktio_param);
> --
> 1.9.1
>
Bill Fischofer Oct. 15, 2015, 12:28 p.m. UTC | #2
On Thu, Oct 15, 2015 at 1:15 AM, Balasubramanian Manoharan <
bala.manoharan@linaro.org> wrote:

> odp_pktio_param_init() API is used to initialize odp_pktio_param_t params
>
> Signed-off-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  test/validation/classification/odp_classification_test_pmr.c | 2 +-
>  test/validation/classification/odp_classification_tests.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/test/validation/classification/odp_classification_test_pmr.c
> b/test/validation/classification/odp_classification_test_pmr.c
> index 37de892..e794bda 100644
> --- a/test/validation/classification/odp_classification_test_pmr.c
> +++ b/test/validation/classification/odp_classification_test_pmr.c
> @@ -80,7 +80,7 @@ odp_pktio_t create_pktio(odp_queue_type_t q_type)
>         if (pool == ODP_POOL_INVALID)
>                 return ODP_PKTIO_INVALID;
>
> -       memset(&pktio_param, 0, sizeof(pktio_param));
> +       odp_pktio_param_init(&pktio_param);
>         if (q_type == ODP_QUEUE_TYPE_POLL)
>                 pktio_param.in_mode = ODP_PKTIN_MODE_POLL;
>         else
> diff --git a/test/validation/classification/odp_classification_tests.c
> b/test/validation/classification/odp_classification_tests.c
> index 74d1060..fe55419 100644
> --- a/test/validation/classification/odp_classification_tests.c
> +++ b/test/validation/classification/odp_classification_tests.c
> @@ -71,7 +71,7 @@ int classification_suite_init(void)
>                 return -1;
>         }
>
> -       memset(&pktio_param, 0, sizeof(pktio_param));
> +       odp_pktio_param_init(&pktio_param);
>         pktio_param.in_mode = ODP_PKTIN_MODE_SCHED;
>
>         pktio_loop = odp_pktio_open("loop", pool_default, &pktio_param);
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov Oct. 16, 2015, 11:35 a.m. UTC | #3
Merged,
Maxim.

On 10/15/2015 15:28, Bill Fischofer wrote:
>
>
> On Thu, Oct 15, 2015 at 1:15 AM, Balasubramanian Manoharan 
> <bala.manoharan@linaro.org <mailto:bala.manoharan@linaro.org>> wrote:
>
>     odp_pktio_param_init() API is used to initialize odp_pktio_param_t
>     params
>
>     Signed-off-by: Balasubramanian Manoharan
>     <bala.manoharan@linaro.org <mailto:bala.manoharan@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      test/validation/classification/odp_classification_test_pmr.c | 2 +-
>      test/validation/classification/odp_classification_tests.c   | 2 +-
>      2 files changed, 2 insertions(+), 2 deletions(-)
>
>     diff --git
>     a/test/validation/classification/odp_classification_test_pmr.c
>     b/test/validation/classification/odp_classification_test_pmr.c
>     index 37de892..e794bda 100644
>     --- a/test/validation/classification/odp_classification_test_pmr.c
>     +++ b/test/validation/classification/odp_classification_test_pmr.c
>     @@ -80,7 +80,7 @@ odp_pktio_t create_pktio(odp_queue_type_t q_type)
>             if (pool == ODP_POOL_INVALID)
>                     return ODP_PKTIO_INVALID;
>
>     -       memset(&pktio_param, 0, sizeof(pktio_param));
>     +       odp_pktio_param_init(&pktio_param);
>             if (q_type == ODP_QUEUE_TYPE_POLL)
>                     pktio_param.in_mode = ODP_PKTIN_MODE_POLL;
>             else
>     diff --git
>     a/test/validation/classification/odp_classification_tests.c
>     b/test/validation/classification/odp_classification_tests.c
>     index 74d1060..fe55419 100644
>     --- a/test/validation/classification/odp_classification_tests.c
>     +++ b/test/validation/classification/odp_classification_tests.c
>     @@ -71,7 +71,7 @@ int classification_suite_init(void)
>                     return -1;
>             }
>
>     -       memset(&pktio_param, 0, sizeof(pktio_param));
>     +       odp_pktio_param_init(&pktio_param);
>             pktio_param.in_mode = ODP_PKTIN_MODE_SCHED;
>
>             pktio_loop = odp_pktio_open("loop", pool_default,
>     &pktio_param);
>     --
>     1.9.1
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/classification/odp_classification_test_pmr.c b/test/validation/classification/odp_classification_test_pmr.c
index 37de892..e794bda 100644
--- a/test/validation/classification/odp_classification_test_pmr.c
+++ b/test/validation/classification/odp_classification_test_pmr.c
@@ -80,7 +80,7 @@  odp_pktio_t create_pktio(odp_queue_type_t q_type)
 	if (pool == ODP_POOL_INVALID)
 		return ODP_PKTIO_INVALID;
 
-	memset(&pktio_param, 0, sizeof(pktio_param));
+	odp_pktio_param_init(&pktio_param);
 	if (q_type == ODP_QUEUE_TYPE_POLL)
 		pktio_param.in_mode = ODP_PKTIN_MODE_POLL;
 	else
diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c
index 74d1060..fe55419 100644
--- a/test/validation/classification/odp_classification_tests.c
+++ b/test/validation/classification/odp_classification_tests.c
@@ -71,7 +71,7 @@  int classification_suite_init(void)
 		return -1;
 	}
 
-	memset(&pktio_param, 0, sizeof(pktio_param));
+	odp_pktio_param_init(&pktio_param);
 	pktio_param.in_mode = ODP_PKTIN_MODE_SCHED;
 
 	pktio_loop = odp_pktio_open("loop", pool_default, &pktio_param);