diff mbox

[v2,3/3] nvmem: core: add sysfs file mode flag in nvmem_config

Message ID 1444215664-10921-1-git-send-email-srinivas.kandagatla@linaro.org
State New
Headers show

Commit Message

Srinivas Kandagatla Oct. 7, 2015, 11:01 a.m. UTC
This patch adds mode variable to nvmem_config structure which will allow
providers to specify the permissions for the sysfs binary file.
This mode is applied on top of root-only access permissions set by
the core.

Having this flag would give more flexibility to providers to decide
which permissions to set on the sysfs binary file entry.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
 drivers/nvmem/core.c           | 1 +
 include/linux/nvmem-provider.h | 1 +
 2 files changed, 2 insertions(+)

Comments

Greg KH Oct. 7, 2015, 12:56 p.m. UTC | #1
On Wed, Oct 07, 2015 at 12:01:04PM +0100, Srinivas Kandagatla wrote:
> This patch adds mode variable to nvmem_config structure which will allow
> providers to specify the permissions for the sysfs binary file.
> This mode is applied on top of root-only access permissions set by
> the core.
> 
> Having this flag would give more flexibility to providers to decide
> which permissions to set on the sysfs binary file entry.

And they will get it wrong, please don't do this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
diff mbox

Patch

diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 737fa75..4b6f219 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -315,6 +315,7 @@  struct nvmem_device *nvmem_register(const struct nvmem_config *config)
 	if (!nvmem->read_only)
 		nvmem->bin.attr.mode |= S_IWUSR;
 
+	nvmem->bin.attr.mode |= config->mode;
 	nvmem->bin.size = nvmem->size;
 	device_initialize(&nvmem->dev);
 
diff --git a/include/linux/nvmem-provider.h b/include/linux/nvmem-provider.h
index 0b68caf..3f22caa 100644
--- a/include/linux/nvmem-provider.h
+++ b/include/linux/nvmem-provider.h
@@ -23,6 +23,7 @@  struct nvmem_config {
 	const struct nvmem_cell_info	*cells;
 	int			ncells;
 	bool			read_only;
+	umode_t			mode;  /* visibility in sysfs */
 };
 
 #if IS_ENABLED(CONFIG_NVMEM)