| Message ID | 1443017892-15567-1-git-send-email-drjones@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
On 9/23/15 09:18, Andrew Jones wrote: > ARM/AArch64 KVM guests don't have any way to identify > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > could discuss all sorts of reasons why guests shouldn't need to > know that, but then there's always some case where it'd be One example is for the subscription manager to check the license type... > nice... Anyway, now that we have SMBIOS tables in ARM guests, > it's easy for the guest to know that it's a QEMU instance. This > patch takes that one step further, also identifying KVM, when > appropriate. Again, we could debate why generally nothing > should care whether it's of type QEMU or QEMU/KVM, but again, > sometimes it's nice to know... > > Signed-off-by: Andrew Jones <drjones@redhat.com> > --- > hw/arm/virt.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 6bf0d6d591d6c..607d448354a8c 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -855,12 +855,17 @@ static void virt_build_smbios(VirtGuestInfo *guest_info) > FWCfgState *fw_cfg = guest_info->fw_cfg; > uint8_t *smbios_tables, *smbios_anchor; > size_t smbios_tables_len, smbios_anchor_len; > + const char *product = "QEMU Virtual Machine"; > > if (!fw_cfg) { > return; > } > > - smbios_set_defaults("QEMU", "QEMU Virtual Machine", > + if (kvm_enabled()) { > + product = "KVM Virtual Machine"; > + } > + > + smbios_set_defaults("QEMU", product, > "1.0", false, true, SMBIOS_ENTRY_POINT_30); > > smbios_get_tables(NULL, 0, &smbios_tables, &smbios_tables_len, > Reviewed-by: Wei Huang <wei@redhat.com>
On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: > ARM/AArch64 KVM guests don't have any way to identify > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > could discuss all sorts of reasons why guests shouldn't need to > know that, but then there's always some case where it'd be > nice... Anyway, now that we have SMBIOS tables in ARM guests, > it's easy for the guest to know that it's a QEMU instance. This > patch takes that one step further, also identifying KVM, when > appropriate. Again, we could debate why generally nothing > should care whether it's of type QEMU or QEMU/KVM, but again, > sometimes it's nice to know... This doesn't seem great to me, because it's ACPI/SMBIOS specific. A mechanism that worked whether the guest was booted via APCI or DT would seem preferable to me... thanks -- PMM
On 23 September 2015 at 08:43, Peter Maydell <peter.maydell@linaro.org> wrote: > On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: >> ARM/AArch64 KVM guests don't have any way to identify >> themselves as KVM guests (x86 guests use a CPUID leaf). Now, we >> could discuss all sorts of reasons why guests shouldn't need to >> know that, but then there's always some case where it'd be >> nice... Anyway, now that we have SMBIOS tables in ARM guests, >> it's easy for the guest to know that it's a QEMU instance. This >> patch takes that one step further, also identifying KVM, when >> appropriate. Again, we could debate why generally nothing >> should care whether it's of type QEMU or QEMU/KVM, but again, >> sometimes it's nice to know... > > This doesn't seem great to me, because it's ACPI/SMBIOS > specific. A mechanism that worked whether the guest was > booted via APCI or DT would seem preferable to me... ...and, on a more careful reread, I don't like the way the behaviour is changing for "this is KVM" rather than "and it's KVM" being an additional piece of information. thanks -- PMM
On Wed, Sep 23, 2015 at 08:43:39AM -0700, Peter Maydell wrote: > On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: > > ARM/AArch64 KVM guests don't have any way to identify > > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > > could discuss all sorts of reasons why guests shouldn't need to > > know that, but then there's always some case where it'd be > > nice... Anyway, now that we have SMBIOS tables in ARM guests, > > it's easy for the guest to know that it's a QEMU instance. This > > patch takes that one step further, also identifying KVM, when > > appropriate. Again, we could debate why generally nothing > > should care whether it's of type QEMU or QEMU/KVM, but again, > > sometimes it's nice to know... > > This doesn't seem great to me, because it's ACPI/SMBIOS > specific. A mechanism that worked whether the guest was > booted via APCI or DT would seem preferable to me... SMBIOS is populated on both ACPI and devicetree boots. We already have detection in virt-what and systemd-detect-virt for DT boots, although it only detects QEMU (it can't determine if KVM is used). That detection is DT-specific, and much more of a heuristic, it checks for the presence of the fw-cfg node in the DT. Actually, I'd like to patch those virt detection tools to try SMBIOS first (which, with this patch, could also give KVM info), and then fall back to trying the current DT-only, QEMU-only detection, before giving up. Thanks, drew
On Wed, Sep 23, 2015 at 09:09:11AM -0700, Peter Maydell wrote: > On 23 September 2015 at 08:43, Peter Maydell <peter.maydell@linaro.org> wrote: > > On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: > >> ARM/AArch64 KVM guests don't have any way to identify > >> themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > >> could discuss all sorts of reasons why guests shouldn't need to > >> know that, but then there's always some case where it'd be > >> nice... Anyway, now that we have SMBIOS tables in ARM guests, > >> it's easy for the guest to know that it's a QEMU instance. This > >> patch takes that one step further, also identifying KVM, when > >> appropriate. Again, we could debate why generally nothing > >> should care whether it's of type QEMU or QEMU/KVM, but again, > >> sometimes it's nice to know... > > > > This doesn't seem great to me, because it's ACPI/SMBIOS > > specific. A mechanism that worked whether the guest was > > booted via APCI or DT would seem preferable to me... > > ...and, on a more careful reread, I don't like the way the > behaviour is changing for "this is KVM" rather than "and it's > KVM" being an additional piece of information. It is "and it's KVM". We leave the SMBIOS Manufacturer as "QEMU", so QEMU is still there, and even in the "primary" field. We only change the Product Name to be KVM only, although that could certainly be "QEMU/KVM Virtual Machine", if preferred. Thanks, drew
On Thu, Sep 24, 2015 at 12:13:08PM +0200, Andrew Jones wrote: > On Wed, Sep 23, 2015 at 08:43:39AM -0700, Peter Maydell wrote: > > On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: > > > ARM/AArch64 KVM guests don't have any way to identify > > > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we > > > could discuss all sorts of reasons why guests shouldn't need to > > > know that, but then there's always some case where it'd be > > > nice... Anyway, now that we have SMBIOS tables in ARM guests, > > > it's easy for the guest to know that it's a QEMU instance. This > > > patch takes that one step further, also identifying KVM, when > > > appropriate. Again, we could debate why generally nothing > > > should care whether it's of type QEMU or QEMU/KVM, but again, > > > sometimes it's nice to know... > > > > This doesn't seem great to me, because it's ACPI/SMBIOS > > specific. A mechanism that worked whether the guest was > > booted via APCI or DT would seem preferable to me... > > SMBIOS is populated on both ACPI and devicetree boots. We already > have detection in virt-what and systemd-detect-virt for DT boots, > although it only detects QEMU (it can't determine if KVM is used). > That detection is DT-specific, and much more of a heuristic, it > checks for the presence of the fw-cfg node in the DT. Actually, I'd > like to patch those virt detection tools to try SMBIOS first (which, > with this patch, could also give KVM info), and then fall back to > trying the current DT-only, QEMU-only detection, before giving up. > Hi Peter, Anymore thoughts on this? Thanks, drew
On 28 September 2015 at 16:31, Andrew Jones <drjones@redhat.com> wrote: > On Thu, Sep 24, 2015 at 12:13:08PM +0200, Andrew Jones wrote: >> On Wed, Sep 23, 2015 at 08:43:39AM -0700, Peter Maydell wrote: >> > On 23 September 2015 at 07:18, Andrew Jones <drjones@redhat.com> wrote: >> > > ARM/AArch64 KVM guests don't have any way to identify >> > > themselves as KVM guests (x86 guests use a CPUID leaf). Now, we >> > > could discuss all sorts of reasons why guests shouldn't need to >> > > know that, but then there's always some case where it'd be >> > > nice... Anyway, now that we have SMBIOS tables in ARM guests, >> > > it's easy for the guest to know that it's a QEMU instance. This >> > > patch takes that one step further, also identifying KVM, when >> > > appropriate. Again, we could debate why generally nothing >> > > should care whether it's of type QEMU or QEMU/KVM, but again, >> > > sometimes it's nice to know... >> > >> > This doesn't seem great to me, because it's ACPI/SMBIOS >> > specific. A mechanism that worked whether the guest was >> > booted via APCI or DT would seem preferable to me... >> >> SMBIOS is populated on both ACPI and devicetree boots. We already >> have detection in virt-what and systemd-detect-virt for DT boots, >> although it only detects QEMU (it can't determine if KVM is used). >> That detection is DT-specific, and much more of a heuristic, it >> checks for the presence of the fw-cfg node in the DT. Actually, I'd >> like to patch those virt detection tools to try SMBIOS first (which, >> with this patch, could also give KVM info), and then fall back to >> trying the current DT-only, QEMU-only detection, before giving up. >> > > Hi Peter, > > Anymore thoughts on this? Well, OK I guess, but this all seems worryingly ad-hoc... Applied to target-arm.next. thanks -- PMM
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 6bf0d6d591d6c..607d448354a8c 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -855,12 +855,17 @@ static void virt_build_smbios(VirtGuestInfo *guest_info) FWCfgState *fw_cfg = guest_info->fw_cfg; uint8_t *smbios_tables, *smbios_anchor; size_t smbios_tables_len, smbios_anchor_len; + const char *product = "QEMU Virtual Machine"; if (!fw_cfg) { return; } - smbios_set_defaults("QEMU", "QEMU Virtual Machine", + if (kvm_enabled()) { + product = "KVM Virtual Machine"; + } + + smbios_set_defaults("QEMU", product, "1.0", false, true, SMBIOS_ENTRY_POINT_30); smbios_get_tables(NULL, 0, &smbios_tables, &smbios_tables_len,
ARM/AArch64 KVM guests don't have any way to identify themselves as KVM guests (x86 guests use a CPUID leaf). Now, we could discuss all sorts of reasons why guests shouldn't need to know that, but then there's always some case where it'd be nice... Anyway, now that we have SMBIOS tables in ARM guests, it's easy for the guest to know that it's a QEMU instance. This patch takes that one step further, also identifying KVM, when appropriate. Again, we could debate why generally nothing should care whether it's of type QEMU or QEMU/KVM, but again, sometimes it's nice to know... Signed-off-by: Andrew Jones <drjones@redhat.com> --- hw/arm/virt.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)