diff mbox

[API-NEXT,1/2] api: pktio: specify that pool type must be ODP_POOL_PACKET

Message ID 1441361788-2723-1-git-send-email-stuart.haslam@linaro.org
State Accepted
Commit be2fa8f291619ff7e6849be35c23518ab68151ac
Headers show

Commit Message

Stuart Haslam Sept. 4, 2015, 10:16 a.m. UTC
The pool passed to odp_pktio_open() must be of type ODP_POOL_PACKET so
add a note to clarify.

Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
---
 include/odp/api/packet_io.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Savolainen, Petri (Nokia - FI/Espoo) Sept. 4, 2015, 10:24 a.m. UTC | #1
For both patches:

Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>



> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of

> ext Stuart Haslam

> Sent: Friday, September 04, 2015 1:16 PM

> To: lng-odp@lists.linaro.org

> Subject: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: specify that pool

> type must be ODP_POOL_PACKET

> 

> The pool passed to odp_pktio_open() must be of type ODP_POOL_PACKET so

> add a note to clarify.

> 

> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>

> ---

>  include/odp/api/packet_io.h | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h

> index 178d98b..9b930bd 100644

> --- a/include/odp/api/packet_io.h

> +++ b/include/odp/api/packet_io.h

> @@ -100,8 +100,8 @@ typedef struct odp_pktio_param_t {

>   * device. Packet IO parameters provide interface level configuration

> options.

>   *

>   * @param dev    Packet IO device name

> - * @param pool   Default pool from which to allocate buffers for

> storing packets

> - *               received over this packet IO

> + * @param pool   Default pool from which to allocate storage for

> packets

> + *               received over this interface, must be of type

> ODP_POOL_PACKET

>   * @param param  Packet IO parameters

>   *

>   * @return Packet IO handle

> --

> 2.1.1

> 

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp
Maxim Uvarov Sept. 7, 2015, 10:52 a.m. UTC | #2
merged to api-next.

Maxim.

On 09/04/15 13:24, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> For both patches:
>
> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
>
>
>> -----Original Message-----
>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of
>> ext Stuart Haslam
>> Sent: Friday, September 04, 2015 1:16 PM
>> To: lng-odp@lists.linaro.org
>> Subject: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: specify that pool
>> type must be ODP_POOL_PACKET
>>
>> The pool passed to odp_pktio_open() must be of type ODP_POOL_PACKET so
>> add a note to clarify.
>>
>> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
>> ---
>>   include/odp/api/packet_io.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
>> index 178d98b..9b930bd 100644
>> --- a/include/odp/api/packet_io.h
>> +++ b/include/odp/api/packet_io.h
>> @@ -100,8 +100,8 @@ typedef struct odp_pktio_param_t {
>>    * device. Packet IO parameters provide interface level configuration
>> options.
>>    *
>>    * @param dev    Packet IO device name
>> - * @param pool   Default pool from which to allocate buffers for
>> storing packets
>> - *               received over this packet IO
>> + * @param pool   Default pool from which to allocate storage for
>> packets
>> + *               received over this interface, must be of type
>> ODP_POOL_PACKET
>>    * @param param  Packet IO parameters
>>    *
>>    * @return Packet IO handle
>> --
>> 2.1.1
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
Maxim Uvarov Sept. 7, 2015, 10:56 a.m. UTC | #3
Merged to api-next.

Maxim.

On 09/04/15 13:24, Savolainen, Petri (Nokia - FI/Espoo) wrote:
> For both patches:
>
> Reviewed-by: Petri Savolainen <petri.savolainen@nokia.com>
>
>
>> -----Original Message-----
>> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of
>> ext Stuart Haslam
>> Sent: Friday, September 04, 2015 1:16 PM
>> To: lng-odp@lists.linaro.org
>> Subject: [lng-odp] [API-NEXT PATCH 1/2] api: pktio: specify that pool
>> type must be ODP_POOL_PACKET
>>
>> The pool passed to odp_pktio_open() must be of type ODP_POOL_PACKET so
>> add a note to clarify.
>>
>> Signed-off-by: Stuart Haslam <stuart.haslam@linaro.org>
>> ---
>>   include/odp/api/packet_io.h | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
>> index 178d98b..9b930bd 100644
>> --- a/include/odp/api/packet_io.h
>> +++ b/include/odp/api/packet_io.h
>> @@ -100,8 +100,8 @@ typedef struct odp_pktio_param_t {
>>    * device. Packet IO parameters provide interface level configuration
>> options.
>>    *
>>    * @param dev    Packet IO device name
>> - * @param pool   Default pool from which to allocate buffers for
>> storing packets
>> - *               received over this packet IO
>> + * @param pool   Default pool from which to allocate storage for
>> packets
>> + *               received over this interface, must be of type
>> ODP_POOL_PACKET
>>    * @param param  Packet IO parameters
>>    *
>>    * @return Packet IO handle
>> --
>> 2.1.1
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> https://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/include/odp/api/packet_io.h b/include/odp/api/packet_io.h
index 178d98b..9b930bd 100644
--- a/include/odp/api/packet_io.h
+++ b/include/odp/api/packet_io.h
@@ -100,8 +100,8 @@  typedef struct odp_pktio_param_t {
  * device. Packet IO parameters provide interface level configuration options.
  *
  * @param dev    Packet IO device name
- * @param pool   Default pool from which to allocate buffers for storing packets
- *               received over this packet IO
+ * @param pool   Default pool from which to allocate storage for packets
+ *               received over this interface, must be of type ODP_POOL_PACKET
  * @param param  Packet IO parameters
  *
  * @return Packet IO handle