| Message ID | 1438862551-4506-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
I have seen this behaviour On 6 August 2015 at 08:02, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Usually odp_generator exists when veth is destroyed, but not > always. Because cpu load impacts on other performance tests > we have to be sure that odp_generator is not running in background. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > Reviewed-by: Mike Holmes <mike.holmes@linaro.org> > --- > next step will be move odp_l2fwd_run inside platfrom directory. > > Maxim. > > test/performance/odp_l2fwd_run | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/test/performance/odp_l2fwd_run > b/test/performance/odp_l2fwd_run > index e89bec8..894955a 100755 > --- a/test/performance/odp_l2fwd_run > +++ b/test/performance/odp_l2fwd_run > @@ -63,6 +63,8 @@ run_l2fwd() > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > > + killall odp_generator${EXEEXT} > + > cleanup_pktio_env > if [ $? -ne 0 ]; then > echo "cleanup_pktio_env error $?" > -- > 1.9.1 > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
On Thu, Aug 06, 2015 at 03:02:31PM +0300, Maxim Uvarov wrote: > Usually odp_generator exists when veth is destroyed, but not > always. Because cpu load impacts on other performance tests > we have to be sure that odp_generator is not running in background. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > next step will be move odp_l2fwd_run inside platfrom directory. > > Maxim. > > test/performance/odp_l2fwd_run | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/test/performance/odp_l2fwd_run b/test/performance/odp_l2fwd_run > index e89bec8..894955a 100755 > --- a/test/performance/odp_l2fwd_run > +++ b/test/performance/odp_l2fwd_run > @@ -63,6 +63,8 @@ run_l2fwd() > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > > + killall odp_generator${EXEEXT} > + This will kill other running instances too, it would be better to save the pid when the generator is launched; GEN_PID=$!
On 6 August 2015 at 08:09, Stuart Haslam <stuart.haslam@linaro.org> wrote: > On Thu, Aug 06, 2015 at 03:02:31PM +0300, Maxim Uvarov wrote: > > Usually odp_generator exists when veth is destroyed, but not > > always. Because cpu load impacts on other performance tests > > we have to be sure that odp_generator is not running in background. > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > > --- > > next step will be move odp_l2fwd_run inside platfrom directory. > > > > Maxim. > > > > test/performance/odp_l2fwd_run | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/test/performance/odp_l2fwd_run > b/test/performance/odp_l2fwd_run > > index e89bec8..894955a 100755 > > --- a/test/performance/odp_l2fwd_run > > +++ b/test/performance/odp_l2fwd_run > > @@ -63,6 +63,8 @@ run_l2fwd() > > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > > > > + killall odp_generator${EXEEXT} > > + > > This will kill other running instances too, it would be better to save > the pid when the generator is launched; GEN_PID=$! > That is nicer, but should there be other instances running if you are executing performance tests ? > > -- > Stuart. > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
On 08/06/15 15:15, Mike Holmes wrote: > > > On 6 August 2015 at 08:09, Stuart Haslam <stuart.haslam@linaro.org > <mailto:stuart.haslam@linaro.org>> wrote: > > On Thu, Aug 06, 2015 at 03:02:31PM +0300, Maxim Uvarov wrote: > > Usually odp_generator exists when veth is destroyed, but not > > always. Because cpu load impacts on other performance tests > > we have to be sure that odp_generator is not running in background. > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > > --- > > next step will be move odp_l2fwd_run inside platfrom directory. > > > > Maxim. > > > > test/performance/odp_l2fwd_run | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/test/performance/odp_l2fwd_run > b/test/performance/odp_l2fwd_run > > index e89bec8..894955a 100755 > > --- a/test/performance/odp_l2fwd_run > > +++ b/test/performance/odp_l2fwd_run > > @@ -63,6 +63,8 @@ run_l2fwd() > > echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" > > odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 > > > > + killall odp_generator${EXEEXT} > > + > > This will kill other running instances too, it would be better to save > the pid when the generator is launched; GEN_PID=$! > > > That is nicer, but should there be other instances running if you are > executing performance tests ? Agree with Stuart just killing all we are can hide some other issues. We should kill only what we run. Sent update patch with v prefix (should be v2). Maxim. > > -- > Stuart. > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs >
diff --git a/test/performance/odp_l2fwd_run b/test/performance/odp_l2fwd_run index e89bec8..894955a 100755 --- a/test/performance/odp_l2fwd_run +++ b/test/performance/odp_l2fwd_run @@ -63,6 +63,8 @@ run_l2fwd() echo "Run odp_l2fwd -i $IF1,$IF2 -m 0 -t 30 -c 2" odp_l2fwd${EXEEXT} -i $IF1,$IF2 -m 0 -t 30 -c 2 + killall odp_generator${EXEEXT} + cleanup_pktio_env if [ $? -ne 0 ]; then echo "cleanup_pktio_env error $?"
Usually odp_generator exists when veth is destroyed, but not always. Because cpu load impacts on other performance tests we have to be sure that odp_generator is not running in background. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- next step will be move odp_l2fwd_run inside platfrom directory. Maxim. test/performance/odp_l2fwd_run | 2 ++ 1 file changed, 2 insertions(+)