diff mbox

validation: classification: fix ODP_PMR_IPPROTO capability check

Message ID 1436879215-32173-1-git-send-email-ivan.khoronzhuk@linaro.org
State Accepted
Commit 533efaa5f8c385fa5784d03bcfa93c15e342e6d4
Headers show

Commit Message

Ivan Khoronzhuk July 14, 2015, 1:06 p.m. UTC
I suppose, the intention was to check only ODP_PMR_IPPROTO capability.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 test/validation/classification/odp_classification_tests.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Balasubramanian Manoharan July 15, 2015, 9:20 a.m. UTC | #1
Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

P.S: May be the patch description needs to change

On 14 July 2015 at 18:36, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
wrote:

> I suppose, the intention was to check only ODP_PMR_IPPROTO capability.
>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
> ---
>  test/validation/classification/odp_classification_tests.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/validation/classification/odp_classification_tests.c
> b/test/validation/classification/odp_classification_tests.c
> index 502105e..6e8d152 100644
> --- a/test/validation/classification/odp_classification_tests.c
> +++ b/test/validation/classification/odp_classification_tests.c
> @@ -807,7 +807,7 @@ static void classification_test_pmr_terms_cap(void)
>         unsigned long long retval;
>         /* Need to check different values for different platforms */
>         retval = odp_pmr_terms_cap();
> -       CU_ASSERT(retval | (1 << ODP_PMR_IPPROTO));
> +       CU_ASSERT(retval & (1 << ODP_PMR_IPPROTO));
>  }
>
>  static void classification_test_pktio_configure(void)
> --
> 1.9.1
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov July 16, 2015, 11:19 a.m. UTC | #2
Merged,

Maxim.

On 07/15/15 12:20, Bala Manoharan wrote:
> Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org 
> <mailto:bala.manoharan@linaro.org>>
>
> P.S: May be the patch description needs to change
>
fixed.

> On 14 July 2015 at 18:36, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org 
> <mailto:ivan.khoronzhuk@linaro.org>> wrote:
>
>     I suppose, the intention was to check only ODP_PMR_IPPROTO capability.
>
>     Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org
>     <mailto:ivan.khoronzhuk@linaro.org>>
>     ---
>      test/validation/classification/odp_classification_tests.c | 2 +-
>      1 file changed, 1 insertion(+), 1 deletion(-)
>
>     diff --git
>     a/test/validation/classification/odp_classification_tests.c
>     b/test/validation/classification/odp_classification_tests.c
>     index 502105e..6e8d152 100644
>     --- a/test/validation/classification/odp_classification_tests.c
>     +++ b/test/validation/classification/odp_classification_tests.c
>     @@ -807,7 +807,7 @@ static void
>     classification_test_pmr_terms_cap(void)
>             unsigned long long retval;
>             /* Need to check different values for different platforms */
>             retval = odp_pmr_terms_cap();
>     -       CU_ASSERT(retval | (1 << ODP_PMR_IPPROTO));
>     +       CU_ASSERT(retval & (1 << ODP_PMR_IPPROTO));
>      }
>
>      static void classification_test_pktio_configure(void)
>     --
>     1.9.1
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     https://lists.linaro.org/mailman/listinfo/lng-odp
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/classification/odp_classification_tests.c b/test/validation/classification/odp_classification_tests.c
index 502105e..6e8d152 100644
--- a/test/validation/classification/odp_classification_tests.c
+++ b/test/validation/classification/odp_classification_tests.c
@@ -807,7 +807,7 @@  static void classification_test_pmr_terms_cap(void)
 	unsigned long long retval;
 	/* Need to check different values for different platforms */
 	retval = odp_pmr_terms_cap();
-	CU_ASSERT(retval | (1 << ODP_PMR_IPPROTO));
+	CU_ASSERT(retval & (1 << ODP_PMR_IPPROTO));
 }
 
 static void classification_test_pktio_configure(void)