diff mbox

[PATCHv2] validation: cleaning up Makefile

Message ID 1436427022-7070-1-git-send-email-christophe.milard@linaro.org
State Accepted
Commit 4cdf96d25cf2a1a66e89d5ad2cff72306651e4ad
Headers show

Commit Message

Christophe Milard July 9, 2015, 7:30 a.m. UTC
The validation/Makefile.am is now simply calling the Makefile of
each module and many older things can be cleaned-up from it.

Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
---

since v1: rebased.
To be applied once all modules have been converted to be called from
the platform side, i.e. after pull request:
https://lists.linaro.org/pipermail/lng-odp/2015-July/013121.html

 test/validation/Makefile.am | 7 -------
 1 file changed, 7 deletions(-)

Comments

Christophe Milard July 9, 2015, 8:36 p.m. UTC | #1
Stuart: Can you review that obvious one as well? It belongs to the clean-up
stuff as well...
Thanks

/Christophe.

On 9 July 2015 at 09:30, Christophe Milard <christophe.milard@linaro.org>
wrote:

> The validation/Makefile.am is now simply calling the Makefile of
> each module and many older things can be cleaned-up from it.
>
> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
> ---
>
> since v1: rebased.
> To be applied once all modules have been converted to be called from
> the platform side, i.e. after pull request:
> https://lists.linaro.org/pipermail/lng-odp/2015-July/013121.html
>
>  test/validation/Makefile.am | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
> index 1b40d11..56ddd64 100644
> --- a/test/validation/Makefile.am
> +++ b/test/validation/Makefile.am
> @@ -1,10 +1,3 @@
> -AM_CFLAGS += -I$(srcdir)/common
> -AM_LDFLAGS += -static
> -
> -ODP_CU_COMMON=common/odp_cunit_common.c
> -
> -odp_crypto_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/crypto
> -
>  ODP_MODULES = buffer \
>               classification \
>               cpumask \
> --
> 1.9.1
>
>
Stuart Haslam July 10, 2015, 8:48 a.m. UTC | #2
On Thu, Jul 09, 2015 at 09:30:22AM +0200, Christophe Milard wrote:
> The validation/Makefile.am is now simply calling the Makefile of
> each module and many older things can be cleaned-up from it.
> 
> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>

Reviewed-by: Stuart Haslam <stuart.haslam@linaro.org>

> ---
> 
> since v1: rebased.
> To be applied once all modules have been converted to be called from
> the platform side, i.e. after pull request:
> https://lists.linaro.org/pipermail/lng-odp/2015-July/013121.html
> 
>  test/validation/Makefile.am | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
> index 1b40d11..56ddd64 100644
> --- a/test/validation/Makefile.am
> +++ b/test/validation/Makefile.am
> @@ -1,10 +1,3 @@
> -AM_CFLAGS += -I$(srcdir)/common
> -AM_LDFLAGS += -static
> -
> -ODP_CU_COMMON=common/odp_cunit_common.c
> -
> -odp_crypto_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/crypto
> -
>  ODP_MODULES = buffer \
>  	      classification \
>  	      cpumask \
> -- 
> 1.9.1
Maxim Uvarov July 10, 2015, 9:25 a.m. UTC | #3
Merged,

thanks,
Maxim.

On 07/10/15 11:49, Nicolas Morey-Chaisemartin wrote:
>
> On 07/09/2015 09:30 AM, Christophe Milard wrote:
>> The validation/Makefile.am is now simply calling the Makefile of
>> each module and many older things can be cleaned-up from it.
>>
>> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>
> Reviewed-by: Nicolas Morey-Chaisemartin <nmorey@kalray.eu>
>> ---
>>
>> since v1: rebased.
>> To be applied once all modules have been converted to be called from
>> the platform side, i.e. after pull request:
>> https://lists.linaro.org/pipermail/lng-odp/2015-July/013121.html
>>
>>   test/validation/Makefile.am | 7 -------
>>   1 file changed, 7 deletions(-)
>>
>> diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
>> index 1b40d11..56ddd64 100644
>> --- a/test/validation/Makefile.am
>> +++ b/test/validation/Makefile.am
>> @@ -1,10 +1,3 @@
>> -AM_CFLAGS += -I$(srcdir)/common
>> -AM_LDFLAGS += -static
>> -
>> -ODP_CU_COMMON=common/odp_cunit_common.c
>> -
>> -odp_crypto_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/crypto
>> -
>>   ODP_MODULES = buffer \
>>   	      classification \
>>   	      cpumask \
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> https://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/validation/Makefile.am b/test/validation/Makefile.am
index 1b40d11..56ddd64 100644
--- a/test/validation/Makefile.am
+++ b/test/validation/Makefile.am
@@ -1,10 +1,3 @@ 
-AM_CFLAGS += -I$(srcdir)/common
-AM_LDFLAGS += -static
-
-ODP_CU_COMMON=common/odp_cunit_common.c
-
-odp_crypto_CFLAGS = $(AM_CFLAGS) -I$(srcdir)/crypto
-
 ODP_MODULES = buffer \
 	      classification \
 	      cpumask \