diff mbox

[v2,media] exynos4-is: Fix potential null pointer dereference in mipi-csis.c

Message ID 1366966377-15808-1-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat April 26, 2013, 8:52 a.m. UTC
When 'node' is NULL, the print statement tries to dereference it.
Hence replace the variable with the one that is accessible.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
Changes since v1:
Used pdev->dev.of_node->full_name for node name.
---
 drivers/media/platform/exynos4-is/mipi-csis.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

On 04/26/2013 10:52 AM, Sachin Kamat wrote:
> When 'node' is NULL, the print statement tries to dereference it.
> Hence replace the variable with the one that is accessible.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> Changes since v1:
> Used pdev->dev.of_node->full_name for node name.

Patch applied for 3.10-rc2+, thanks.
diff mbox

Patch

diff --git a/drivers/media/platform/exynos4-is/mipi-csis.c b/drivers/media/platform/exynos4-is/mipi-csis.c
index a2eda9d..254d70f 100644
--- a/drivers/media/platform/exynos4-is/mipi-csis.c
+++ b/drivers/media/platform/exynos4-is/mipi-csis.c
@@ -746,7 +746,7 @@  static int s5pcsis_parse_dt(struct platform_device *pdev,
 	node = v4l2_of_get_next_endpoint(node, NULL);
 	if (!node) {
 		dev_err(&pdev->dev, "No port node at %s\n",
-					node->full_name);
+				pdev->dev.of_node->full_name);
 		return -EINVAL;
 	}
 	/* Get port node and validate MIPI-CSI channel id. */