| Message ID | 1430328364-12036-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | Accepted |
| Commit | 744e51162a9f6b9d7f5686c15dfaa2771533b72b |
| Headers | show |
On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolainen@nokia.com> wrote: > Hi, > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, since "api: > time: force time defines as ULL to avoid computation" actually changed the > API signature visible to the application. But I question if previous > increments to *API version* were necessary. For example, here are listed > all API changes between APIs v1.0.2 and v1.0.3 ... > > git diff v1.0.2..v1.0.3 -- include/odp > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h > index ae1cf0d..3338559 100644 > --- a/include/odp/api/version.h > +++ b/include/odp/api/version.h > @@ -46,7 +46,7 @@ extern "C" { > * to the API. For an API with common generation and major version, but > with > * different minor numbers the two versions are backward compatible. > */ > -#define ODP_VERSION_API_MINOR 2 > +#define ODP_VERSION_API_MINOR 3 > > /** > * Returns ODP API version string > > > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp > > > > .. absolutely nothing, but still we have another API version out there. > ODP release/validation suite/linux-generic implementation version can be > combined into one number, but it should be different from the ODP API > version number. Today the API version should be actually v1.0.1. > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - not sure how we did not pick up on that prior. The docs dont describe that well either. > -Petri > > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of ext > > Maxim Uvarov > > Sent: Wednesday, April 29, 2015 8:26 PM > > To: lng-odp@lists.linaro.org > > Subject: [lng-odp] [PATCH] update version number from v1.0.3 to v1.0.4 > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > > --- > > debian/changelog | 27 +++++++++++++++++++++++++++ > > include/odp/api/version.h | 2 +- > > 2 files changed, 28 insertions(+), 1 deletion(-) > > > > diff --git a/debian/changelog b/debian/changelog > > index 2087289..c6c0ec8 100644 > > --- a/debian/changelog > > +++ b/debian/changelog > > @@ -1,3 +1,30 @@ > > +opendataplane (1.0.4-1) unstable; urgency=low > > + > > + * test: > > + * validation: > > + - synchronizers: fix init of custom barrier atomic > > + - pktio: don't pass invalid handles > > + - use PRIu32 instead of %u to print uint32_t variables > > + - thread: add odp_thread sunnyday tests > > + - classification: add missing init of atomic variable > > + - api_test: remove odp_shm_test > > + * performance: > > + - pktio: fix check for pktio_tx > > + - pktio: test return value of odp_pktio_close() > > + - pktio: add throughput test > > + * example: > > + - ODP classifier example > > + * bugs: > > + - example: timer: clean up prescheduled events > > + * general: > > + - api: time: force time defines as ULL to avoid computation > > overflows on 32bits systems > > + - linux-generic: packet_io: init l2 and l3 cos table > spinlocks > > + - linux-generic: pool: initialize atomics during > > odp_pool_init_global > > + - linux-generic: pool: fix initialization of odp_buffer_hdr > > ref_count > > + - doc: api_guide_lines: add guidance on ODP_DEPRECATED > > + > > + -- Maxim Uvarov <maxim.uvarov@linaro.org> Wed, 29 Apr 2015 20:21:25 > > +0300 > > + > > opendataplane (1.0.3-1) unstable; urgency=low > > > > * test: > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h > > index 3338559..027095d 100644 > > --- a/include/odp/api/version.h > > +++ b/include/odp/api/version.h > > @@ -46,7 +46,7 @@ extern "C" { > > * to the API. For an API with common generation and major version, but > > with > > * different minor numbers the two versions are backward compatible. > > */ > > -#define ODP_VERSION_API_MINOR 3 > > +#define ODP_VERSION_API_MINOR 4 > > > > /** > > * Returns ODP API version string > > -- > > 1.9.1 > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > > https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
On 04/30/2015 14:51, Mike Holmes wrote: > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> wrote: > > Hi, > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, > since "api: time: force time defines as ULL to avoid computation" > actually changed the API signature visible to the application. But > I question if previous increments to *API version* were necessary. > For example, here are listed all API changes between APIs v1.0.2 > and v1.0.3 ... > > git diff v1.0.2..v1.0.3 -- include/odp > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h > index ae1cf0d..3338559 100644 > --- a/include/odp/api/version.h > +++ b/include/odp/api/version.h > @@ -46,7 +46,7 @@ extern "C" { > * to the API. For an API with common generation and major > version, but with > * different minor numbers the two versions are backward compatible. > */ > -#define ODP_VERSION_API_MINOR 2 > +#define ODP_VERSION_API_MINOR 3 > > /** > * Returns ODP API version string > > > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp > > > > .. absolutely nothing, but still we have another API version out > there. ODP release/validation suite/linux-generic implementation > version can be combined into one number, but it should be > different from the ODP API version number. Today the API version > should be actually v1.0.1. > > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - not > sure how we did not pick up on that prior. The docs dont describe that > well either. Because we also update validation test suite, which also needs it's number increased somewhere and we have only API_MINOR for that. Maxim. > > > -Petri > > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org > <mailto:lng-odp-bounces@lists.linaro.org>] On Behalf Of ext > > Maxim Uvarov > > Sent: Wednesday, April 29, 2015 8:26 PM > > To: lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > > Subject: [lng-odp] [PATCH] update version number from v1.0.3 to > v1.0.4 > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> > > --- > > debian/changelog | 27 +++++++++++++++++++++++++++ > > include/odp/api/version.h | 2 +- > > 2 files changed, 28 insertions(+), 1 deletion(-) > > > > diff --git a/debian/changelog b/debian/changelog > > index 2087289..c6c0ec8 100644 > > --- a/debian/changelog > > +++ b/debian/changelog > > @@ -1,3 +1,30 @@ > > +opendataplane (1.0.4-1) unstable; urgency=low > > + > > + * test: > > + * validation: > > + - synchronizers: fix init of custom barrier atomic > > + - pktio: don't pass invalid handles > > + - use PRIu32 instead of %u to print uint32_t variables > > + - thread: add odp_thread sunnyday tests > > + - classification: add missing init of atomic variable > > + - api_test: remove odp_shm_test > > + * performance: > > + - pktio: fix check for pktio_tx > > + - pktio: test return value of odp_pktio_close() > > + - pktio: add throughput test > > + * example: > > + - ODP classifier example > > + * bugs: > > + - example: timer: clean up prescheduled events > > + * general: > > + - api: time: force time defines as ULL to avoid > computation > > overflows on 32bits systems > > + - linux-generic: packet_io: init l2 and l3 cos table > spinlocks > > + - linux-generic: pool: initialize atomics during > > odp_pool_init_global > > + - linux-generic: pool: fix initialization of > odp_buffer_hdr > > ref_count > > + - doc: api_guide_lines: add guidance on ODP_DEPRECATED > > + > > + -- Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> Wed, 29 Apr 2015 20:21:25 > > +0300 > > + > > opendataplane (1.0.3-1) unstable; urgency=low > > > > * test: > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h > > index 3338559..027095d 100644 > > --- a/include/odp/api/version.h > > +++ b/include/odp/api/version.h > > @@ -46,7 +46,7 @@ extern "C" { > > * to the API. For an API with common generation and major > version, but > > with > > * different minor numbers the two versions are backward > compatible. > > */ > > -#define ODP_VERSION_API_MINOR 3 > > +#define ODP_VERSION_API_MINOR 4 > > > > /** > > * Returns ODP API version string > > -- > > 1.9.1 > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > > https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs >
On 30 April 2015 at 09:32, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 04/30/2015 14:51, Mike Holmes wrote: > > >> On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) < >> petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> wrote: >> >> Hi, >> >> This time it is appropriate to bump the ODP_VERSION_API_MINOR, >> since "api: time: force time defines as ULL to avoid computation" >> actually changed the API signature visible to the application. But >> I question if previous increments to *API version* were necessary. >> For example, here are listed all API changes between APIs v1.0.2 >> and v1.0.3 ... >> >> git diff v1.0.2..v1.0.3 -- include/odp >> >> diff --git a/include/odp/api/version.h b/include/odp/api/version.h >> index ae1cf0d..3338559 100644 >> --- a/include/odp/api/version.h >> +++ b/include/odp/api/version.h >> @@ -46,7 +46,7 @@ extern "C" { >> * to the API. For an API with common generation and major >> version, but with >> * different minor numbers the two versions are backward compatible. >> */ >> -#define ODP_VERSION_API_MINOR 2 >> +#define ODP_VERSION_API_MINOR 3 >> >> /** >> * Returns ODP API version string >> >> >> >> git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >> >> >> >> .. absolutely nothing, but still we have another API version out >> there. ODP release/validation suite/linux-generic implementation >> version can be combined into one number, but it should be >> different from the ODP API version number. Today the API version >> should be actually v1.0.1. >> >> >> Completely agree should have been bumping ODP_VERSION_IMPL_STR - not >> sure how we did not pick up on that prior. The docs dont describe that well >> either. >> > > > Because we also update validation test suite, which also needs it's number > increased somewhere and we have only API_MINOR for that. > Good point. Since tests should reflect the API version we are back in a tangle unless we introduce a test version number that normally equals API number but increments minor independently. We keep coming wound to these issues becasue the API, tests and reference implementation at all in the same repo IMHO. Would it be better to use the git repo command and a manifest that gathers the correct parts, the api, implementation and tests so that the developers local directory looks approximately as it does now, but it is contained in separate repos ? Yes I know this will mean some synchronization when an API, implementation and tests all need to be updated at once. However in many cases we can independently improve tests and implementation. The same rules apply though in that a new api does not get out of api-next until all these parts are present in api-next and pass CI. > Maxim. > > >> >> -Petri >> >> >> >> > -----Original Message----- >> > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org >> <mailto:lng-odp-bounces@lists.linaro.org>] On Behalf Of ext >> > Maxim Uvarov >> > Sent: Wednesday, April 29, 2015 8:26 PM >> > To: lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> > Subject: [lng-odp] [PATCH] update version number from v1.0.3 to >> v1.0.4 >> > >> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org>> >> >> > --- >> > debian/changelog | 27 +++++++++++++++++++++++++++ >> > include/odp/api/version.h | 2 +- >> > 2 files changed, 28 insertions(+), 1 deletion(-) >> > >> > diff --git a/debian/changelog b/debian/changelog >> > index 2087289..c6c0ec8 100644 >> > --- a/debian/changelog >> > +++ b/debian/changelog >> > @@ -1,3 +1,30 @@ >> > +opendataplane (1.0.4-1) unstable; urgency=low >> > + >> > + * test: >> > + * validation: >> > + - synchronizers: fix init of custom barrier atomic >> > + - pktio: don't pass invalid handles >> > + - use PRIu32 instead of %u to print uint32_t variables >> > + - thread: add odp_thread sunnyday tests >> > + - classification: add missing init of atomic variable >> > + - api_test: remove odp_shm_test >> > + * performance: >> > + - pktio: fix check for pktio_tx >> > + - pktio: test return value of odp_pktio_close() >> > + - pktio: add throughput test >> > + * example: >> > + - ODP classifier example >> > + * bugs: >> > + - example: timer: clean up prescheduled events >> > + * general: >> > + - api: time: force time defines as ULL to avoid >> computation >> > overflows on 32bits systems >> > + - linux-generic: packet_io: init l2 and l3 cos table >> spinlocks >> > + - linux-generic: pool: initialize atomics during >> > odp_pool_init_global >> > + - linux-generic: pool: fix initialization of >> odp_buffer_hdr >> > ref_count >> > + - doc: api_guide_lines: add guidance on ODP_DEPRECATED >> > + >> > + -- Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org>> Wed, 29 Apr 2015 20:21:25 >> > +0300 >> > + >> > opendataplane (1.0.3-1) unstable; urgency=low >> > >> > * test: >> > diff --git a/include/odp/api/version.h b/include/odp/api/version.h >> > index 3338559..027095d 100644 >> > --- a/include/odp/api/version.h >> > +++ b/include/odp/api/version.h >> > @@ -46,7 +46,7 @@ extern "C" { >> > * to the API. For an API with common generation and major >> version, but >> > with >> > * different minor numbers the two versions are backward >> compatible. >> > */ >> > -#define ODP_VERSION_API_MINOR 3 >> > +#define ODP_VERSION_API_MINOR 4 >> > >> > /** >> > * Returns ODP API version string >> > -- >> > 1.9.1 >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> > https://lists.linaro.org/mailman/listinfo/lng-odp >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM >> SoCs >> >> >
On 04/30/2015 16:59, Mike Holmes wrote: > > > On 30 April 2015 at 09:32, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > On 04/30/2015 14:51, Mike Holmes wrote: > > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - > FI/Espoo) <petri.savolainen@nokia.com > <mailto:petri.savolainen@nokia.com> > <mailto:petri.savolainen@nokia.com > <mailto:petri.savolainen@nokia.com>>> wrote: > > Hi, > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, > since "api: time: force time defines as ULL to avoid > computation" > actually changed the API signature visible to the > application. But > I question if previous increments to *API version* were > necessary. > For example, here are listed all API changes between APIs > v1.0.2 > and v1.0.3 ... > > git diff v1.0.2..v1.0.3 -- include/odp > > diff --git a/include/odp/api/version.h > b/include/odp/api/version.h > index ae1cf0d..3338559 100644 > --- a/include/odp/api/version.h > +++ b/include/odp/api/version.h > @@ -46,7 +46,7 @@ extern "C" { > * to the API. For an API with common generation and major > version, but with > * different minor numbers the two versions are backward > compatible. > */ > -#define ODP_VERSION_API_MINOR 2 > +#define ODP_VERSION_API_MINOR 3 > > /** > * Returns ODP API version string > > > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp > > > > .. absolutely nothing, but still we have another API > version out > there. ODP release/validation suite/linux-generic > implementation > version can be combined into one number, but it should be > different from the ODP API version number. Today the API > version > should be actually v1.0.1. > > > Completely agree should have been bumping > ODP_VERSION_IMPL_STR - not sure how we did not pick up on that > prior. The docs dont describe that well either. > > > > Because we also update validation test suite, which also needs > it's number increased somewhere and we have only API_MINOR for that. > > > Good point. > Since tests should reflect the API version we are back in a tangle > unless we introduce a test version number that normally equals API > number but increments minor independently. > > We keep coming wound to these issues becasue the API, tests and > reference implementation at all in the same repo IMHO. > > Would it be better to use the git repo command and a manifest that > gathers the correct parts, the api, implementation and tests so that > the developers local directory looks approximately as it does now, but > it is contained in separate repos ? > Yes I know this will mean some synchronization when an API, > implementation and tests all need to be updated at once. However in > many cases we can independently improve tests and implementation. > > The same rules apply though in that a new api does not get out of > api-next until all these parts are present in api-next and pass CI. > I think we need to do some demo for that then see how it will be useful or now. Maxim. > > Maxim. > > > > -Petri > > > > > -----Original Message----- > > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org > <mailto:lng-odp-bounces@lists.linaro.org> > <mailto:lng-odp-bounces@lists.linaro.org > <mailto:lng-odp-bounces@lists.linaro.org>>] On Behalf Of ext > > Maxim Uvarov > > Sent: Wednesday, April 29, 2015 8:26 PM > > To: lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org> > <mailto:lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org>> > > Subject: [lng-odp] [PATCH] update version number from > v1.0.3 to > v1.0.4 > > > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org> > <mailto:maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>>> > > > --- > > debian/changelog | 27 +++++++++++++++++++++++++++ > > include/odp/api/version.h | 2 +- > > 2 files changed, 28 insertions(+), 1 deletion(-) > > > > diff --git a/debian/changelog b/debian/changelog > > index 2087289..c6c0ec8 100644 > > --- a/debian/changelog > > +++ b/debian/changelog > > @@ -1,3 +1,30 @@ > > +opendataplane (1.0.4-1) unstable; urgency=low > > + > > + * test: > > + * validation: > > + - synchronizers: fix init of custom barrier > atomic > > + - pktio: don't pass invalid handles > > + - use PRIu32 instead of %u to print uint32_t > variables > > + - thread: add odp_thread sunnyday tests > > + - classification: add missing init of atomic > variable > > + - api_test: remove odp_shm_test > > + * performance: > > + - pktio: fix check for pktio_tx > > + - pktio: test return value of odp_pktio_close() > > + - pktio: add throughput test > > + * example: > > + - ODP classifier example > > + * bugs: > > + - example: timer: clean up prescheduled events > > + * general: > > + - api: time: force time defines as ULL to avoid > computation > > overflows on 32bits systems > > + - linux-generic: packet_io: init l2 and l3 > cos table > spinlocks > > + - linux-generic: pool: initialize atomics during > > odp_pool_init_global > > + - linux-generic: pool: fix initialization of > odp_buffer_hdr > > ref_count > > + - doc: api_guide_lines: add guidance on > ODP_DEPRECATED > > + > > + -- Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org> > <mailto:maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>>> Wed, 29 Apr 2015 20:21:25 > > +0300 > > + > > opendataplane (1.0.3-1) unstable; urgency=low > > > > * test: > > diff --git a/include/odp/api/version.h > b/include/odp/api/version.h > > index 3338559..027095d 100644 > > --- a/include/odp/api/version.h > > +++ b/include/odp/api/version.h > > @@ -46,7 +46,7 @@ extern "C" { > > * to the API. For an API with common generation and major > version, but > > with > > * different minor numbers the two versions are backward > compatible. > > */ > > -#define ODP_VERSION_API_MINOR 3 > > +#define ODP_VERSION_API_MINOR 4 > > > > /** > > * Returns ODP API version string > > -- > > 1.9.1 > > > > _______________________________________________ > > lng-odp mailing list > > lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org> > <mailto:lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org>> > > https://lists.linaro.org/mailman/listinfo/lng-odp > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > <mailto:lng-odp@lists.linaro.org > <mailto:lng-odp@lists.linaro.org>> > https://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software > for ARM SoCs > > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs >
On 30 April 2015 at 12:52, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 04/30/2015 16:59, Mike Holmes wrote: > >> >> >> On 30 April 2015 at 09:32, Maxim Uvarov <maxim.uvarov@linaro.org <mailto: >> maxim.uvarov@linaro.org>> wrote: >> >> On 04/30/2015 14:51, Mike Holmes wrote: >> >> >> On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - >> FI/Espoo) <petri.savolainen@nokia.com >> <mailto:petri.savolainen@nokia.com> >> <mailto:petri.savolainen@nokia.com >> >> <mailto:petri.savolainen@nokia.com>>> wrote: >> >> Hi, >> >> This time it is appropriate to bump the ODP_VERSION_API_MINOR, >> since "api: time: force time defines as ULL to avoid >> computation" >> actually changed the API signature visible to the >> application. But >> I question if previous increments to *API version* were >> necessary. >> For example, here are listed all API changes between APIs >> v1.0.2 >> and v1.0.3 ... >> >> git diff v1.0.2..v1.0.3 -- include/odp >> >> diff --git a/include/odp/api/version.h >> b/include/odp/api/version.h >> index ae1cf0d..3338559 100644 >> --- a/include/odp/api/version.h >> +++ b/include/odp/api/version.h >> @@ -46,7 +46,7 @@ extern "C" { >> * to the API. For an API with common generation and major >> version, but with >> * different minor numbers the two versions are backward >> compatible. >> */ >> -#define ODP_VERSION_API_MINOR 2 >> +#define ODP_VERSION_API_MINOR 3 >> >> /** >> * Returns ODP API version string >> >> >> >> git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >> >> >> >> .. absolutely nothing, but still we have another API >> version out >> there. ODP release/validation suite/linux-generic >> implementation >> version can be combined into one number, but it should be >> different from the ODP API version number. Today the API >> version >> should be actually v1.0.1. >> >> >> Completely agree should have been bumping >> ODP_VERSION_IMPL_STR - not sure how we did not pick up on that >> prior. The docs dont describe that well either. >> >> >> >> Because we also update validation test suite, which also needs >> it's number increased somewhere and we have only API_MINOR for that. >> >> >> Good point. >> Since tests should reflect the API version we are back in a tangle unless >> we introduce a test version number that normally equals API number but >> increments minor independently. >> >> We keep coming wound to these issues becasue the API, tests and reference >> implementation at all in the same repo IMHO. >> >> Would it be better to use the git repo command and a manifest that >> gathers the correct parts, the api, implementation and tests so that the >> developers local directory looks approximately as it does now, but it is >> contained in separate repos ? >> Yes I know this will mean some synchronization when an API, >> implementation and tests all need to be updated at once. However in many >> cases we can independently improve tests and implementation. >> >> The same rules apply though in that a new api does not get out of >> api-next until all these parts are present in api-next and pass CI. >> >> I think we need to do some demo for that then see how it will be useful > or now. > Basic instructions at http://www.instructables.com/id/Using-Googles-repo-command-in-your-own-projects/ A bare minimum manifest I played with just for dpdk & odp-dpdk for example looks like this https://git.linaro.org/people/mike.holmes/odp-dpdk-manifest.git To use it to pull the specified versions in the manifest mkdir repo_test cd repo_test repo init -u "http://git.linaro.org/people/mike.holmes/odp-dpdk-manifest.git " repo sync ls dpdk odp-dpdk From here on it is just a regular git workflow. > > Maxim. > > >> Maxim. >> >> >> >> -Petri >> >> >> >> > -----Original Message----- >> > From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org >> <mailto:lng-odp-bounces@lists.linaro.org> >> <mailto:lng-odp-bounces@lists.linaro.org >> <mailto:lng-odp-bounces@lists.linaro.org>>] On Behalf Of ext >> > Maxim Uvarov >> > Sent: Wednesday, April 29, 2015 8:26 PM >> > To: lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org> >> <mailto:lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org>> >> > Subject: [lng-odp] [PATCH] update version number from >> v1.0.3 to >> v1.0.4 >> > >> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org> >> <mailto:maxim.uvarov@linaro.org >> >> <mailto:maxim.uvarov@linaro.org>>> >> >> > --- >> > debian/changelog | 27 +++++++++++++++++++++++++++ >> > include/odp/api/version.h | 2 +- >> > 2 files changed, 28 insertions(+), 1 deletion(-) >> > >> > diff --git a/debian/changelog b/debian/changelog >> > index 2087289..c6c0ec8 100644 >> > --- a/debian/changelog >> > +++ b/debian/changelog >> > @@ -1,3 +1,30 @@ >> > +opendataplane (1.0.4-1) unstable; urgency=low >> > + >> > + * test: >> > + * validation: >> > + - synchronizers: fix init of custom barrier >> atomic >> > + - pktio: don't pass invalid handles >> > + - use PRIu32 instead of %u to print uint32_t >> variables >> > + - thread: add odp_thread sunnyday tests >> > + - classification: add missing init of atomic >> variable >> > + - api_test: remove odp_shm_test >> > + * performance: >> > + - pktio: fix check for pktio_tx >> > + - pktio: test return value of odp_pktio_close() >> > + - pktio: add throughput test >> > + * example: >> > + - ODP classifier example >> > + * bugs: >> > + - example: timer: clean up prescheduled events >> > + * general: >> > + - api: time: force time defines as ULL to avoid >> computation >> > overflows on 32bits systems >> > + - linux-generic: packet_io: init l2 and l3 >> cos table >> spinlocks >> > + - linux-generic: pool: initialize atomics during >> > odp_pool_init_global >> > + - linux-generic: pool: fix initialization of >> odp_buffer_hdr >> > ref_count >> > + - doc: api_guide_lines: add guidance on >> ODP_DEPRECATED >> > + >> > + -- Maxim Uvarov <maxim.uvarov@linaro.org >> <mailto:maxim.uvarov@linaro.org> >> <mailto:maxim.uvarov@linaro.org >> >> <mailto:maxim.uvarov@linaro.org>>> Wed, 29 Apr 2015 20:21:25 >> > +0300 >> > + >> > opendataplane (1.0.3-1) unstable; urgency=low >> > >> > * test: >> > diff --git a/include/odp/api/version.h >> b/include/odp/api/version.h >> > index 3338559..027095d 100644 >> > --- a/include/odp/api/version.h >> > +++ b/include/odp/api/version.h >> > @@ -46,7 +46,7 @@ extern "C" { >> > * to the API. For an API with common generation and major >> version, but >> > with >> > * different minor numbers the two versions are backward >> compatible. >> > */ >> > -#define ODP_VERSION_API_MINOR 3 >> > +#define ODP_VERSION_API_MINOR 4 >> > >> > /** >> > * Returns ODP API version string >> > -- >> > 1.9.1 >> > >> > _______________________________________________ >> > lng-odp mailing list >> > lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org> >> <mailto:lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org>> >> > https://lists.linaro.org/mailman/listinfo/lng-odp >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> >> <mailto:lng-odp@lists.linaro.org >> <mailto:lng-odp@lists.linaro.org>> >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> >> >> >> -- Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/>***│ *Open source software >> for ARM SoCs >> >> >> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM >> SoCs >> >> >
I had suggested last year that we number the APIs to reflect architectural changes but that implementations use a build number to indicate service changes. So you'd say something like "I'm running odp-dpdk v1.1 build 16" or "I'm running validation suite v1.3 build 4" to make the distinction clear. If you want to have a single number than the last digit is the build number, but then that also seems to keep needing to be explained so it's simpler to explicitly state the build number as a separate designator. On Mon, May 4, 2015 at 4:52 AM, Savolainen, Petri (Nokia - FI/Espoo) < petri.savolainen@nokia.com> wrote: > > > > -----Original Message----- > > From: ext Maxim Uvarov [mailto:maxim.uvarov@linaro.org] > > Sent: Thursday, April 30, 2015 4:33 PM > > To: Mike Holmes; Savolainen, Petri (Nokia - FI/Espoo) > > Cc: lng-odp@lists.linaro.org > > Subject: Re: [lng-odp] [PATCH] update version number from v1.0.3 to > v1.0.4 > > > > On 04/30/2015 14:51, Mike Holmes wrote: > > > > > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) > > > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> > wrote: > > > > > > Hi, > > > > > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, > > > since "api: time: force time defines as ULL to avoid computation" > > > actually changed the API signature visible to the application. But > > > I question if previous increments to *API version* were necessary. > > > For example, here are listed all API changes between APIs v1.0.2 > > > and v1.0.3 ... > > > > > > git diff v1.0.2..v1.0.3 -- include/odp > > > > > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h > > > index ae1cf0d..3338559 100644 > > > --- a/include/odp/api/version.h > > > +++ b/include/odp/api/version.h > > > @@ -46,7 +46,7 @@ extern "C" { > > > * to the API. For an API with common generation and major > > > version, but with > > > * different minor numbers the two versions are backward > > compatible. > > > */ > > > -#define ODP_VERSION_API_MINOR 2 > > > +#define ODP_VERSION_API_MINOR 3 > > > > > > /** > > > * Returns ODP API version string > > > > > > > > > > > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp > > > > > > > > > > > > .. absolutely nothing, but still we have another API version out > > > there. ODP release/validation suite/linux-generic implementation > > > version can be combined into one number, but it should be > > > different from the ODP API version number. Today the API version > > > should be actually v1.0.1. > > > > > > > > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - not > > > sure how we did not pick up on that prior. The docs dont describe that > > > well either. > > > > > > Because we also update validation test suite, which also needs it's > > number increased somewhere and we have only API_MINOR for that. > > > > Maxim. > > > The validation suite must have its own version numbering scheme (separate > from the API) since it will also have bugs. A suite has test cases against > a specific API version (e.g. API v1.0.1), but may not be complete and may > have known/unknown bugs, etc. The suite version number is bumped every time > the suite is modified e.g. from v1.0.1-4 to v1.0.1-5. Basically each API > version would have a matching validation suite, but we may skip some API > versions and publish validation suites only for certain (good / important) > API versions. E.g. a list of latest suite versions could be v1.0.1-5 (for > API v1.0.1), v1.0.3-2 (for API v1.0.3), ... > > It's another topic if we want to combine validation suite and reference > implementation (linux-generic) release cycles and version numbering ... > which makes sense since it indicates on which implementation (version) the > suite was tested on. > > > -Petri > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
On 4 May 2015 at 07:31, Bill Fischofer <bill.fischofer@linaro.org> wrote: > I had suggested last year that we number the APIs to reflect architectural > changes but that implementations use a build number to indicate service > changes. So you'd say something like "I'm running odp-dpdk v1.1 build 16" > or "I'm running validation suite v1.3 build 4" to make the distinction > clear. > I think the need for would be covered by odp_version_impl_str() <http://people.linaro.org/~mike.holmes/odp-api/html/group__odp__ver__abt__log__dbg.html#gab6931e3029d875bfef5012d076468849> we have not been using it however. It should increment for any change at all when tagged. I have updated the api-doc material on versioning - here is a 1st pass cut rendered as html, it still needs a touch up here and there http://people.linaro.org/~mike.holmes/odp-api/html/release.htm > If you want to have a single number than the last digit is the build > number, but then that also seems to keep needing to be explained so it's > simpler to explicitly state the build number as a separate designator. > > On Mon, May 4, 2015 at 4:52 AM, Savolainen, Petri (Nokia - FI/Espoo) < > petri.savolainen@nokia.com> wrote: > >> >> >> > -----Original Message----- >> > From: ext Maxim Uvarov [mailto:maxim.uvarov@linaro.org] >> > Sent: Thursday, April 30, 2015 4:33 PM >> > To: Mike Holmes; Savolainen, Petri (Nokia - FI/Espoo) >> > Cc: lng-odp@lists.linaro.org >> > Subject: Re: [lng-odp] [PATCH] update version number from v1.0.3 to >> v1.0.4 >> > >> > On 04/30/2015 14:51, Mike Holmes wrote: >> > > >> > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) >> > > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> >> wrote: >> > > >> > > Hi, >> > > >> > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, >> > > since "api: time: force time defines as ULL to avoid computation" >> > > actually changed the API signature visible to the application. But >> > > I question if previous increments to *API version* were necessary. >> > > For example, here are listed all API changes between APIs v1.0.2 >> > > and v1.0.3 ... >> > > >> > > git diff v1.0.2..v1.0.3 -- include/odp >> > > >> > > diff --git a/include/odp/api/version.h b/include/odp/api/version.h >> > > index ae1cf0d..3338559 100644 >> > > --- a/include/odp/api/version.h >> > > +++ b/include/odp/api/version.h >> > > @@ -46,7 +46,7 @@ extern "C" { >> > > * to the API. For an API with common generation and major >> > > version, but with >> > > * different minor numbers the two versions are backward >> > compatible. >> > > */ >> > > -#define ODP_VERSION_API_MINOR 2 >> > > +#define ODP_VERSION_API_MINOR 3 >> > > >> > > /** >> > > * Returns ODP API version string >> > > >> > > >> > > >> > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >> > > >> > > >> > > >> > > .. absolutely nothing, but still we have another API version out >> > > there. ODP release/validation suite/linux-generic implementation >> > > version can be combined into one number, but it should be >> > > different from the ODP API version number. Today the API version >> > > should be actually v1.0.1. >> > > >> > > >> > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - not >> > > sure how we did not pick up on that prior. The docs dont describe that >> > > well either. >> > >> > >> > Because we also update validation test suite, which also needs it's >> > number increased somewhere and we have only API_MINOR for that. >> > >> > Maxim. >> >> >> The validation suite must have its own version numbering scheme (separate >> from the API) since it will also have bugs. A suite has test cases against >> a specific API version (e.g. API v1.0.1), but may not be complete and may >> have known/unknown bugs, etc. The suite version number is bumped every time >> the suite is modified e.g. from v1.0.1-4 to v1.0.1-5. Basically each API >> version would have a matching validation suite, but we may skip some API >> versions and publish validation suites only for certain (good / important) >> API versions. E.g. a list of latest suite versions could be v1.0.1-5 (for >> API v1.0.1), v1.0.3-2 (for API v1.0.3), ... >> >> It's another topic if we want to combine validation suite and reference >> implementation (linux-generic) release cycles and version numbering ... >> which makes sense since it indicates on which implementation (version) the >> suite was tested on. >> >> >> -Petri >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/lng-odp >> > >
Mike, your last URL gives a "Not Found" result. On Mon, May 4, 2015 at 9:52 AM, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 4 May 2015 at 07:31, Bill Fischofer <bill.fischofer@linaro.org> wrote: > >> I had suggested last year that we number the APIs to reflect >> architectural changes but that implementations use a build number to >> indicate service changes. So you'd say something like "I'm running >> odp-dpdk v1.1 build 16" or "I'm running validation suite v1.3 build 4" to >> make the distinction clear. >> > > I think the need for would be covered by odp_version_impl_str() > <http://people.linaro.org/~mike.holmes/odp-api/html/group__odp__ver__abt__log__dbg.html#gab6931e3029d875bfef5012d076468849> > we have not been using it however. > It should increment for any change at all when tagged. > > I have updated the api-doc material on versioning - here is a 1st pass cut > rendered as html, it still needs a touch up here and there > > http://people.linaro.org/~mike.holmes/odp-api/html/release.htm > > > >> If you want to have a single number than the last digit is the build >> number, but then that also seems to keep needing to be explained so it's >> simpler to explicitly state the build number as a separate designator. >> >> On Mon, May 4, 2015 at 4:52 AM, Savolainen, Petri (Nokia - FI/Espoo) < >> petri.savolainen@nokia.com> wrote: >> >>> >>> >>> > -----Original Message----- >>> > From: ext Maxim Uvarov [mailto:maxim.uvarov@linaro.org] >>> > Sent: Thursday, April 30, 2015 4:33 PM >>> > To: Mike Holmes; Savolainen, Petri (Nokia - FI/Espoo) >>> > Cc: lng-odp@lists.linaro.org >>> > Subject: Re: [lng-odp] [PATCH] update version number from v1.0.3 to >>> v1.0.4 >>> > >>> > On 04/30/2015 14:51, Mike Holmes wrote: >>> > > >>> > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) >>> > > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> >>> wrote: >>> > > >>> > > Hi, >>> > > >>> > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, >>> > > since "api: time: force time defines as ULL to avoid computation" >>> > > actually changed the API signature visible to the application. >>> But >>> > > I question if previous increments to *API version* were >>> necessary. >>> > > For example, here are listed all API changes between APIs v1.0.2 >>> > > and v1.0.3 ... >>> > > >>> > > git diff v1.0.2..v1.0.3 -- include/odp >>> > > >>> > > diff --git a/include/odp/api/version.h >>> b/include/odp/api/version.h >>> > > index ae1cf0d..3338559 100644 >>> > > --- a/include/odp/api/version.h >>> > > +++ b/include/odp/api/version.h >>> > > @@ -46,7 +46,7 @@ extern "C" { >>> > > * to the API. For an API with common generation and major >>> > > version, but with >>> > > * different minor numbers the two versions are backward >>> > compatible. >>> > > */ >>> > > -#define ODP_VERSION_API_MINOR 2 >>> > > +#define ODP_VERSION_API_MINOR 3 >>> > > >>> > > /** >>> > > * Returns ODP API version string >>> > > >>> > > >>> > > >>> > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >>> > > >>> > > >>> > > >>> > > .. absolutely nothing, but still we have another API version out >>> > > there. ODP release/validation suite/linux-generic implementation >>> > > version can be combined into one number, but it should be >>> > > different from the ODP API version number. Today the API version >>> > > should be actually v1.0.1. >>> > > >>> > > >>> > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - not >>> > > sure how we did not pick up on that prior. The docs dont describe >>> that >>> > > well either. >>> > >>> > >>> > Because we also update validation test suite, which also needs it's >>> > number increased somewhere and we have only API_MINOR for that. >>> > >>> > Maxim. >>> >>> >>> The validation suite must have its own version numbering scheme >>> (separate from the API) since it will also have bugs. A suite has test >>> cases against a specific API version (e.g. API v1.0.1), but may not be >>> complete and may have known/unknown bugs, etc. The suite version number is >>> bumped every time the suite is modified e.g. from v1.0.1-4 to v1.0.1-5. >>> Basically each API version would have a matching validation suite, but we >>> may skip some API versions and publish validation suites only for certain >>> (good / important) API versions. E.g. a list of latest suite versions could >>> be v1.0.1-5 (for API v1.0.1), v1.0.3-2 (for API v1.0.3), ... >>> >>> It's another topic if we want to combine validation suite and reference >>> implementation (linux-generic) release cycles and version numbering ... >>> which makes sense since it indicates on which implementation (version) the >>> suite was tested on. >>> >>> >>> -Petri >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> https://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs > > >
http://people.linaro.org/~mike.holmes/odp-api/html/release.html When I paste this it works for me - not sure where it is going wrong does http://people.linaro.org/~mike.holmes/odp-api/html work for you ? - if so look at the Release Management tab. On 4 May 2015 at 15:22, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Mike, your last URL gives a "Not Found" result. > > On Mon, May 4, 2015 at 9:52 AM, Mike Holmes <mike.holmes@linaro.org> > wrote: > >> >> >> On 4 May 2015 at 07:31, Bill Fischofer <bill.fischofer@linaro.org> wrote: >> >>> I had suggested last year that we number the APIs to reflect >>> architectural changes but that implementations use a build number to >>> indicate service changes. So you'd say something like "I'm running >>> odp-dpdk v1.1 build 16" or "I'm running validation suite v1.3 build 4" to >>> make the distinction clear. >>> >> >> I think the need for would be covered by odp_version_impl_str() >> <http://people.linaro.org/~mike.holmes/odp-api/html/group__odp__ver__abt__log__dbg.html#gab6931e3029d875bfef5012d076468849> >> we have not been using it however. >> It should increment for any change at all when tagged. >> >> I have updated the api-doc material on versioning - here is a 1st pass >> cut rendered as html, it still needs a touch up here and there >> >> http://people.linaro.org/~mike.holmes/odp-api/html/release.htm >> >> >> >>> If you want to have a single number than the last digit is the build >>> number, but then that also seems to keep needing to be explained so it's >>> simpler to explicitly state the build number as a separate designator. >>> >>> On Mon, May 4, 2015 at 4:52 AM, Savolainen, Petri (Nokia - FI/Espoo) < >>> petri.savolainen@nokia.com> wrote: >>> >>>> >>>> >>>> > -----Original Message----- >>>> > From: ext Maxim Uvarov [mailto:maxim.uvarov@linaro.org] >>>> > Sent: Thursday, April 30, 2015 4:33 PM >>>> > To: Mike Holmes; Savolainen, Petri (Nokia - FI/Espoo) >>>> > Cc: lng-odp@lists.linaro.org >>>> > Subject: Re: [lng-odp] [PATCH] update version number from v1.0.3 to >>>> v1.0.4 >>>> > >>>> > On 04/30/2015 14:51, Mike Holmes wrote: >>>> > > >>>> > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) >>>> > > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> >>>> wrote: >>>> > > >>>> > > Hi, >>>> > > >>>> > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, >>>> > > since "api: time: force time defines as ULL to avoid >>>> computation" >>>> > > actually changed the API signature visible to the application. >>>> But >>>> > > I question if previous increments to *API version* were >>>> necessary. >>>> > > For example, here are listed all API changes between APIs v1.0.2 >>>> > > and v1.0.3 ... >>>> > > >>>> > > git diff v1.0.2..v1.0.3 -- include/odp >>>> > > >>>> > > diff --git a/include/odp/api/version.h >>>> b/include/odp/api/version.h >>>> > > index ae1cf0d..3338559 100644 >>>> > > --- a/include/odp/api/version.h >>>> > > +++ b/include/odp/api/version.h >>>> > > @@ -46,7 +46,7 @@ extern "C" { >>>> > > * to the API. For an API with common generation and major >>>> > > version, but with >>>> > > * different minor numbers the two versions are backward >>>> > compatible. >>>> > > */ >>>> > > -#define ODP_VERSION_API_MINOR 2 >>>> > > +#define ODP_VERSION_API_MINOR 3 >>>> > > >>>> > > /** >>>> > > * Returns ODP API version string >>>> > > >>>> > > >>>> > > >>>> > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >>>> > > >>>> > > >>>> > > >>>> > > .. absolutely nothing, but still we have another API version out >>>> > > there. ODP release/validation suite/linux-generic implementation >>>> > > version can be combined into one number, but it should be >>>> > > different from the ODP API version number. Today the API version >>>> > > should be actually v1.0.1. >>>> > > >>>> > > >>>> > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - >>>> not >>>> > > sure how we did not pick up on that prior. The docs dont describe >>>> that >>>> > > well either. >>>> > >>>> > >>>> > Because we also update validation test suite, which also needs it's >>>> > number increased somewhere and we have only API_MINOR for that. >>>> > >>>> > Maxim. >>>> >>>> >>>> The validation suite must have its own version numbering scheme >>>> (separate from the API) since it will also have bugs. A suite has test >>>> cases against a specific API version (e.g. API v1.0.1), but may not be >>>> complete and may have known/unknown bugs, etc. The suite version number is >>>> bumped every time the suite is modified e.g. from v1.0.1-4 to v1.0.1-5. >>>> Basically each API version would have a matching validation suite, but we >>>> may skip some API versions and publish validation suites only for certain >>>> (good / important) API versions. E.g. a list of latest suite versions could >>>> be v1.0.1-5 (for API v1.0.1), v1.0.3-2 (for API v1.0.3), ... >>>> >>>> It's another topic if we want to combine validation suite and reference >>>> implementation (linux-generic) release cycles and version numbering ... >>>> which makes sense since it indicates on which implementation (version) the >>>> suite was tested on. >>>> >>>> >>>> -Petri >>>> >>>> _______________________________________________ >>>> lng-odp mailing list >>>> lng-odp@lists.linaro.org >>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>>> >>> >>> >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs >> >> >> >
On Tue, May 5, 2015 at 4:57 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > http://people.linaro.org/~mike.holmes/odp-api/html/release.html > > When I paste this it works for me - not sure where it is going wrong does > http://people.linaro.org/~mike.holmes/odp-api/html work for you ? - if so > look at the Release Management tab. It didn't work yesterday for me either. > > On 4 May 2015 at 15:22, Bill Fischofer <bill.fischofer@linaro.org> wrote: >> >> Mike, your last URL gives a "Not Found" result. >> >> On Mon, May 4, 2015 at 9:52 AM, Mike Holmes <mike.holmes@linaro.org> >> wrote: >>> >>> >>> >>> On 4 May 2015 at 07:31, Bill Fischofer <bill.fischofer@linaro.org> wrote: >>>> >>>> I had suggested last year that we number the APIs to reflect >>>> architectural changes but that implementations use a build number to >>>> indicate service changes. So you'd say something like "I'm running odp-dpdk >>>> v1.1 build 16" or "I'm running validation suite v1.3 build 4" to make the >>>> distinction clear. >>> >>> >>> I think the need for would be covered by odp_version_impl_str() we have >>> not been using it however. >>> It should increment for any change at all when tagged. >>> >>> I have updated the api-doc material on versioning - here is a 1st pass >>> cut rendered as html, it still needs a touch up here and there >>> >>> http://people.linaro.org/~mike.holmes/odp-api/html/release.htm >>> >>> >>>> >>>> If you want to have a single number than the last digit is the build >>>> number, but then that also seems to keep needing to be explained so it's >>>> simpler to explicitly state the build number as a separate designator. >>>> >>>> On Mon, May 4, 2015 at 4:52 AM, Savolainen, Petri (Nokia - FI/Espoo) >>>> <petri.savolainen@nokia.com> wrote: >>>>> >>>>> >>>>> >>>>> > -----Original Message----- >>>>> > From: ext Maxim Uvarov [mailto:maxim.uvarov@linaro.org] >>>>> > Sent: Thursday, April 30, 2015 4:33 PM >>>>> > To: Mike Holmes; Savolainen, Petri (Nokia - FI/Espoo) >>>>> > Cc: lng-odp@lists.linaro.org >>>>> > Subject: Re: [lng-odp] [PATCH] update version number from v1.0.3 to >>>>> > v1.0.4 >>>>> > >>>>> > On 04/30/2015 14:51, Mike Holmes wrote: >>>>> > > >>>>> > > On 30 April 2015 at 06:55, Savolainen, Petri (Nokia - FI/Espoo) >>>>> > > <petri.savolainen@nokia.com <mailto:petri.savolainen@nokia.com>> >>>>> > > wrote: >>>>> > > >>>>> > > Hi, >>>>> > > >>>>> > > This time it is appropriate to bump the ODP_VERSION_API_MINOR, >>>>> > > since "api: time: force time defines as ULL to avoid >>>>> > > computation" >>>>> > > actually changed the API signature visible to the application. >>>>> > > But >>>>> > > I question if previous increments to *API version* were >>>>> > > necessary. >>>>> > > For example, here are listed all API changes between APIs >>>>> > > v1.0.2 >>>>> > > and v1.0.3 ... >>>>> > > >>>>> > > git diff v1.0.2..v1.0.3 -- include/odp >>>>> > > >>>>> > > diff --git a/include/odp/api/version.h >>>>> > > b/include/odp/api/version.h >>>>> > > index ae1cf0d..3338559 100644 >>>>> > > --- a/include/odp/api/version.h >>>>> > > +++ b/include/odp/api/version.h >>>>> > > @@ -46,7 +46,7 @@ extern "C" { >>>>> > > * to the API. For an API with common generation and major >>>>> > > version, but with >>>>> > > * different minor numbers the two versions are backward >>>>> > compatible. >>>>> > > */ >>>>> > > -#define ODP_VERSION_API_MINOR 2 >>>>> > > +#define ODP_VERSION_API_MINOR 3 >>>>> > > >>>>> > > /** >>>>> > > * Returns ODP API version string >>>>> > > >>>>> > > >>>>> > > >>>>> > > git diff v1.0.2..v1.0.3 -- platform/linux-generic/include/odp >>>>> > > >>>>> > > >>>>> > > >>>>> > > .. absolutely nothing, but still we have another API version >>>>> > > out >>>>> > > there. ODP release/validation suite/linux-generic >>>>> > > implementation >>>>> > > version can be combined into one number, but it should be >>>>> > > different from the ODP API version number. Today the API >>>>> > > version >>>>> > > should be actually v1.0.1. >>>>> > > >>>>> > > >>>>> > > Completely agree should have been bumping ODP_VERSION_IMPL_STR - >>>>> > > not >>>>> > > sure how we did not pick up on that prior. The docs dont describe >>>>> > > that >>>>> > > well either. >>>>> > >>>>> > >>>>> > Because we also update validation test suite, which also needs it's >>>>> > number increased somewhere and we have only API_MINOR for that. >>>>> > >>>>> > Maxim. >>>>> >>>>> >>>>> The validation suite must have its own version numbering scheme >>>>> (separate from the API) since it will also have bugs. A suite has test cases >>>>> against a specific API version (e.g. API v1.0.1), but may not be complete >>>>> and may have known/unknown bugs, etc. The suite version number is bumped >>>>> every time the suite is modified e.g. from v1.0.1-4 to v1.0.1-5. Basically >>>>> each API version would have a matching validation suite, but we may skip >>>>> some API versions and publish validation suites only for certain (good / >>>>> important) API versions. E.g. a list of latest suite versions could be >>>>> v1.0.1-5 (for API v1.0.1), v1.0.3-2 (for API v1.0.3), ... >>>>> >>>>> It's another topic if we want to combine validation suite and reference >>>>> implementation (linux-generic) release cycles and version numbering ... >>>>> which makes sense since it indicates on which implementation (version) the >>>>> suite was tested on. >>>>> >>>>> >>>>> -Petri >>>>> >>>>> _______________________________________________ >>>>> lng-odp mailing list >>>>> lng-odp@lists.linaro.org >>>>> https://lists.linaro.org/mailman/listinfo/lng-odp >>>> >>>> >>> >>> >>> >>> -- >>> Mike Holmes >>> Technical Manager - Linaro Networking Group >>> Linaro.org │ Open source software for ARM SoCs >>> >>> >> > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org │ Open source software for ARM SoCs > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/debian/changelog b/debian/changelog index 2087289..c6c0ec8 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,30 @@ +opendataplane (1.0.4-1) unstable; urgency=low + + * test: + * validation: + - synchronizers: fix init of custom barrier atomic + - pktio: don't pass invalid handles + - use PRIu32 instead of %u to print uint32_t variables + - thread: add odp_thread sunnyday tests + - classification: add missing init of atomic variable + - api_test: remove odp_shm_test + * performance: + - pktio: fix check for pktio_tx + - pktio: test return value of odp_pktio_close() + - pktio: add throughput test + * example: + - ODP classifier example + * bugs: + - example: timer: clean up prescheduled events + * general: + - api: time: force time defines as ULL to avoid computation overflows on 32bits systems + - linux-generic: packet_io: init l2 and l3 cos table spinlocks + - linux-generic: pool: initialize atomics during odp_pool_init_global + - linux-generic: pool: fix initialization of odp_buffer_hdr ref_count + - doc: api_guide_lines: add guidance on ODP_DEPRECATED + + -- Maxim Uvarov <maxim.uvarov@linaro.org> Wed, 29 Apr 2015 20:21:25 +0300 + opendataplane (1.0.3-1) unstable; urgency=low * test: diff --git a/include/odp/api/version.h b/include/odp/api/version.h index 3338559..027095d 100644 --- a/include/odp/api/version.h +++ b/include/odp/api/version.h @@ -46,7 +46,7 @@ extern "C" { * to the API. For an API with common generation and major version, but with * different minor numbers the two versions are backward compatible. */ -#define ODP_VERSION_API_MINOR 3 +#define ODP_VERSION_API_MINOR 4 /** * Returns ODP API version string
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- debian/changelog | 27 +++++++++++++++++++++++++++ include/odp/api/version.h | 2 +- 2 files changed, 28 insertions(+), 1 deletion(-)