| Message ID | 1427924778-16755-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Ping On 1 April 2015 at 17:46, Mike Holmes <mike.holmes@linaro.org> wrote: > ODP has not adopted a style that can be universally applied with a tool > such as astyle. > Remove astyle leaving only the cleanup for whitespace and checkpatch > elements for checking src files before a patch is created. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > scripts/odp_check | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/scripts/odp_check b/scripts/odp_check > index 09c859b..33809dc 100755 > --- a/scripts/odp_check > +++ b/scripts/odp_check > @@ -1,8 +1,6 @@ > #!/bin/bash > # > -# This script is an indenter, white space remover, > -# formatter, and beautifier and general source file > -# clean up for the ODP project. > +# This script is a clean up for the ODP project src files. > # > # Usage > # ./scripts/opd_check <path/filename> > @@ -10,11 +8,5 @@ set -e > > DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" > > -if ! type "astyle" >/dev/null >/dev/null; then > - echo "Please install astyle from http://astyle.sourceforge.net/" > - exit -1 > -fi > - > -astyle --style=linux --indent=force-tab=8 --align-pointer=name $1 > $DIR/cleanfile $1 > $DIR/checkpatch.pl -f $1 > -- > 2.1.0 > >
Bill, I think Mike fixes renaming and it has to be ok now. Thanks, Maxim. On 04/07/15 18:21, Mike Holmes wrote: > Ping > > On 1 April 2015 at 17:46, Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> wrote: > > ODP has not adopted a style that can be universally applied with a > tool > such as astyle. > Remove astyle leaving only the cleanup for whitespace and checkpatch > elements for checking src files before a patch is created. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > --- > scripts/odp_check | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/scripts/odp_check b/scripts/odp_check > index 09c859b..33809dc 100755 > --- a/scripts/odp_check > +++ b/scripts/odp_check > @@ -1,8 +1,6 @@ > #!/bin/bash > # > -# This script is an indenter, white space remover, > -# formatter, and beautifier and general source file > -# clean up for the ODP project. > +# This script is a clean up for the ODP project src files. > # > # Usage > # ./scripts/opd_check <path/filename> > @@ -10,11 +8,5 @@ set -e > > DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" > > -if ! type "astyle" >/dev/null >/dev/null; then > - echo "Please install astyle from http://astyle.sourceforge.net/" > - exit -1 > -fi > - > -astyle --style=linux --indent=force-tab=8 --align-pointer=name $1 > $DIR/cleanfile $1 > $DIR/checkpatch.pl <http://checkpatch.pl> -f $1 > -- > 2.1.0 > > > > > -- > Mike Holmes > Technical Manager - Linaro Networking Group > Linaro.org <http://www.linaro.org/>***│ *Open source software for ARM SoCs > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp
On 04/02/15 00:46, Mike Holmes wrote: > diff --git a/scripts/odp_check b/odp_clean_and_check > similarity index 100% should be in scripts. Maxim.
yes - looks wrong, thanks - fixing now On 7 April 2015 at 12:39, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 04/02/15 00:46, Mike Holmes wrote: > >> diff --git a/scripts/odp_check b/odp_clean_and_check >> similarity index 100% >> > should be in scripts. > > Maxim. > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/scripts/odp_check b/scripts/odp_check index 09c859b..33809dc 100755 --- a/scripts/odp_check +++ b/scripts/odp_check @@ -1,8 +1,6 @@ #!/bin/bash # -# This script is an indenter, white space remover, -# formatter, and beautifier and general source file -# clean up for the ODP project. +# This script is a clean up for the ODP project src files. # # Usage # ./scripts/opd_check <path/filename> @@ -10,11 +8,5 @@ set -e DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" -if ! type "astyle" >/dev/null >/dev/null; then - echo "Please install astyle from http://astyle.sourceforge.net/" - exit -1 -fi - -astyle --style=linux --indent=force-tab=8 --align-pointer=name $1 $DIR/cleanfile $1 $DIR/checkpatch.pl -f $1
ODP has not adopted a style that can be universally applied with a tool such as astyle. Remove astyle leaving only the cleanup for whitespace and checkpatch elements for checking src files before a patch is created. Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- scripts/odp_check | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-)