diff mbox

[v3,1/2] test: debug: add unused attribute MACRO

Message ID 1426789209-13903-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 9dac6ba2ef349e4fe60bc36684dde462e5c6f464
Headers show

Commit Message

Mike Holmes March 19, 2015, 6:20 p.m. UTC
Compiler attributes should be used to signify that an unused argument is
intentionally unused

Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---
 test/test_debug.h | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Bill Fischofer March 20, 2015, 3:25 a.m. UTC | #1
On Thu, Mar 19, 2015 at 1:20 PM, Mike Holmes <mike.holmes@linaro.org> wrote:

> Compiler attributes should be used to signify that an unused argument is
> intentionally unused
>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
>

Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org>


> ---
>  test/test_debug.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/test/test_debug.h b/test/test_debug.h
> index 35e21d9..2ad743f 100644
> --- a/test/test_debug.h
> +++ b/test/test_debug.h
> @@ -81,6 +81,11 @@ do { \
>   * @}
>   */
>
> +/**
> + * Mark intentionally unused argument for functions
> + */
> +#define TEST_UNUSED     __attribute__((__unused__))
> +
>  #ifdef __cplusplus
>  }
>  #endif
> --
> 2.1.0
>
>
Maxim Uvarov March 23, 2015, 10:13 a.m. UTC | #2
Merged,
Maxim.

On 03/20/15 06:25, Bill Fischofer wrote:
>
>
> On Thu, Mar 19, 2015 at 1:20 PM, Mike Holmes <mike.holmes@linaro.org 
> <mailto:mike.holmes@linaro.org>> wrote:
>
>     Compiler attributes should be used to signify that an unused
>     argument is
>     intentionally unused
>
>     Signed-off-by: Mike Holmes <mike.holmes@linaro.org
>     <mailto:mike.holmes@linaro.org>>
>
>
> Reviewed-by: Bill Fischofer <bill.fischofer@linaro.org 
> <mailto:bill.fischofer@linaro.org>>
>
>     ---
>      test/test_debug.h | 5 +++++
>      1 file changed, 5 insertions(+)
>
>     diff --git a/test/test_debug.h b/test/test_debug.h
>     index 35e21d9..2ad743f 100644
>     --- a/test/test_debug.h
>     +++ b/test/test_debug.h
>     @@ -81,6 +81,11 @@ do { \
>       * @}
>       */
>
>     +/**
>     + * Mark intentionally unused argument for functions
>     + */
>     +#define TEST_UNUSED     __attribute__((__unused__))
>     +
>      #ifdef __cplusplus
>      }
>      #endif
>     --
>     2.1.0
>
>
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/test/test_debug.h b/test/test_debug.h
index 35e21d9..2ad743f 100644
--- a/test/test_debug.h
+++ b/test/test_debug.h
@@ -81,6 +81,11 @@  do { \
  * @}
  */
 
+/**
+ * Mark intentionally unused argument for functions
+ */
+#define TEST_UNUSED     __attribute__((__unused__))
+
 #ifdef __cplusplus
 }
 #endif