diff mbox

[4/6] linux-generic: remove header file garbage

Message ID 1423638605-6342-5-git-send-email-maxim.uvarov@linaro.org
State New
Headers show

Commit Message

Maxim Uvarov Feb. 11, 2015, 7:10 a.m. UTC 
Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
---
 platform/linux-generic/odp_impl.c | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Taras Kondratiuk Feb. 16, 2015, 11:43 a.m. UTC | #1 
On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> ---
>  platform/linux-generic/odp_impl.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
> index f0a582e..3ad7e53 100644
> --- a/platform/linux-generic/odp_impl.c
> +++ b/platform/linux-generic/odp_impl.c
> @@ -5,16 +5,6 @@
>   */
>  
>  
> -/**
> - * @file
> - *
> - * ODP Implementation information
> - */
> -
> -#ifdef __cplusplus
> -extern "C" {
> -#endif
> -

Why this isn't a part of a first patch?

>  #include <odp/version.h>
>  
>  #define  ODP_VERSION_IMPL 0
> @@ -24,7 +14,3 @@ const char *odp_version_impl_str(void)
>  {
>  	return ODP_VERSION_IMPL_STR;
>  }
> -
> -#ifdef __cplusplus
> -}
> -#endif
>
Bill Fischofer Feb. 16, 2015, 5:31 p.m. UTC | #2 
Why do we want to get rid of the C++ compatibility syntax here?

On Mon, Feb 16, 2015 at 7:43 PM, Taras Kondratiuk <
taras.kondratiuk@linaro.org> wrote:

> On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
> > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org>
> > ---
> >  platform/linux-generic/odp_impl.c | 14 --------------
> >  1 file changed, 14 deletions(-)
> >
> > diff --git a/platform/linux-generic/odp_impl.c
> b/platform/linux-generic/odp_impl.c
> > index f0a582e..3ad7e53 100644
> > --- a/platform/linux-generic/odp_impl.c
> > +++ b/platform/linux-generic/odp_impl.c
> > @@ -5,16 +5,6 @@
> >   */
> >
> >
> > -/**
> > - * @file
> > - *
> > - * ODP Implementation information
> > - */
> > -
> > -#ifdef __cplusplus
> > -extern "C" {
> > -#endif
> > -
>
> Why this isn't a part of a first patch?
>
> >  #include <odp/version.h>
> >
> >  #define  ODP_VERSION_IMPL 0
> > @@ -24,7 +14,3 @@ const char *odp_version_impl_str(void)
> >  {
> >       return ODP_VERSION_IMPL_STR;
> >  }
> > -
> > -#ifdef __cplusplus
> > -}
> > -#endif
> >
>
>
> --
> Taras Kondratiuk
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
Maxim Uvarov Feb. 16, 2015, 5:59 p.m. UTC | #3 
On 02/16/2015 08:31 PM, Bill Fischofer wrote:
> Why do we want to get rid of the C++ compatibility syntax here?

C files do not have it, it's only for .h

Maxim.

>
> On Mon, Feb 16, 2015 at 7:43 PM, Taras Kondratiuk 
> <taras.kondratiuk@linaro.org <mailto:taras.kondratiuk@linaro.org>> wrote:
>
>     On 02/11/2015 09:10 AM, Maxim Uvarov wrote:
>     > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org
>     <mailto:maxim.uvarov@linaro.org>>
>     > ---
>     >  platform/linux-generic/odp_impl.c | 14 --------------
>     >  1 file changed, 14 deletions(-)
>     >
>     > diff --git a/platform/linux-generic/odp_impl.c
>     b/platform/linux-generic/odp_impl.c
>     > index f0a582e..3ad7e53 100644
>     > --- a/platform/linux-generic/odp_impl.c
>     > +++ b/platform/linux-generic/odp_impl.c
>     > @@ -5,16 +5,6 @@
>     >   */
>     >
>     >
>     > -/**
>     > - * @file
>     > - *
>     > - * ODP Implementation information
>     > - */
>     > -
>     > -#ifdef __cplusplus
>     > -extern "C" {
>     > -#endif
>     > -
>
>     Why this isn't a part of a first patch?
>
>     >  #include <odp/version.h>
>     >
>     >  #define  ODP_VERSION_IMPL 0
>     > @@ -24,7 +14,3 @@ const char *odp_version_impl_str(void)
>     >  {
>     >       return ODP_VERSION_IMPL_STR;
>     >  }
>     > -
>     > -#ifdef __cplusplus
>     > -}
>     > -#endif
>     >
>
>
>     --
>     Taras Kondratiuk
>
>     _______________________________________________
>     lng-odp mailing list
>     lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org>
>     http://lists.linaro.org/mailman/listinfo/lng-odp
>
>
diff mbox

Patch

diff --git a/platform/linux-generic/odp_impl.c b/platform/linux-generic/odp_impl.c
index f0a582e..3ad7e53 100644
--- a/platform/linux-generic/odp_impl.c
+++ b/platform/linux-generic/odp_impl.c
@@ -5,16 +5,6 @@ 
  */
 
 
-/**
- * @file
- *
- * ODP Implementation information
- */
-
-#ifdef __cplusplus
-extern "C" {
-#endif
-
 #include <odp/version.h>
 
 #define  ODP_VERSION_IMPL 0
@@ -24,7 +14,3 @@  const char *odp_version_impl_str(void)
 {
 	return ODP_VERSION_IMPL_STR;
 }
-
-#ifdef __cplusplus
-}
-#endif