| Message ID | 1423145747-32463-1-git-send-email-taras.kondratiuk@linaro.org |
|---|---|
| State | Accepted |
| Commit | 1e6fd1a68c0fb08c112cf5717f0ff19335b1db80 |
| Headers | show |
Taras, do you see compilation error without stdlib.h? Maxim. On 02/05/2015 05:15 PM, Taras Kondratiuk wrote: > Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> > --- > test/validation/odp_init_abort.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/validation/odp_init_abort.c b/test/validation/odp_init_abort.c > index c291146..ceb82b5 100644 > --- a/test/validation/odp_init_abort.c > +++ b/test/validation/odp_init_abort.c > @@ -5,6 +5,7 @@ > */ > > #include <stdarg.h> > +#include <stdlib.h> > #include <odp.h> > #include <CUnit/Basic.h> >
On 02/08/2015 11:20 PM, Maxim Uvarov wrote:
> Taras, do you see compilation error without stdlib.h?
Sorry I've missed your reply.
Yes I see it in linux-keystone implementation.
You don't see it in linux-generic just because stdlib.h is included via
some ODP header. Tests should not rely on this.
Merged! Maxim. On 02/24/2015 05:12 PM, Taras Kondratiuk wrote: > On 02/08/2015 11:20 PM, Maxim Uvarov wrote: >> Taras, do you see compilation error without stdlib.h? > Sorry I've missed your reply. > > Yes I see it in linux-keystone implementation. > You don't see it in linux-generic just because stdlib.h is included via > some ODP header. Tests should not rely on this. >
diff --git a/test/validation/odp_init_abort.c b/test/validation/odp_init_abort.c index c291146..ceb82b5 100644 --- a/test/validation/odp_init_abort.c +++ b/test/validation/odp_init_abort.c @@ -5,6 +5,7 @@ */ #include <stdarg.h> +#include <stdlib.h> #include <odp.h> #include <CUnit/Basic.h>
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org> --- test/validation/odp_init_abort.c | 1 + 1 file changed, 1 insertion(+)