diff mbox

api: pool: move buffer allocation to buffer.h

Message ID 1423145925-32630-1-git-send-email-taras.kondratiuk@linaro.org
State New
Headers show

Commit Message

Taras Kondratiuk Feb. 5, 2015, 2:18 p.m. UTC
Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
---
 include/odp/api/buffer.h | 19 +++++++++++++++++++
 include/odp/api/pool.h   | 19 -------------------
 2 files changed, 19 insertions(+), 19 deletions(-)

Comments

Bill Fischofer Feb. 5, 2015, 2:25 p.m. UTC | #1
This change was proposed as part of 0.5 and was removed as Petri preferred
it the way it is.  Historically we couldn't move these routines with the
rest of the buffer routines because of typedef dependencies, but now that
they are factored out it really doesn't matter from a technical standpoint.


I personally think having all of the odp_buffer_xxx() APIs in buffer.h
makes more sense, but we'll have to see if there's consensus on that this
time.

On Thu, Feb 5, 2015 at 8:18 AM, Taras Kondratiuk <
taras.kondratiuk@linaro.org> wrote:

> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
> ---
>  include/odp/api/buffer.h | 19 +++++++++++++++++++
>  include/odp/api/pool.h   | 19 -------------------
>  2 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h
> index 09bddf2..4bbac1e 100644
> --- a/include/odp/api/buffer.h
> +++ b/include/odp/api/buffer.h
> @@ -105,6 +105,25 @@ int odp_buffer_is_valid(odp_buffer_t buf);
>  odp_pool_t odp_buffer_pool(odp_buffer_t buf);
>
>  /**
> + * Buffer alloc
> + *
> + * The validity of a buffer can be cheked at any time with
> odp_buffer_is_valid()
> + * @param pool      Pool handle
> + *
> + * @return Handle of allocated buffer
> + * @retval ODP_BUFFER_INVALID  Buffer could not be allocated
> + */
> +odp_buffer_t odp_buffer_alloc(odp_pool_t pool);
> +
> +/**
> + * Buffer free
> + *
> + * @param buf       Buffer handle
> + *
> + */
> +void odp_buffer_free(odp_buffer_t buf);
> +
> +/**
>   * Print buffer metadata to STDOUT
>   *
>   * @param buf      Buffer handle
> diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h
> index 14d18fb..b0b26e4 100644
> --- a/include/odp/api/pool.h
> +++ b/include/odp/api/pool.h
> @@ -195,25 +195,6 @@ void odp_pool_print(odp_pool_t pool);
>  uint64_t odp_pool_to_u64(odp_pool_t hdl);
>
>  /**
> - * Buffer alloc
> - *
> - * The validity of a buffer can be cheked at any time with
> odp_buffer_is_valid()
> - * @param pool      Pool handle
> - *
> - * @return Handle of allocated buffer
> - * @retval ODP_BUFFER_INVALID  Buffer could not be allocated
> - */
> -odp_buffer_t odp_buffer_alloc(odp_pool_t pool);
> -
> -/**
> - * Buffer free
> - *
> - * @param buf       Buffer handle
> - *
> - */
> -void odp_buffer_free(odp_buffer_t buf);
> -
> -/**
>   * @}
>   */
>
> --
> 1.9.1
>
>
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
>
diff mbox

Patch

diff --git a/include/odp/api/buffer.h b/include/odp/api/buffer.h
index 09bddf2..4bbac1e 100644
--- a/include/odp/api/buffer.h
+++ b/include/odp/api/buffer.h
@@ -105,6 +105,25 @@  int odp_buffer_is_valid(odp_buffer_t buf);
 odp_pool_t odp_buffer_pool(odp_buffer_t buf);
 
 /**
+ * Buffer alloc
+ *
+ * The validity of a buffer can be cheked at any time with odp_buffer_is_valid()
+ * @param pool      Pool handle
+ *
+ * @return Handle of allocated buffer
+ * @retval ODP_BUFFER_INVALID  Buffer could not be allocated
+ */
+odp_buffer_t odp_buffer_alloc(odp_pool_t pool);
+
+/**
+ * Buffer free
+ *
+ * @param buf       Buffer handle
+ *
+ */
+void odp_buffer_free(odp_buffer_t buf);
+
+/**
  * Print buffer metadata to STDOUT
  *
  * @param buf      Buffer handle
diff --git a/include/odp/api/pool.h b/include/odp/api/pool.h
index 14d18fb..b0b26e4 100644
--- a/include/odp/api/pool.h
+++ b/include/odp/api/pool.h
@@ -195,25 +195,6 @@  void odp_pool_print(odp_pool_t pool);
 uint64_t odp_pool_to_u64(odp_pool_t hdl);
 
 /**
- * Buffer alloc
- *
- * The validity of a buffer can be cheked at any time with odp_buffer_is_valid()
- * @param pool      Pool handle
- *
- * @return Handle of allocated buffer
- * @retval ODP_BUFFER_INVALID  Buffer could not be allocated
- */
-odp_buffer_t odp_buffer_alloc(odp_pool_t pool);
-
-/**
- * Buffer free
- *
- * @param buf       Buffer handle
- *
- */
-void odp_buffer_free(odp_buffer_t buf);
-
-/**
  * @}
  */