| Message ID | 1421441795-27090-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Accepted |
| Commit | b26c0fb105c99a17735e943dadca4bad9bbe26bf |
| Headers | show |
On 16 January 2015 at 15:56, Anders Roxell <anders.roxell@linaro.org> wrote: > AC_FUNC_MALLOC depends on the paths and gets confused if its not done > first. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> This fixes the issues with Geoffrey's patch for me, it was not his patch that caused the issue, it just exposed it. > --- > configure.ac | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 440cc63..39610ee 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -25,6 +25,11 @@ LT_INIT([]) > AC_SUBST([LIBTOOL_DEPS]) > AM_PROG_LIBTOOL > > +# Checks for library functions. > +AC_FUNC_MALLOC > +AC_FUNC_MMAP > +AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize > gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) > + > # Checks for header files. > AC_HEADER_RESOLV > AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h limits.h netdb.h > netinet/in.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h sys/socket.h > sys/time.h unistd.h]) > @@ -186,11 +191,6 @@ ODP_CFLAGS="$ODP_CFLAGS -Wformat-security -Wundef > -Wwrite-strings" > ########################################################################## > AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" > > -# Checks for library functions. > -AC_FUNC_MALLOC > -AC_FUNC_MMAP > -AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize > gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) > - > AC_CONFIG_FILES([Makefile > doc/Makefile > example/Makefile > -- > 2.1.4 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> Good to know that for those of use that didn't see the failure things still work after applying this patch as well. Any clue as to why some were having problems while others were not? On Fri, Jan 16, 2015 at 3:00 PM, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 16 January 2015 at 15:56, Anders Roxell <anders.roxell@linaro.org> > wrote: > >> AC_FUNC_MALLOC depends on the paths and gets confused if its not done >> first. >> >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> > > Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> > > This fixes the issues with Geoffrey's patch for me, it was not his patch > that caused the issue, it just exposed it. > > >> --- >> configure.ac | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index 440cc63..39610ee 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -25,6 +25,11 @@ LT_INIT([]) >> AC_SUBST([LIBTOOL_DEPS]) >> AM_PROG_LIBTOOL >> >> +# Checks for library functions. >> +AC_FUNC_MALLOC >> +AC_FUNC_MMAP >> +AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize >> gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) >> + >> # Checks for header files. >> AC_HEADER_RESOLV >> AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h limits.h netdb.h >> netinet/in.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h sys/socket.h >> sys/time.h unistd.h]) >> @@ -186,11 +191,6 @@ ODP_CFLAGS="$ODP_CFLAGS -Wformat-security -Wundef >> -Wwrite-strings" >> >> ########################################################################## >> AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" >> >> -# Checks for library functions. >> -AC_FUNC_MALLOC >> -AC_FUNC_MMAP >> -AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize >> gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) >> - >> AC_CONFIG_FILES([Makefile >> doc/Makefile >> example/Makefile >> -- >> 2.1.4 >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp > >
On 16 January 2015 at 18:20, Bill Fischofer <bill.fischofer@linaro.org> wrote: > Reviewed-and-tested-by: Bill Fischofer <bill.fischofer@linaro.org> > > Good to know that for those of use that didn't see the failure things > still work after applying this patch as well. > > Any clue as to why some were having problems while others were not? > building with cunit or not in my case. > > On Fri, Jan 16, 2015 at 3:00 PM, Mike Holmes <mike.holmes@linaro.org> > wrote: > >> >> >> On 16 January 2015 at 15:56, Anders Roxell <anders.roxell@linaro.org> >> wrote: >> >>> AC_FUNC_MALLOC depends on the paths and gets confused if its not done >>> first. >>> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>> >> >> Reviewed-and-tested-by: Mike Holmes <mike.holmes@linaro.org> >> >> This fixes the issues with Geoffrey's patch for me, it was not his patch >> that caused the issue, it just exposed it. >> >> >>> --- >>> configure.ac | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index 440cc63..39610ee 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -25,6 +25,11 @@ LT_INIT([]) >>> AC_SUBST([LIBTOOL_DEPS]) >>> AM_PROG_LIBTOOL >>> >>> +# Checks for library functions. >>> +AC_FUNC_MALLOC >>> +AC_FUNC_MMAP >>> +AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize >>> gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) >>> + >>> # Checks for header files. >>> AC_HEADER_RESOLV >>> AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h limits.h netdb.h >>> netinet/in.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h sys/socket.h >>> sys/time.h unistd.h]) >>> @@ -186,11 +191,6 @@ ODP_CFLAGS="$ODP_CFLAGS -Wformat-security -Wundef >>> -Wwrite-strings" >>> >>> ########################################################################## >>> AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" >>> >>> -# Checks for library functions. >>> -AC_FUNC_MALLOC >>> -AC_FUNC_MMAP >>> -AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize >>> gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) >>> - >>> AC_CONFIG_FILES([Makefile >>> doc/Makefile >>> example/Makefile >>> -- >>> 2.1.4 >>> >>> >>> _______________________________________________ >>> lng-odp mailing list >>> lng-odp@lists.linaro.org >>> http://lists.linaro.org/mailman/listinfo/lng-odp >>> >> >> >> >> -- >> *Mike Holmes* >> Linaro Sr Technical Manager >> LNG - ODP >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> >> >
diff --git a/configure.ac b/configure.ac index 440cc63..39610ee 100644 --- a/configure.ac +++ b/configure.ac @@ -25,6 +25,11 @@ LT_INIT([]) AC_SUBST([LIBTOOL_DEPS]) AM_PROG_LIBTOOL +# Checks for library functions. +AC_FUNC_MALLOC +AC_FUNC_MMAP +AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) + # Checks for header files. AC_HEADER_RESOLV AC_CHECK_HEADERS([arpa/inet.h fcntl.h inttypes.h limits.h netdb.h netinet/in.h stddef.h stdint.h stdlib.h string.h sys/ioctl.h sys/socket.h sys/time.h unistd.h]) @@ -186,11 +191,6 @@ ODP_CFLAGS="$ODP_CFLAGS -Wformat-security -Wundef -Wwrite-strings" ########################################################################## AM_CFLAGS="$AM_CFLAGS $ODP_CFLAGS" -# Checks for library functions. -AC_FUNC_MALLOC -AC_FUNC_MMAP -AC_CHECK_FUNCS([bzero clock_gettime gethostbyname getpagesize gettimeofday memset munmap socket strchr strerror strrchr strstr strtoull]) - AC_CONFIG_FILES([Makefile doc/Makefile example/Makefile
AC_FUNC_MALLOC depends on the paths and gets confused if its not done first. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- configure.ac | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)