| Message ID | 1419875465-2797-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Should we use here tabs instead of whitespaces? Maxim. On 12/29/2014 08:51 PM, Mike Holmes wrote: > The help text is not formatted into columns correctly, fix it. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index f0ce7e0..0c4ef3e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -65,7 +65,7 @@ AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) > # Enable/disable Unit tests > ########################################################################## > AC_ARG_ENABLE([cunit], > - [ --enable-cunit Enable/disable cunit], > + [ --enable-cunit Enable/disable cunit], > [if test x$enableval = xyes; then > cunit_support=yes > fi]) > @@ -86,7 +86,7 @@ AC_HELP_STRING([--with-cunit-path=DIR Path to Cunit libs and headers], > ########################################################################## > ODP_DEBUG_PRINT=1 > AC_ARG_ENABLE([debug-print], > - [ --enable-debug-print Enable/disable debug print], > + [ --enable-debug-print Enable/disable debug print], > [if ! test "x$enableval" = "xyes"; then > ODP_DEBUG_PRINT=0 > fi])
On 30 December 2014 at 04:40, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Should we use here tabs instead of whitespaces? > I will look to see if they are all consistent > > Maxim. > > > On 12/29/2014 08:51 PM, Mike Holmes wrote: > >> The help text is not formatted into columns correctly, fix it. >> >> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >> --- >> configure.ac | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/configure.ac b/configure.ac >> index f0ce7e0..0c4ef3e 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -65,7 +65,7 @@ AM_CONDITIONAL([SDK_INSTALL_PATH_], [test >> "x${SDK_INSTALL_PATH_}" = "x1"]) >> # Enable/disable Unit tests >> ############################################################ >> ############## >> AC_ARG_ENABLE([cunit], >> - [ --enable-cunit Enable/disable cunit], >> + [ --enable-cunit Enable/disable cunit], >> [if test x$enableval = xyes; then >> cunit_support=yes >> fi]) >> @@ -86,7 +86,7 @@ AC_HELP_STRING([--with-cunit-path=DIR Path to Cunit >> libs and headers], >> ############################################################ >> ############## >> ODP_DEBUG_PRINT=1 >> AC_ARG_ENABLE([debug-print], >> - [ --enable-debug-print Enable/disable debug print], >> + [ --enable-debug-print Enable/disable debug print], >> [if ! test "x$enableval" = "xyes"; then >> ODP_DEBUG_PRINT=0 >> fi]) >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
The changes are consistent in the file, I converted them to tabs but I still have to add spaces to get the correct alignment, so my feeling is that whitespace is the best way to get the output aligned. On 30 December 2014 at 07:03, Mike Holmes <mike.holmes@linaro.org> wrote: > > > On 30 December 2014 at 04:40, Maxim Uvarov <maxim.uvarov@linaro.org> > wrote: > >> Should we use here tabs instead of whitespaces? >> > > I will look to see if they are all consistent > > >> >> Maxim. >> >> >> On 12/29/2014 08:51 PM, Mike Holmes wrote: >> >>> The help text is not formatted into columns correctly, fix it. >>> >>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org> >>> --- >>> configure.ac | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/configure.ac b/configure.ac >>> index f0ce7e0..0c4ef3e 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -65,7 +65,7 @@ AM_CONDITIONAL([SDK_INSTALL_PATH_], [test >>> "x${SDK_INSTALL_PATH_}" = "x1"]) >>> # Enable/disable Unit tests >>> ############################################################ >>> ############## >>> AC_ARG_ENABLE([cunit], >>> - [ --enable-cunit Enable/disable cunit], >>> + [ --enable-cunit Enable/disable cunit], >>> [if test x$enableval = xyes; then >>> cunit_support=yes >>> fi]) >>> @@ -86,7 +86,7 @@ AC_HELP_STRING([--with-cunit-path=DIR Path to Cunit >>> libs and headers], >>> ############################################################ >>> ############## >>> ODP_DEBUG_PRINT=1 >>> AC_ARG_ENABLE([debug-print], >>> - [ --enable-debug-print Enable/disable debug print], >>> + [ --enable-debug-print Enable/disable debug print], >>> [if ! test "x$enableval" = "xyes"; then >>> ODP_DEBUG_PRINT=0 >>> fi]) >>> >> >> >> _______________________________________________ >> lng-odp mailing list >> lng-odp@lists.linaro.org >> http://lists.linaro.org/mailman/listinfo/lng-odp >> > > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP >
On 12/30/2014 03:56 PM, Mike Holmes wrote: > The changes are consistent in the file, I converted them to tabs but I > still have to add spaces to get the correct alignment, so my feeling > is that whitespace is the best way to get the output aligned. Ok. Reviewed-by: Maxim Uvarov <maxim.uvarov@linaro.org> > > On 30 December 2014 at 07:03, Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> wrote: > > > > On 30 December 2014 at 04:40, Maxim Uvarov > <maxim.uvarov@linaro.org <mailto:maxim.uvarov@linaro.org>> wrote: > > Should we use here tabs instead of whitespaces? > > > I will look to see if they are all consistent > > > Maxim. > > > On 12/29/2014 08:51 PM, Mike Holmes wrote: > > The help text is not formatted into columns correctly, fix it. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org > <mailto:mike.holmes@linaro.org>> > --- > configure.ac <http://configure.ac> | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure.ac <http://configure.ac> > b/configure.ac <http://configure.ac> > index f0ce7e0..0c4ef3e 100644 > --- a/configure.ac <http://configure.ac> > +++ b/configure.ac <http://configure.ac> > @@ -65,7 +65,7 @@ AM_CONDITIONAL([SDK_INSTALL_PATH_], > [test "x${SDK_INSTALL_PATH_}" = "x1"]) > # Enable/disable Unit tests > > ########################################################################## > AC_ARG_ENABLE([cunit], > - [ --enable-cunit Enable/disable cunit], > + [ --enable-cunit Enable/disable cunit], > [if test x$enableval = xyes; then > cunit_support=yes > fi]) > @@ -86,7 +86,7 @@ AC_HELP_STRING([--with-cunit-path=DIR > Path to Cunit libs and headers], > > ########################################################################## > ODP_DEBUG_PRINT=1 > AC_ARG_ENABLE([debug-print], > - [ --enable-debug-print Enable/disable debug print], > + [ --enable-debug-print Enable/disable debug print], > [if ! test "x$enableval" = "xyes"; then > ODP_DEBUG_PRINT=0 > fi]) > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > http://lists.linaro.org/mailman/listinfo/lng-odp > > > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP > > > > > -- > *Mike Holmes* > Linaro Sr Technical Manager > LNG - ODP
diff --git a/configure.ac b/configure.ac index f0ce7e0..0c4ef3e 100644 --- a/configure.ac +++ b/configure.ac @@ -65,7 +65,7 @@ AM_CONDITIONAL([SDK_INSTALL_PATH_], [test "x${SDK_INSTALL_PATH_}" = "x1"]) # Enable/disable Unit tests ########################################################################## AC_ARG_ENABLE([cunit], - [ --enable-cunit Enable/disable cunit], + [ --enable-cunit Enable/disable cunit], [if test x$enableval = xyes; then cunit_support=yes fi]) @@ -86,7 +86,7 @@ AC_HELP_STRING([--with-cunit-path=DIR Path to Cunit libs and headers], ########################################################################## ODP_DEBUG_PRINT=1 AC_ARG_ENABLE([debug-print], - [ --enable-debug-print Enable/disable debug print], + [ --enable-debug-print Enable/disable debug print], [if ! test "x$enableval" = "xyes"; then ODP_DEBUG_PRINT=0 fi])
The help text is not formatted into columns correctly, fix it. Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)