diff mbox

[v2] odp_ipsec: fix odp_crypto_get_operation_compl_status arg order

Message ID 1418231532-42198-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 8f3494ce0f883bd3488315800cfdac8b18445ca4
Headers show

Commit Message

Mike Holmes Dec. 10, 2014, 5:12 p.m. UTC
This fixes https://bugs.linaro.org/show_bug.cgi?id=714

Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---

This extends a prvious patch from Alex to cover all the cases. With this patch
Coverity no longer produces warnings.

 example/ipsec/odp_ipsec.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Maxim Uvarov Dec. 11, 2014, 9:54 a.m. UTC | #1
Merged,

Maxim.

On 12/10/2014 08:12 PM, Mike Holmes wrote:
> This fixes https://bugs.linaro.org/show_bug.cgi?id=714
>
> Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org>
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> ---
>
> This extends a prvious patch from Alex to cover all the cases. With this patch
> Coverity no longer produces warnings.
>
>   example/ipsec/odp_ipsec.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c
> index 76d27c5..dec39e8 100644
> --- a/example/ipsec/odp_ipsec.c
> +++ b/example/ipsec/odp_ipsec.c
> @@ -772,7 +772,7 @@ pkt_disposition_e do_ipsec_in_finish(odp_packet_t pkt,
>   
>   	/* Check crypto result */
>   	event = odp_packet_to_buffer(pkt);
> -	odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc);
> +	odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc);
>   	if (!is_crypto_compl_status_ok(&cipher_rc))
>   		return PKT_DROP;
>   	if (!is_crypto_compl_status_ok(&auth_rc))
> @@ -1004,7 +1004,7 @@ pkt_disposition_e do_ipsec_out_finish(odp_packet_t pkt,
>   
>   	/* Check crypto result */
>   	event = odp_packet_to_buffer(pkt);
> -	odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc);
> +	odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc);
>   	if (!is_crypto_compl_status_ok(&cipher_rc))
>   		return PKT_DROP;
>   	if (!is_crypto_compl_status_ok(&auth_rc))
diff mbox

Patch

diff --git a/example/ipsec/odp_ipsec.c b/example/ipsec/odp_ipsec.c
index 76d27c5..dec39e8 100644
--- a/example/ipsec/odp_ipsec.c
+++ b/example/ipsec/odp_ipsec.c
@@ -772,7 +772,7 @@  pkt_disposition_e do_ipsec_in_finish(odp_packet_t pkt,
 
 	/* Check crypto result */
 	event = odp_packet_to_buffer(pkt);
-	odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc);
+	odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc);
 	if (!is_crypto_compl_status_ok(&cipher_rc))
 		return PKT_DROP;
 	if (!is_crypto_compl_status_ok(&auth_rc))
@@ -1004,7 +1004,7 @@  pkt_disposition_e do_ipsec_out_finish(odp_packet_t pkt,
 
 	/* Check crypto result */
 	event = odp_packet_to_buffer(pkt);
-	odp_crypto_get_operation_compl_status(event, &cipher_rc, &auth_rc);
+	odp_crypto_get_operation_compl_status(event, &auth_rc, &cipher_rc);
 	if (!is_crypto_compl_status_ok(&cipher_rc))
 		return PKT_DROP;
 	if (!is_crypto_compl_status_ok(&auth_rc))