| Message ID | 1416932669-2053-1-git-send-email-maxim.uvarov@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 25 November 2014 at 18:24, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Define special name for loop back interface. That interface > can be used mostly for testing. Each implementation can interpret > that loop0 to any other device. > [Alex] A few words about what is expected from this interface in term of functionality would be beneficial for people who did not participate to the discussion. I think the name is not the best one - in Linux loop0 is a well-known block device. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > platform/linux-generic/include/api/odp_packet_io.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/api/odp_packet_io.h > b/platform/linux-generic/include/api/odp_packet_io.h > index 667395c..c388c41 100644 > --- a/platform/linux-generic/include/api/odp_packet_io.h > +++ b/platform/linux-generic/include/api/odp_packet_io.h > @@ -33,7 +33,8 @@ extern "C" { > * Open an ODP packet IO instance > * > * @param dev Packet IO device > - * @param pool Pool to use for packet IO > + * loop0 is specially reserved name for loop back interface. > +* @param pool Pool to use for packet IO > * > * @return ODP packet IO handle or ODP_PKTIO_INVALID on error > */ > -- > 1.8.5.1.163.gd7aced9 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 25 November 2014 21:54, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > Define special name for loop back interface. That interface > can be used mostly for testing. Each implementation can interpret > that loop0 to any other device. > > Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> > --- > platform/linux-generic/include/api/odp_packet_io.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/platform/linux-generic/include/api/odp_packet_io.h > b/platform/linux-generic/include/api/odp_packet_io.h > index 667395c..c388c41 100644 > --- a/platform/linux-generic/include/api/odp_packet_io.h > +++ b/platform/linux-generic/include/api/odp_packet_io.h > @@ -33,7 +33,8 @@ extern "C" { > * Open an ODP packet IO instance > * > * @param dev Packet IO device > - * @param pool Pool to use for packet IO > + * loop0 is specially reserved name for loop back interface. > I believe we need to add "loop0" description as @note Also we would need more detailed description about the expected behavior as Alex pointed out. > +* @param pool Pool to use for packet IO > * > * @return ODP packet IO handle or ODP_PKTIO_INVALID on error > */ > -- > 1.8.5.1.163.gd7aced9 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/platform/linux-generic/include/api/odp_packet_io.h b/platform/linux-generic/include/api/odp_packet_io.h index 667395c..c388c41 100644 --- a/platform/linux-generic/include/api/odp_packet_io.h +++ b/platform/linux-generic/include/api/odp_packet_io.h @@ -33,7 +33,8 @@ extern "C" { * Open an ODP packet IO instance * * @param dev Packet IO device - * @param pool Pool to use for packet IO + * loop0 is specially reserved name for loop back interface. +* @param pool Pool to use for packet IO * * @return ODP packet IO handle or ODP_PKTIO_INVALID on error */
Define special name for loop back interface. That interface can be used mostly for testing. Each implementation can interpret that loop0 to any other device. Signed-off-by: Maxim Uvarov <maxim.uvarov@linaro.org> --- platform/linux-generic/include/api/odp_packet_io.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)