| Message ID | 1416849522-18047-1-git-send-email-mike.holmes@linaro.org |
|---|---|
| State | Accepted |
| Commit | aa0cd5993b5452275bd1398cadf57a2b1e206cf3 |
| Headers | show |
Merged, Maxim. On 11/24/2014 08:18 PM, Mike Holmes wrote: > For the 1.0 release there are no platforms using the async API. > With no way to test these APIs they should be removed until needed. > > Signed-off-by: Mike Holmes <mike.holmes@linaro.org> > --- > platform/linux-generic/include/api/odp_crypto.h | 44 ------------------------- > platform/linux-generic/odp_crypto.c | 32 ------------------ > 2 files changed, 76 deletions(-) > > diff --git a/platform/linux-generic/include/api/odp_crypto.h b/platform/linux-generic/include/api/odp_crypto.h > index 4741bcb..337e7cf 100644 > --- a/platform/linux-generic/include/api/odp_crypto.h > +++ b/platform/linux-generic/include/api/odp_crypto.h > @@ -225,50 +225,6 @@ odp_crypto_session_create(odp_crypto_session_params_t *params, > odp_crypto_session_t *session, > enum odp_crypto_ses_create_err *status); > > -/** > - * Crypto session creation (asynchronous) > - * > - * Initiate crypto session creation. Results are delivered using > - * the completion event via the completion queue. > - * > - * @param params Session parameters > - * @param completion_event Event by which the session creation results are > - * delivered. > - * @param completion_queue Queue by which the completion event will be > - * delivered. > - * > - * @return 0 if successful else -1 > - * > - */ > -int > -odp_crypto_session_create_async(odp_crypto_session_params_t *params, > - odp_buffer_t completion_event, > - odp_queue_t completion_queue); > - > - > -/** > - * Crypto session creation completion status > - * > - * Accessor function for obtaining creation status from the completion event. > - * > - * @param completion_event Event containing operation results > - * @param status Pointer to store creation return code > - */ > -void > -odp_crypto_get_ses_create_compl_status(odp_buffer_t completion_event, > - enum odp_crypto_ses_create_err *status); > - > -/** > - * Crypto session creation completion return value > - * > - * Accessor function for obtaining handle for newly created session. > - * > - * @param completion_event Event containing operation results > - * @param session Pointer to store session handle > - */ > -void > -odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, > - odp_crypto_session_t *session); > > /** > * Crypto per packet operation > diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c > index 9ca2251..d3cdec7 100644 > --- a/platform/linux-generic/odp_crypto.c > +++ b/platform/linux-generic/odp_crypto.c > @@ -334,19 +334,6 @@ odp_crypto_session_create(odp_crypto_session_params_t *params, > return 0; > } > > -int > -odp_crypto_session_create_async(odp_crypto_session_params_t *params, > - odp_buffer_t completion_event, > - odp_queue_t completion_queue) > -{ > - odp_crypto_generic_session_result_t *result; > - > - result = odp_buffer_addr(completion_event); > - if (odp_crypto_session_create(params, &result->session, &result->rc)) > - return -1; > - odp_queue_enq(completion_queue, completion_event); > - return 0; > -} > > int > odp_crypto_operation(odp_crypto_op_params_t *params, > @@ -451,25 +438,6 @@ odp_crypto_get_operation_compl_status(odp_buffer_t completion_event, > memcpy(cipher, &result->cipher, sizeof(*cipher)); > } > > -void > -odp_crypto_get_ses_create_compl_status(odp_buffer_t completion_event, > - enum odp_crypto_ses_create_err *status) > -{ > - odp_crypto_generic_session_result_t *result; > - > - result = odp_buffer_addr(completion_event); > - *status = result->rc; > -} > - > -void > -odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, > - odp_crypto_session_t *session) > -{ > - odp_crypto_generic_session_result_t *result; > - > - result = odp_buffer_addr(completion_event); > - *session = result->session; > -} > > void > odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event ODP_UNUSED,
diff --git a/platform/linux-generic/include/api/odp_crypto.h b/platform/linux-generic/include/api/odp_crypto.h index 4741bcb..337e7cf 100644 --- a/platform/linux-generic/include/api/odp_crypto.h +++ b/platform/linux-generic/include/api/odp_crypto.h @@ -225,50 +225,6 @@ odp_crypto_session_create(odp_crypto_session_params_t *params, odp_crypto_session_t *session, enum odp_crypto_ses_create_err *status); -/** - * Crypto session creation (asynchronous) - * - * Initiate crypto session creation. Results are delivered using - * the completion event via the completion queue. - * - * @param params Session parameters - * @param completion_event Event by which the session creation results are - * delivered. - * @param completion_queue Queue by which the completion event will be - * delivered. - * - * @return 0 if successful else -1 - * - */ -int -odp_crypto_session_create_async(odp_crypto_session_params_t *params, - odp_buffer_t completion_event, - odp_queue_t completion_queue); - - -/** - * Crypto session creation completion status - * - * Accessor function for obtaining creation status from the completion event. - * - * @param completion_event Event containing operation results - * @param status Pointer to store creation return code - */ -void -odp_crypto_get_ses_create_compl_status(odp_buffer_t completion_event, - enum odp_crypto_ses_create_err *status); - -/** - * Crypto session creation completion return value - * - * Accessor function for obtaining handle for newly created session. - * - * @param completion_event Event containing operation results - * @param session Pointer to store session handle - */ -void -odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, - odp_crypto_session_t *session); /** * Crypto per packet operation diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 9ca2251..d3cdec7 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -334,19 +334,6 @@ odp_crypto_session_create(odp_crypto_session_params_t *params, return 0; } -int -odp_crypto_session_create_async(odp_crypto_session_params_t *params, - odp_buffer_t completion_event, - odp_queue_t completion_queue) -{ - odp_crypto_generic_session_result_t *result; - - result = odp_buffer_addr(completion_event); - if (odp_crypto_session_create(params, &result->session, &result->rc)) - return -1; - odp_queue_enq(completion_queue, completion_event); - return 0; -} int odp_crypto_operation(odp_crypto_op_params_t *params, @@ -451,25 +438,6 @@ odp_crypto_get_operation_compl_status(odp_buffer_t completion_event, memcpy(cipher, &result->cipher, sizeof(*cipher)); } -void -odp_crypto_get_ses_create_compl_status(odp_buffer_t completion_event, - enum odp_crypto_ses_create_err *status) -{ - odp_crypto_generic_session_result_t *result; - - result = odp_buffer_addr(completion_event); - *status = result->rc; -} - -void -odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, - odp_crypto_session_t *session) -{ - odp_crypto_generic_session_result_t *result; - - result = odp_buffer_addr(completion_event); - *session = result->session; -} void odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event ODP_UNUSED,
For the 1.0 release there are no platforms using the async API. With no way to test these APIs they should be removed until needed. Signed-off-by: Mike Holmes <mike.holmes@linaro.org> --- platform/linux-generic/include/api/odp_crypto.h | 44 ------------------------- platform/linux-generic/odp_crypto.c | 32 ------------------ 2 files changed, 76 deletions(-)