| Message ID | 1415653630-16999-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Accepted |
| Commit | bac953c3aa39bfaba2d28bda2e9e1c8349bdaee2 |
| Headers | show |
On 10 November 2014 16:07, Anders Roxell <anders.roxell@linaro.org> wrote: > Synchronise the file name with the test suite name. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Reviewed-and-Tested-by: Mike Holmes <mike.holmes@linaro.org> > --- > test/cunit/Makefile.am | 2 +- > test/cunit/{odp_init_test.c => odp_init.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename test/cunit/{odp_init_test.c => odp_init.c} (94%) > > diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am > index 927a5a5..4014bed 100644 > --- a/test/cunit/Makefile.am > +++ b/test/cunit/Makefile.am > @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init > odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit > endif > > -dist_odp_init_SOURCES = odp_init_test.c > +dist_odp_init_SOURCES = odp_init.c > diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c > similarity index 94% > rename from test/cunit/odp_init_test.c > rename to test/cunit/odp_init.c > index a612109..88e6235 100644 > --- a/test/cunit/odp_init_test.c > +++ b/test/cunit/odp_init.c > @@ -38,7 +38,7 @@ int main(void) > if (CUE_SUCCESS != CU_initialize_registry()) > return CU_get_error(); > /* add a suite to the registry */ > - ptr_suite = CU_add_suite("odp intalization", init, finalise); > + ptr_suite = CU_add_suite(__FILE__, init, finalise); > if (NULL == ptr_suite) { > CU_cleanup_registry(); > return CU_get_error(); > -- > 2.1.0 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 11/11/2014 12:07 AM, Anders Roxell wrote: > Synchronise the file name with the test suite name. why is that needed? Maxim. > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > test/cunit/Makefile.am | 2 +- > test/cunit/{odp_init_test.c => odp_init.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename test/cunit/{odp_init_test.c => odp_init.c} (94%) > > diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am > index 927a5a5..4014bed 100644 > --- a/test/cunit/Makefile.am > +++ b/test/cunit/Makefile.am > @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init > odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit > endif > > -dist_odp_init_SOURCES = odp_init_test.c > +dist_odp_init_SOURCES = odp_init.c > diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c > similarity index 94% > rename from test/cunit/odp_init_test.c > rename to test/cunit/odp_init.c > index a612109..88e6235 100644 > --- a/test/cunit/odp_init_test.c > +++ b/test/cunit/odp_init.c > @@ -38,7 +38,7 @@ int main(void) > if (CUE_SUCCESS != CU_initialize_registry()) > return CU_get_error(); > /* add a suite to the registry */ > - ptr_suite = CU_add_suite("odp intalization", init, finalise); > + ptr_suite = CU_add_suite(__FILE__, init, finalise); > if (NULL == ptr_suite) { > CU_cleanup_registry(); > return CU_get_error();
I think it is redundant, we know it is a test because it is in the test directory and so it conveys no value to add "test" to the name On 10 November 2014 17:07, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 11/11/2014 12:07 AM, Anders Roxell wrote: > >> Synchronise the file name with the test suite name. >> > > why is that needed? > > Maxim. > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> test/cunit/Makefile.am | 2 +- >> test/cunit/{odp_init_test.c => odp_init.c} | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> rename test/cunit/{odp_init_test.c => odp_init.c} (94%) >> >> diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am >> index 927a5a5..4014bed 100644 >> --- a/test/cunit/Makefile.am >> +++ b/test/cunit/Makefile.am >> @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init >> odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit >> endif >> -dist_odp_init_SOURCES = odp_init_test.c >> +dist_odp_init_SOURCES = odp_init.c >> diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c >> similarity index 94% >> rename from test/cunit/odp_init_test.c >> rename to test/cunit/odp_init.c >> index a612109..88e6235 100644 >> --- a/test/cunit/odp_init_test.c >> +++ b/test/cunit/odp_init.c >> @@ -38,7 +38,7 @@ int main(void) >> if (CUE_SUCCESS != CU_initialize_registry()) >> return CU_get_error(); >> /* add a suite to the registry */ >> - ptr_suite = CU_add_suite("odp intalization", init, finalise); >> + ptr_suite = CU_add_suite(__FILE__, init, finalise); >> if (NULL == ptr_suite) { >> CU_cleanup_registry(); >> return CU_get_error(); >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
On 10 November 2014 23:07, Maxim Uvarov <maxim.uvarov@linaro.org> wrote: > On 11/11/2014 12:07 AM, Anders Roxell wrote: > >> Synchronise the file name with the test suite name. >> > > why is that needed? the file is located in the test directory so that is more than enough I think. Cheers, Anders > > > Maxim. > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> test/cunit/Makefile.am | 2 +- >> test/cunit/{odp_init_test.c => odp_init.c} | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> rename test/cunit/{odp_init_test.c => odp_init.c} (94%) >> >> diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am >> index 927a5a5..4014bed 100644 >> --- a/test/cunit/Makefile.am >> +++ b/test/cunit/Makefile.am >> @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init >> odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit >> endif >> -dist_odp_init_SOURCES = odp_init_test.c >> +dist_odp_init_SOURCES = odp_init.c >> diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c >> similarity index 94% >> rename from test/cunit/odp_init_test.c >> rename to test/cunit/odp_init.c >> index a612109..88e6235 100644 >> --- a/test/cunit/odp_init_test.c >> +++ b/test/cunit/odp_init.c >> @@ -38,7 +38,7 @@ int main(void) >> if (CUE_SUCCESS != CU_initialize_registry()) >> return CU_get_error(); >> /* add a suite to the registry */ >> - ptr_suite = CU_add_suite("odp intalization", init, finalise); >> + ptr_suite = CU_add_suite(__FILE__, init, finalise); >> if (NULL == ptr_suite) { >> CU_cleanup_registry(); >> return CU_get_error(); >> > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
Ok, merged this patch. Maxim. On 11/11/2014 01:24 AM, Anders Roxell wrote: > > > On 10 November 2014 23:07, Maxim Uvarov <maxim.uvarov@linaro.org > <mailto:maxim.uvarov@linaro.org>> wrote: > > On 11/11/2014 12:07 AM, Anders Roxell wrote: > > Synchronise the file name with the test suite name. > > > why is that needed? > > > the file is located in the test directory so that is more than enough > I think. > > Cheers, > Anders > > > > Maxim. > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org > <mailto:anders.roxell@linaro.org>> > --- > test/cunit/Makefile.am | 2 +- > test/cunit/{odp_init_test.c => odp_init.c} | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > rename test/cunit/{odp_init_test.c => odp_init.c} (94%) > > diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am > index 927a5a5..4014bed 100644 > --- a/test/cunit/Makefile.am > +++ b/test/cunit/Makefile.am > @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init > odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit > endif > -dist_odp_init_SOURCES = odp_init_test.c > +dist_odp_init_SOURCES = odp_init.c > diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c > similarity index 94% > rename from test/cunit/odp_init_test.c > rename to test/cunit/odp_init.c > index a612109..88e6235 100644 > --- a/test/cunit/odp_init_test.c > +++ b/test/cunit/odp_init.c > @@ -38,7 +38,7 @@ int main(void) > if (CUE_SUCCESS != CU_initialize_registry()) > return CU_get_error(); > /* add a suite to the registry */ > - ptr_suite = CU_add_suite("odp intalization", init, > finalise); > + ptr_suite = CU_add_suite(__FILE__, init, finalise); > if (NULL == ptr_suite) { > CU_cleanup_registry(); > return CU_get_error(); > > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org <mailto:lng-odp@lists.linaro.org> > http://lists.linaro.org/mailman/listinfo/lng-odp > >
diff --git a/test/cunit/Makefile.am b/test/cunit/Makefile.am index 927a5a5..4014bed 100644 --- a/test/cunit/Makefile.am +++ b/test/cunit/Makefile.am @@ -10,4 +10,4 @@ bin_PROGRAMS = odp_init odp_init_LDFLAGS = $(AM_LDFLAGS) -static -lcunit endif -dist_odp_init_SOURCES = odp_init_test.c +dist_odp_init_SOURCES = odp_init.c diff --git a/test/cunit/odp_init_test.c b/test/cunit/odp_init.c similarity index 94% rename from test/cunit/odp_init_test.c rename to test/cunit/odp_init.c index a612109..88e6235 100644 --- a/test/cunit/odp_init_test.c +++ b/test/cunit/odp_init.c @@ -38,7 +38,7 @@ int main(void) if (CUE_SUCCESS != CU_initialize_registry()) return CU_get_error(); /* add a suite to the registry */ - ptr_suite = CU_add_suite("odp intalization", init, finalise); + ptr_suite = CU_add_suite(__FILE__, init, finalise); if (NULL == ptr_suite) { CU_cleanup_registry(); return CU_get_error();
Synchronise the file name with the test suite name. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- test/cunit/Makefile.am | 2 +- test/cunit/{odp_init_test.c => odp_init.c} | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename test/cunit/{odp_init_test.c => odp_init.c} (94%)