| Message ID | 1360151477-26460-8-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
On 02/06/2013 12:51 PM, Sachin Kamat wrote: > Added documentaion about G2D bindings. s/documentaion/documentation > Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> > --- > .../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt > new file mode 100644 > index 0000000..838b26b > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt > @@ -0,0 +1,30 @@ > +* Samsung 2D Graphics Accelerator > + > +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer. > +We set the drawing-context registers for configuring the rendering parameters > +and then start rendering. > +The G2D has V4L2 as well as DRM framework based driver support. IMHO this whole paragraph is irrelevant and could be dropped. > +Required properties: > + - compatible : value should be one among the following missing colon at the end of line ? > + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210& Exynos4210 SoC > + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs > + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC s/(b)/(c) > + > + - reg : Physical base address of the IP registers and length of memory > + mapped region. > + > + - interrupts : G2D interrupt number to the CPU. > + > +Optional properties: > + - samsung,power-domain : power-domain property defined with a phandle > + to respective power domain. > + > +Example: > + g2d@12800000 { > + compatible = "samsung,s5pv210-g2d"; > + reg =<0x12800000 0x1000>; > + interrupts =<0 89 0>; > + samsung,power-domain =<&pd_lcd0>; > + status = "disabled"; > + }; Otherwise looks good to me.
Hi Sachin, On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote: > Added documentaion about G2D bindings. > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > --- > .../devicetree/bindings/gpu/samsung-g2d.txt | 30 > ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/gpu/samsung-g2d.txt > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt > b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode > 100644 > index 0000000..838b26b > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt > @@ -0,0 +1,30 @@ > +* Samsung 2D Graphics Accelerator > + > +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block > Transfer. +We set the drawing-context registers for configuring the > rendering parameters +and then start rendering. > +The G2D has V4L2 as well as DRM framework based driver support. > + > +Required properties: > + - compatible : value should be one among the following > + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 > SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 > SoCs + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 > SoC + > + - reg : Physical base address of the IP registers and length of > memory + mapped region. > + > + - interrupts : G2D interrupt number to the CPU. > + > +Optional properties: > + - samsung,power-domain : power-domain property defined with a phandle > + to respective power domain. I'm not sure if samsung,power-domain should be mentioned in this documentation file. The driver itself does not use this property. Otherwise looks fine. Best regards, Tomasz > + > +Example: > + g2d@12800000 { > + compatible = "samsung,s5pv210-g2d"; > + reg = <0x12800000 0x1000>; > + interrupts = <0 89 0>; > + samsung,power-domain = <&pd_lcd0>; > + status = "disabled"; > + };
On Thursday, 14 February 2013, Sylwester Nawrocki < sylvester.nawrocki@gmail.com> wrote: > On 02/06/2013 12:51 PM, Sachin Kamat wrote: >> >> Added documentaion about G2D bindings. > > s/documentaion/documentation Ok. > >> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org> >> --- >> .../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++ >> 1 files changed, 30 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> new file mode 100644 >> index 0000000..838b26b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> @@ -0,0 +1,30 @@ >> +* Samsung 2D Graphics Accelerator >> + > >> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer. >> +We set the drawing-context registers for configuring the rendering parameters >> +and then start rendering. >> +The G2D has V4L2 as well as DRM framework based driver support. > > IMHO this whole paragraph is irrelevant and could be dropped. Ok. Had formatted this based on mfc document. > >> +Required properties: >> + - compatible : value should be one among the following > > missing colon at the end of line ? Hmm. I think so. > >> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210& Exynos4210 SoC >> + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs >> + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC > > s/(b)/(c) Yes, copy paste error :) > >> + >> + - reg : Physical base address of the IP registers and length of memory >> + mapped region. >> + >> + - interrupts : G2D interrupt number to the CPU. >> + >> +Optional properties: >> + - samsung,power-domain : power-domain property defined with a phandle >> + to respective power domain. >> + >> +Example: >> + g2d@12800000 { >> + compatible = "samsung,s5pv210-g2d"; >> + reg =<0x12800000 0x1000>; >> + interrupts =<0 89 0>; >> + samsung,power-domain =<&pd_lcd0>; >> + status = "disabled"; >> + }; > > Otherwise looks good to me. Thanks for reviewing. Does the filename look good or should it be exynos-g2d? Regards, Sachin.
Hi Tomasz, On Thursday, 14 February 2013, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Sachin, > > On Wednesday 06 of February 2013 17:21:17 Sachin Kamat wrote: >> Added documentaion about G2D bindings. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> --- >> .../devicetree/bindings/gpu/samsung-g2d.txt | 30 >> ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) >> create mode 100644 >> Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> >> diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode >> 100644 >> index 0000000..838b26b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt >> @@ -0,0 +1,30 @@ >> +* Samsung 2D Graphics Accelerator >> + >> +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block >> Transfer. +We set the drawing-context registers for configuring the >> rendering parameters +and then start rendering. >> +The G2D has V4L2 as well as DRM framework based driver support. >> + >> +Required properties: >> + - compatible : value should be one among the following >> + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 >> SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 >> SoCs + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 >> SoC + >> + - reg : Physical base address of the IP registers and length of >> memory + mapped region. >> + >> + - interrupts : G2D interrupt number to the CPU. >> + >> +Optional properties: >> + - samsung,power-domain : power-domain property defined with a phandle >> + to respective power domain. > > I'm not sure if samsung,power-domain should be mentioned in this > documentation file. The driver itself does not use this property. Oh ok. I will check this again and remove if unnecessary. > > Otherwise looks fine. > > Best regards, > Tomasz > >> + >> +Example: >> + g2d@12800000 { >> + compatible = "samsung,s5pv210-g2d"; >> + reg = <0x12800000 0x1000>; >> + interrupts = <0 89 0>; >> + samsung,power-domain = <&pd_lcd0>; >> + status = "disabled"; >> + }; > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
On 02/14/2013 04:45 PM, Sachin Kamat wrote:
> Thanks for reviewing. Does the filename look good or should it be exynos-g2d?
You're welcome. My apologies for being a bit late.
I guess exynos-g2d.txt would be more appropriate. OTOH if this document is
going to cover all Samsung G2D IP blocks then current name might be better.
I used samsung- prefix for fimc and mipi-csis as those documents are supposed
to cover the S5P and Exynos4 SoCs.
Hi Sylwester, On 14 February 2013 21:31, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > On 02/14/2013 04:45 PM, Sachin Kamat wrote: >> Thanks for reviewing. Does the filename look good or should it be exynos-g2d? > > You're welcome. My apologies for being a bit late. > I guess exynos-g2d.txt would be more appropriate. OTOH if this document is > going to cover all Samsung G2D IP blocks then current name might be better. > I used samsung- prefix for fimc and mipi-csis as those documents are supposed > to cover the S5P and Exynos4 SoCs. > I have retained the filename as it was since it addresses both S5P as well as Exynos IPs. Thanks for the tip. I have resent this series with your other comments addressed.
Hi Tomasz, >>> +Optional properties: >>> + - samsung,power-domain : power-domain property defined with a phandle >>> + to respective power domain. >> >> I'm not sure if samsung,power-domain should be mentioned in this >> documentation file. The driver itself does not use this property. > > Oh ok. I will check this again and remove if unnecessary. The driver does not use power-domain property for now and hence I have removed this in V2. Thanks for pointing out.
diff --git a/Documentation/devicetree/bindings/gpu/samsung-g2d.txt b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt new file mode 100644 index 0000000..838b26b --- /dev/null +++ b/Documentation/devicetree/bindings/gpu/samsung-g2d.txt @@ -0,0 +1,30 @@ +* Samsung 2D Graphics Accelerator + +Samsung FIMG2D is a 2D graphics accelerator which supports Bit Block Transfer. +We set the drawing-context registers for configuring the rendering parameters +and then start rendering. +The G2D has V4L2 as well as DRM framework based driver support. + +Required properties: + - compatible : value should be one among the following + (a) "samsung,s5pv210-g2d" for G2D IP present in S5PV210 & Exynos4210 SoC + (b) "samsung,exynos4212-g2d" for G2D IP present in Exynos4x12 SoCs + (b) "samsung,exynos5250-g2d" for G2D IP present in Exynos5250 SoC + + - reg : Physical base address of the IP registers and length of memory + mapped region. + + - interrupts : G2D interrupt number to the CPU. + +Optional properties: + - samsung,power-domain : power-domain property defined with a phandle + to respective power domain. + +Example: + g2d@12800000 { + compatible = "samsung,s5pv210-g2d"; + reg = <0x12800000 0x1000>; + interrupts = <0 89 0>; + samsung,power-domain = <&pd_lcd0>; + status = "disabled"; + };
Added documentaion about G2D bindings. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- .../devicetree/bindings/gpu/samsung-g2d.txt | 30 ++++++++++++++++++++ 1 files changed, 30 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/gpu/samsung-g2d.txt