| Message ID | 1415178021-13585-1-git-send-email-alexandru.badicioiu@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
nit: For the subject [PATCH v2 1/1] linux-generic : crypto I think that should be [PATCH v2] odp_crypto.c: Add stubs for missing functions We know it is for linux-generic because the PATCH did not have KS2, NETMAP etc in it so no need to say linux-generic again. When there is only one file in the series there is no need to have 1/1 or maybe you meant this to be 1/2 ? The more elaborate description helps define what happened in the git log more than just saying crypto On 5 November 2014 04:00, <alexandru.badicioiu@linaro.org> wrote: > From: Alexandru Badicioiu <alexandru.badicioiu@linaro.org> > > Add missing API functions to crypto implementation. > Required by crypto unit testing. > > Signed-off-by: Alexandru Badicioiu <alexandru.badicioiu@linaro.org> > --- > platform/linux-generic/odp_crypto.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) > > diff --git a/platform/linux-generic/odp_crypto.c > b/platform/linux-generic/odp_crypto.c > index 1475437..596c717 100644 > --- a/platform/linux-generic/odp_crypto.c > +++ b/platform/linux-generic/odp_crypto.c > @@ -13,6 +13,7 @@ > #include <odp_align.h> > #include <odp_shared_memory.h> > #include <odp_crypto_internal.h> > +#include <odp_debug_internal.h> > #include <odp_hints.h> > #include <odph_packet.h> > > @@ -467,3 +468,24 @@ odp_crypto_get_ses_create_compl_session(odp_buffer_t > completion_event, > result = odp_buffer_addr(completion_event); > *session = result->session; > } > + > +void > +odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event > ODP_UNUSED, > + void *ctx ODP_UNUSED) > +{ > + ODP_UNIMPLEMENTED(); > +} > + > +void > +*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event > ODP_UNUSED) > +{ > The documentation makes no mention of NULL being a possible error case, it just says "Returns user data" should the documentation be improved with this patch submission to indicate the error case NULL with a new @retval ? > + ODP_UNIMPLEMENTED(); > + return NULL; > +} > + > +odp_packet_t > +odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event > ODP_UNUSED) > The documentation makes no mention of ODP_PACKET_INVALID being a possible error case, it just says "Returns Packet structure where data now resides" should the documentation be improved with this patch submission to indicate the error case ODP_PACKET_INVALID with a new @retval ? > +{ > + ODP_UNIMPLEMENTED(); > + return ODP_PACKET_INVALID; > +} > -- > 1.7.3.4 > > > _______________________________________________ > lng-odp mailing list > lng-odp@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/lng-odp >
diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c index 1475437..596c717 100644 --- a/platform/linux-generic/odp_crypto.c +++ b/platform/linux-generic/odp_crypto.c @@ -13,6 +13,7 @@ #include <odp_align.h> #include <odp_shared_memory.h> #include <odp_crypto_internal.h> +#include <odp_debug_internal.h> #include <odp_hints.h> #include <odph_packet.h> @@ -467,3 +468,24 @@ odp_crypto_get_ses_create_compl_session(odp_buffer_t completion_event, result = odp_buffer_addr(completion_event); *session = result->session; } + +void +odp_crypto_set_operation_compl_ctx(odp_buffer_t completion_event ODP_UNUSED, + void *ctx ODP_UNUSED) +{ + ODP_UNIMPLEMENTED(); +} + +void +*odp_crypto_get_operation_compl_ctx(odp_buffer_t completion_event ODP_UNUSED) +{ + ODP_UNIMPLEMENTED(); + return NULL; +} + +odp_packet_t +odp_crypto_get_operation_compl_packet(odp_buffer_t completion_event ODP_UNUSED) +{ + ODP_UNIMPLEMENTED(); + return ODP_PACKET_INVALID; +}