diff mbox

[v4,8/8] ARM: mediatek: Add config option for mediatek SoCs.

Message ID 1413973797-17619-9-git-send-email-yingjoe.chen@mediatek.com
State New
Headers show

Commit Message

Yingjoe Chen Oct. 22, 2014, 10:29 a.m. UTC 
From: "Joe.C" <yingjoe.chen@mediatek.com>

Add config options for ARCH_MT6589, ARCH_MT8127, ARCH_MT8135. The
upcoming pinctrl, clk drivers need to isolate SoCs support base on
these options.

Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
---
 arch/arm/mach-mediatek/Kconfig | 22 +++++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Comments

Matthias Brugger Oct. 22, 2014, 1:18 p.m. UTC | #1 
2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Add config options for ARCH_MT6589, ARCH_MT8127, ARCH_MT8135. The
> upcoming pinctrl, clk drivers need to isolate SoCs support base on
> these options.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/mach-mediatek/Kconfig | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
> index 2c043a2..25fe6cf 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,6 +1,22 @@
> -config ARCH_MEDIATEK
> -       bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
> +menuconfig ARCH_MEDIATEK
> +       bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>         select ARM_GIC
>         select MTK_TIMER
>         help
> -         Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
> +         Support for Mediatek MT65xx & MT81xx SoCs
> +
> +if ARCH_MEDIATEK
> +
> +config MACH_MT6589
> +       bool "MediaTek MT6589 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +config MACH_MT8127
> +       bool "MediaTek MT8127 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +config MACH_MT8135
> +       bool "MediaTek MT8135 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +endif

MACH_MTxxxx are not used nowhere, please remove them.

> --
> 1.8.1.1.dirty
>
Yingjoe Chen Oct. 22, 2014, 1:31 p.m. UTC | #2 
Hi Matthias,

On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> > +
> > +if ARCH_MEDIATEK
> > +
> > +config MACH_MT6589
> > +       bool "MediaTek MT6589 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +config MACH_MT8127
> > +       bool "MediaTek MT8127 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +config MACH_MT8135
> > +       bool "MediaTek MT8135 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +endif
> 
> MACH_MTxxxx are not used nowhere, please remove them.

Yes, they are not used in this series yet.

MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
mt8135 clk driver we are about to send. I don't want to create false
dependency between these 2 series so I put it here.
Do you prefer add them when they are first used?

Joe.C

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Matthias Brugger Oct. 22, 2014, 1:53 p.m. UTC | #3 
Hi Joe,

2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
>
> Hi Matthias,
>
> On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
>> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
>> > +
>> > +if ARCH_MEDIATEK
>> > +
>> > +config MACH_MT6589
>> > +       bool "MediaTek MT6589 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8127
>> > +       bool "MediaTek MT8127 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8135
>> > +       bool "MediaTek MT8135 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +endif
>>
>> MACH_MTxxxx are not used nowhere, please remove them.
>
> Yes, they are not used in this series yet.
>
> MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> mt8135 clk driver we are about to send. I don't want to create false
> dependency between these 2 series so I put it here.
> Do you prefer add them when they are first used?

Yes please add them, when they are first used.
Today I had a look on the pinctrl patches you mentioned. It looks to
me as if the config is not needed in the series.

Thanks,
Matthias

[0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505

>
> Joe.C
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
>
>
Yingjoe Chen Oct. 22, 2014, 2:19 p.m. UTC | #4 
On Wed, 2014-10-22 at 15:53 +0200, Matthias Brugger wrote:
> Hi Joe,
> 
> 2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> >
> > Hi Matthias,
> >
> > On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> >> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> >> > +
> >> > +if ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT6589
> >> > +       bool "MediaTek MT6589 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8127
> >> > +       bool "MediaTek MT8127 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8135
> >> > +       bool "MediaTek MT8135 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +endif
> >>
> >> MACH_MTxxxx are not used nowhere, please remove them.
> >
> > Yes, they are not used in this series yet.
> >
> > MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> > mt8135 clk driver we are about to send. I don't want to create false
> > dependency between these 2 series so I put it here.
> > Do you prefer add them when they are first used?
> 
> Yes please add them, when they are first used.
> Today I had a look on the pinctrl patches you mentioned. It looks to
> me as if the config is not needed in the series.

OK, I'll remove these in next version.

Joe.C

> 
> Thanks,
> Matthias
> 
> [0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505
> 
> >
> > Joe.C
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
> >
> >
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
index 2c043a2..25fe6cf 100644
--- a/arch/arm/mach-mediatek/Kconfig
+++ b/arch/arm/mach-mediatek/Kconfig
@@ -1,6 +1,22 @@ 
-config ARCH_MEDIATEK
-	bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
+menuconfig ARCH_MEDIATEK
+	bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
 	select ARM_GIC
 	select MTK_TIMER
 	help
-	  Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
+	  Support for Mediatek MT65xx & MT81xx SoCs
+
+if ARCH_MEDIATEK
+
+config MACH_MT6589
+	bool "MediaTek MT6589 SoCs support"
+	default ARCH_MEDIATEK
+
+config MACH_MT8127
+	bool "MediaTek MT8127 SoCs support"
+	default ARCH_MEDIATEK
+
+config MACH_MT8135
+	bool "MediaTek MT8135 SoCs support"
+	default ARCH_MEDIATEK
+
+endif