| Message ID | 1357225977-13346-2-git-send-email-gautam.vivek@samsung.com |
|---|---|
| State | New |
| Headers | show |
Dear Vivek Gautam, > From: Rajeshwari Shinde <rajeshwari.s@samsung.com> > > This patch adds the device node required for USB > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Please rebase on u-boot-usb/next. Best regards, Marek Vasut
Hi Marek, On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: > Dear Vivek Gautam, > >> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> >> >> This patch adds the device node required for USB >> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > > Please rebase on u-boot-usb/next. > "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( I can't find the exynos5250 side basic device tree support which is already been applied on u-boot-samsung-mainline. Set of five patches from Hatim Ali mentioned below, needs to be pulled for exysno5250 side device tree support. - EXYNOS5: FDT: add initial dts file for EXYNOS5250, SMDK5250 - fdt: exynos5: Add DT node definition for SROM and SMSC9215 - exynos5: Add DT based driver for SMC911X ethernet - exynos5: config: Rename the smdk5250.h to exynos5250-dt.h - SMDK5250: config: Add configuration file for SMDK5250 board Please suggest.
Dear Vivek Gautam, > Hi Marek, > > On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: > > Dear Vivek Gautam, > > > >> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> > >> > >> This patch adds the device node required for USB > >> > >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > > > > Please rebase on u-boot-usb/next. > > "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( > I can't find the exynos5250 side basic device tree support which is already > been applied on u-boot-samsung-mainline. Ok, let's change how to do this then. Apply all four on u-boot-samsung/next. > Set of five patches from Hatim Ali mentioned below, needs to be pulled for > exysno5250 side device tree support. > - EXYNOS5: FDT: add initial dts file for EXYNOS5250, SMDK5250 > - fdt: exynos5: Add DT node definition for SROM and SMSC9215 > - exynos5: Add DT based driver for SMC911X ethernet > - exynos5: config: Rename the smdk5250.h to exynos5250-dt.h > - SMDK5250: config: Add configuration file for SMDK5250 board > > Please suggest. Best regards, Marek Vasut
On Tue, Jan 8, 2013 at 2:20 PM, Marek Vasut <marex@denx.de> wrote: > Dear Vivek Gautam, > >> Hi Marek, >> >> On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: >> > Dear Vivek Gautam, >> > >> >> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> >> >> >> >> This patch adds the device node required for USB >> >> >> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >> > >> > Please rebase on u-boot-usb/next. >> >> "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( >> I can't find the exynos5250 side basic device tree support which is already >> been applied on u-boot-samsung-mainline. > > Ok, let's change how to do this then. Apply all four on u-boot-samsung/next. > Ok, sure. I shall post all 4 patches including 3 for ehci fdt support and 1 patch for usb vbus rebased on top of u-boot-samsung/master.
Dear Vivek Gautam, > On Tue, Jan 8, 2013 at 2:20 PM, Marek Vasut <marex@denx.de> wrote: > > Dear Vivek Gautam, > > > >> Hi Marek, > >> > >> On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: > >> > Dear Vivek Gautam, > >> > > >> >> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> > >> >> > >> >> This patch adds the device node required for USB > >> >> > >> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > >> > > >> > Please rebase on u-boot-usb/next. > >> > >> "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( > >> I can't find the exynos5250 side basic device tree support which is > >> already been applied on u-boot-samsung-mainline. > > > > Ok, let's change how to do this then. Apply all four on > > u-boot-samsung/next. > > Ok, sure. I shall post all 4 patches including 3 for ehci fdt support > and 1 patch > for usb vbus rebased on top of u-boot-samsung/master. I think the -samsung custodian shall just pick your series as is. Best regards, Marek Vasut
Hello, On 08/01/13 18:14, Marek Vasut wrote: > Dear Vivek Gautam, > >> On Tue, Jan 8, 2013 at 2:20 PM, Marek Vasut <marex@denx.de> wrote: >>> Dear Vivek Gautam, >>> >>>> Hi Marek, >>>> >>>> On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: >>>>> Dear Vivek Gautam, >>>>> >>>>>> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> >>>>>> >>>>>> This patch adds the device node required for USB >>>>>> >>>>>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >>>>> >>>>> Please rebase on u-boot-usb/next. >>>> >>>> "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( >>>> I can't find the exynos5250 side basic device tree support which is >>>> already been applied on u-boot-samsung-mainline. >>> >>> Ok, let's change how to do this then. Apply all four on >>> u-boot-samsung/next. >> >> Ok, sure. I shall post all 4 patches including 3 for ehci fdt support >> and 1 patch >> for usb vbus rebased on top of u-boot-samsung/master. > > I think the -samsung custodian shall just pick your series as is. > Then, I will pick up following patches. [U-Boot,v3,1/3] EHCI: Exynos: Add fdt support [U-Boot,v3,2/3] EXYNOS5: Add device node for USB. [U-Boot,v3,3/3] EXYNOS5: FDT: Add compatible strings for USB [U-Boot,v2] SMDK5250: Enable VBus for USB 2.0 controller (V2! not V3) Is it right? Thanks, Minkyu Kang.
Dear Minkyu Kang, > Hello, > > On 08/01/13 18:14, Marek Vasut wrote: > > Dear Vivek Gautam, > > > >> On Tue, Jan 8, 2013 at 2:20 PM, Marek Vasut <marex@denx.de> wrote: > >>> Dear Vivek Gautam, > >>> > >>>> Hi Marek, > >>>> > >>>> On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: > >>>>> Dear Vivek Gautam, > >>>>> > >>>>>> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> > >>>>>> > >>>>>> This patch adds the device node required for USB > >>>>>> > >>>>>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > >>>>> > >>>>> Please rebase on u-boot-usb/next. > >>>> > >>>> "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( > >>>> I can't find the exynos5250 side basic device tree support which is > >>>> already been applied on u-boot-samsung-mainline. > >>> > >>> Ok, let's change how to do this then. Apply all four on > >>> u-boot-samsung/next. > >> > >> Ok, sure. I shall post all 4 patches including 3 for ehci fdt support > >> and 1 patch > >> for usb vbus rebased on top of u-boot-samsung/master. > > > > I think the -samsung custodian shall just pick your series as is. > > Then, I will pick up following patches. > > [U-Boot,v3,1/3] EHCI: Exynos: Add fdt support > [U-Boot,v3,2/3] EXYNOS5: Add device node for USB. > [U-Boot,v3,3/3] EXYNOS5: FDT: Add compatible strings for USB > [U-Boot,v2] SMDK5250: Enable VBus for USB 2.0 controller (V2! not V3) > > Is it right? Yes, thanks man! > Thanks, > Minkyu Kang. Best regards, Marek Vasut
Hi Minkyu Kang, On Tue, Jan 8, 2013 at 3:03 PM, Marek Vasut <marex@denx.de> wrote: > Dear Minkyu Kang, > >> Hello, >> >> On 08/01/13 18:14, Marek Vasut wrote: >> > Dear Vivek Gautam, >> > >> >> On Tue, Jan 8, 2013 at 2:20 PM, Marek Vasut <marex@denx.de> wrote: >> >>> Dear Vivek Gautam, >> >>> >> >>>> Hi Marek, >> >>>> >> >>>> On Tue, Jan 8, 2013 at 12:36 PM, Marek Vasut <marex@denx.de> wrote: >> >>>>> Dear Vivek Gautam, >> >>>>> >> >>>>>> From: Rajeshwari Shinde <rajeshwari.s@samsung.com> >> >>>>>> >> >>>>>> This patch adds the device node required for USB >> >>>>>> >> >>>>>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >> >>>>> >> >>>>> Please rebase on u-boot-usb/next. >> >>>> >> >>>> "exynos5250.dtsi" seems to be missing in u-boot-usb tree. :-( >> >>>> I can't find the exynos5250 side basic device tree support which is >> >>>> already been applied on u-boot-samsung-mainline. >> >>> >> >>> Ok, let's change how to do this then. Apply all four on >> >>> u-boot-samsung/next. >> >> >> >> Ok, sure. I shall post all 4 patches including 3 for ehci fdt support >> >> and 1 patch >> >> for usb vbus rebased on top of u-boot-samsung/master. >> > >> > I think the -samsung custodian shall just pick your series as is. >> >> Then, I will pick up following patches. >> >> [U-Boot,v3,1/3] EHCI: Exynos: Add fdt support >> [U-Boot,v3,2/3] EXYNOS5: Add device node for USB. >> [U-Boot,v3,3/3] EXYNOS5: FDT: Add compatible strings for USB >> [U-Boot,v2] SMDK5250: Enable VBus for USB 2.0 controller (V2! not V3) >> >> Is it right? > > Yes, thanks man! > I have just sent the v4 for these patches. [U-Boot] [PATCH v4 1/3] EHCI: Exynos: Add fdt support [U-Boot] [PATCH v4 2/3] EXYNOS5: Add device node for USB. [U-Boot] [PATCH v4 3/3] EXYNOS5: FDT: Add compatible strings for USB [U-Boot] [PATCH v4] SMDK5250: Enable VBus for USB 2.0 controller Please apply the same. these are rebased on top of tree of u-boot-samsung.
diff --git a/arch/arm/dts/exynos5250.dtsi b/arch/arm/dts/exynos5250.dtsi index fa4d498..9179fc9 100644 --- a/arch/arm/dts/exynos5250.dtsi +++ b/arch/arm/dts/exynos5250.dtsi @@ -28,4 +28,17 @@ #address-cells = <1>; #size-cells = <0>; }; + + ehci@12110000 { + compatible = "samsung,exynos-ehci"; + reg = <0x12110000 0x100>; + #address-cells = <1>; + #size-cells = <1>; + + phy { + compatible = "samsung,exynos-usb-phy"; + reg = <0x12130000 0x100>; + }; + }; + };