diff mbox

[13/14] misc: tsl2550: Remove redundant check on unsigned variable

Message ID 1353048646-10935-14-git-send-email-tushar.behera@linaro.org
State Accepted
Commit ae8a35aef41f2b9cf69fd489767291675f3fe291
Headers show

Commit Message

Tushar Behera Nov. 16, 2012, 6:50 a.m. UTC 
No need to check whether unsigned variable is less than 0.

CC: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 drivers/misc/tsl2550.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Comments

Arnd Bergmann Nov. 16, 2012, 8:09 a.m. UTC | #1 
On Friday 16 November 2012, Tushar Behera wrote:
> No need to check whether unsigned variable is less than 0.
> 
> CC: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>

Acked-by: Arnd Bergmann <arnd@arndb.de>
diff mbox

Patch

diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c
index 0beb298..0438569 100644
--- a/drivers/misc/tsl2550.c
+++ b/drivers/misc/tsl2550.c
@@ -204,7 +204,7 @@  static ssize_t tsl2550_store_power_state(struct device *dev,
 	unsigned long val = simple_strtoul(buf, NULL, 10);
 	int ret;
 
-	if (val < 0 || val > 1)
+	if (val > 1)
 		return -EINVAL;
 
 	mutex_lock(&data->update_lock);
@@ -236,7 +236,7 @@  static ssize_t tsl2550_store_operating_mode(struct device *dev,
 	unsigned long val = simple_strtoul(buf, NULL, 10);
 	int ret;
 
-	if (val < 0 || val > 1)
+	if (val > 1)
 		return -EINVAL;
 
 	if (data->power_state == 0)