| Message ID | 1410932179-4652-1-git-send-email-srinivas.kandagatla@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Srini, Thanks for the patch. Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com> A minor nit. On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote: > This patch adds memory details of IFC6410 as this is necessary to > fix the in-correct memory start comming from ATAGs. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > index 90db8af..3287f12 100644 > --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > @@ -4,6 +4,11 @@ > model = "Qualcomm APQ8064/IFC6410"; > compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; > > + memory{ Space before {? > + device_type = "memory"; > + reg = <0x80000000 0x80000000>; > + }; > + > soc { > gsbi@16600000 { > status = "ok"; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: > Hi Srini, > > Thanks for the patch. > Tested-by: Pramod Gurav <pramod.gurav@smartplayin.com> > > A minor nit. > On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote: >> This patch adds memory details of IFC6410 as this is necessary to >> fix the in-correct memory start comming from ATAGs. >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> index 90db8af..3287f12 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> @@ -4,6 +4,11 @@ >> model = "Qualcomm APQ8064/IFC6410"; >> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; >> >> + memory{ > Space before {? >> + device_type = "memory"; >> + reg = <0x80000000 0x80000000>; >> + }; >> + >> soc { >> gsbi@16600000 { >> status = "ok”; Hmm, this doesn’t seem to work for me. - k
On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote: > On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: > > On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote: > >> This patch adds memory details of IFC6410 as this is necessary to > >> fix the in-correct memory start comming from ATAGs. > >> > >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > >> --- > >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > >> index 90db8af..3287f12 100644 > >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts > >> @@ -4,6 +4,11 @@ > >> model = "Qualcomm APQ8064/IFC6410"; > >> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; > >> > >> + memory{ > > Space before {? > >> + device_type = "memory"; > >> + reg = <0x80000000 0x80000000>; > >> + }; > >> + > >> soc { > >> gsbi@16600000 { > >> status = "ok?; > > Hmm, this doesn?t seem to work for me. I don't see how it could with qcom_defconfig, as we set CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue?
On 17/09/14 20:18, Josh Cartwright wrote: > On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote: >> On Sep 16, 2014, at 11:34 PM, Pramod Gurav <pramod.gurav@smartplayin.com> wrote: >>> On Wednesday 17 September 2014 11:06 AM, Srinivas Kandagatla wrote: >>>> This patch adds memory details of IFC6410 as this is necessary to >>>> fix the in-correct memory start comming from ATAGs. >>>> >>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >>>> --- >>>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >>>> index 90db8af..3287f12 100644 >>>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >>>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >>>> @@ -4,6 +4,11 @@ >>>> model = "Qualcomm APQ8064/IFC6410"; >>>> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; >>>> >>>> + memory{ >>> Space before {? >>>> + device_type = "memory"; >>>> + reg = <0x80000000 0x80000000>; >>>> + }; >>>> + >>>> soc { >>>> gsbi@16600000 { >>>> status = "ok?; >> >> Hmm, this doesn?t seem to work for me. > > I don't see how it could with qcom_defconfig, as we set > CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue? No, its not fixing any thing by itself. However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" patch atleast I get to boot my IFC6410 with multi_v7_defconfig. > -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Sep 17, 2014 at 2:49 PM, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > > On 17/09/14 20:18, Josh Cartwright wrote: >> >> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote: [..] >>> Hmm, this doesn?t seem to work for me. >> >> >> I don't see how it could with qcom_defconfig, as we set >> CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue? > > No, its not fixing any thing by itself. > > However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" > patch atleast I get to boot my IFC6410 with multi_v7_defconfig. But that patch was rejected by various people. Instead have a look at [1], it solves the problem for you (and have reference to the original source). [1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 18/09/14 05:37, Bjorn Andersson wrote: > On Wed, Sep 17, 2014 at 2:49 PM, Srinivas Kandagatla > <srinivas.kandagatla@linaro.org> wrote: >> >> >> On 17/09/14 20:18, Josh Cartwright wrote: >>> >>> On Wed, Sep 17, 2014 at 12:03:37PM -0700, Kumar Gala wrote: > [..] >>>> Hmm, this doesn?t seem to work for me. >>> >>> >>> I don't see how it could with qcom_defconfig, as we set >>> CONFIG_ARM_ATAG_DTB_COMPAT. Is this patch fixing a real issue? >> >> No, its not fixing any thing by itself. >> >> However along with "ARM: zImage: Allow DTB to override broken ATAG_MEM" >> patch atleast I get to boot my IFC6410 with multi_v7_defconfig. > > But that patch was rejected by various people. > Instead have a look at [1], it solves the problem for you (and have > reference to the original source). > > [1] https://github.com/andersson/kernel/commit/d4c0061cf7be8a341e6d06a97c85ecb69284e74c Looks cool.. I think we can ignore this patch with this fixup. On IFC6410 now that we have some way to unbrick the board we could even try to fix this at bootloader level. Thanks to Kumar and You for redirecting me to this link. --srini > > Regards, > Bjorn > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts index 90db8af..3287f12 100644 --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts @@ -4,6 +4,11 @@ model = "Qualcomm APQ8064/IFC6410"; compatible = "qcom,apq8064-ifc6410", "qcom,apq8064"; + memory{ + device_type = "memory"; + reg = <0x80000000 0x80000000>; + }; + soc { gsbi@16600000 { status = "ok";
This patch adds memory details of IFC6410 as this is necessary to fix the in-correct memory start comming from ATAGs. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 5 +++++ 1 file changed, 5 insertions(+)