diff mbox

odp_check: align pointer with name

Message ID 1408562587-21737-1-git-send-email-mike.holmes@linaro.org
State Accepted
Commit 56d31a07a20bacc1d9d81eed8a3c77521f77fdac
Headers show

Commit Message

Mike Holmes Aug. 20, 2014, 7:23 p.m. UTC
Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
---

Have astyle format functions to satisfy checkpatch so that
the following:
char* foo1;
char & foo2;
String ^s1;

becomes (with align-pointer=name):
char *foo1;
char &foo2;
String ^s1;

 scripts/odp_check | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anders Roxell Aug. 25, 2014, 8:29 p.m. UTC | #1
On 2014-08-20 15:23, Mike Holmes wrote:
> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>

Reviewed-by: Anders Roxell <anders.roxell@linaro.org>

> ---
> 
> Have astyle format functions to satisfy checkpatch so that
> the following:
> char* foo1;
> char & foo2;
> String ^s1;
> 
> becomes (with align-pointer=name):
> char *foo1;
> char &foo2;
> String ^s1;
> 
>  scripts/odp_check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/odp_check b/scripts/odp_check
> index 8df35fa..09c859b 100755
> --- a/scripts/odp_check
> +++ b/scripts/odp_check
> @@ -15,6 +15,6 @@ if ! type "astyle" >/dev/null >/dev/null; then
>     exit -1
>  fi
>  
> -astyle --style=linux --indent=force-tab=8 $1
> +astyle --style=linux --indent=force-tab=8 --align-pointer=name $1
>  $DIR/cleanfile $1
>  $DIR/checkpatch.pl -f $1
> -- 
> 1.9.1
> 
> 
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
Maxim Uvarov Aug. 26, 2014, 10:16 a.m. UTC | #2
Merged, thanks!

Maxim.

On 08/26/2014 12:29 AM, Anders Roxell wrote:
> On 2014-08-20 15:23, Mike Holmes wrote:
>> Signed-off-by: Mike Holmes <mike.holmes@linaro.org>
> Reviewed-by: Anders Roxell <anders.roxell@linaro.org>
>
>> ---
>>
>> Have astyle format functions to satisfy checkpatch so that
>> the following:
>> char* foo1;
>> char & foo2;
>> String ^s1;
>>
>> becomes (with align-pointer=name):
>> char *foo1;
>> char &foo2;
>> String ^s1;
>>
>>   scripts/odp_check | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/odp_check b/scripts/odp_check
>> index 8df35fa..09c859b 100755
>> --- a/scripts/odp_check
>> +++ b/scripts/odp_check
>> @@ -15,6 +15,6 @@ if ! type "astyle" >/dev/null >/dev/null; then
>>      exit -1
>>   fi
>>   
>> -astyle --style=linux --indent=force-tab=8 $1
>> +astyle --style=linux --indent=force-tab=8 --align-pointer=name $1
>>   $DIR/cleanfile $1
>>   $DIR/checkpatch.pl -f $1
>> -- 
>> 1.9.1
>>
>>
>> _______________________________________________
>> lng-odp mailing list
>> lng-odp@lists.linaro.org
>> http://lists.linaro.org/mailman/listinfo/lng-odp
> _______________________________________________
> lng-odp mailing list
> lng-odp@lists.linaro.org
> http://lists.linaro.org/mailman/listinfo/lng-odp
diff mbox

Patch

diff --git a/scripts/odp_check b/scripts/odp_check
index 8df35fa..09c859b 100755
--- a/scripts/odp_check
+++ b/scripts/odp_check
@@ -15,6 +15,6 @@  if ! type "astyle" >/dev/null >/dev/null; then
    exit -1
 fi
 
-astyle --style=linux --indent=force-tab=8 $1
+astyle --style=linux --indent=force-tab=8 --align-pointer=name $1
 $DIR/cleanfile $1
 $DIR/checkpatch.pl -f $1