diff mbox

Fix comment for odp_generator

Message ID 1407145584-30710-1-git-send-email-weilong.chen@linaro.org
State Accepted
Commit 26238333b5b0896366c844aeb7253e60abd99f5a
Headers show

Commit Message

Weilong Chen Aug. 4, 2014, 9:46 a.m. UTC
This patch fix a comment error, and remove the print message of
the flood mode.

Signed-off-by: Weilong Chen <weilong.chen@linaro.org>
---
 example/generator/odp_generator.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Comments

Maxim Uvarov Aug. 11, 2014, 11:05 a.m. UTC | #1
Acked-by: Maxim Uvarov <maxim.uvarov@linaro.org>

Maxim.

On 08/04/2014 01:46 PM, Weilong Chen wrote:
> This patch fix a comment error, and remove the print message of
> the flood mode.
>
> Signed-off-by: Weilong Chen <weilong.chen@linaro.org>
> ---
>   example/generator/odp_generator.c |   11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c
> index e4a72fa..6aa27f7 100644
> --- a/example/generator/odp_generator.c
> +++ b/example/generator/odp_generator.c
> @@ -341,12 +341,7 @@ static void *gen_send_thread(void *arg)
>   			       thr, counters.seq, counters.seq%0xffff);
>   			/* TODO use odp timer */
>   			usleep(args->appl.interval * 1000);
> -		} else {
> -			/* TODO maybe need a rating control */
> -			/* flood mode use '\r' instead of '\n' */
> -			printf("  [%02i] send pkt no:%ju seq %ju\r",
> -			       thr, counters.seq, counters.seq%0xffff);
> -		}
> +		}
>   		if (args->appl.number != -1 && counters.seq
>   		    >= (unsigned int)args->appl.number) {
>   			break;
> @@ -366,9 +361,9 @@ static void *gen_send_thread(void *arg)
>   
>   	/* print info */
>   	if (args->appl.mode == APPL_MODE_UDP) {
> -		printf("  [%02i] total send:%ju\n", thr, counters.seq);
> +		printf("  [%02i] total send: %ju\n", thr, counters.seq);
>   	} else if (args->appl.mode == APPL_MODE_PING) {
> -		printf("  [%02i] total send:%ju,total receiver %ju\n",
> +		printf("  [%02i] total send: %ju total receive: %ju\n",
>   		       thr, counters.seq, counters.icmp);
>   	}
>   	return arg;
Maxim Uvarov Aug. 18, 2014, 10:49 a.m. UTC | #2
Merged.

Fixed trailing whitespace at the end of printf.

Thanks,
Maxim.

On 08/04/2014 01:46 PM, Weilong Chen wrote:
> This patch fix a comment error, and remove the print message of
> the flood mode.
>
> Signed-off-by: Weilong Chen <weilong.chen@linaro.org>
> ---
>   example/generator/odp_generator.c |   11 +++--------
>   1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c
> index e4a72fa..6aa27f7 100644
> --- a/example/generator/odp_generator.c
> +++ b/example/generator/odp_generator.c
> @@ -341,12 +341,7 @@ static void *gen_send_thread(void *arg)
>   			       thr, counters.seq, counters.seq%0xffff);
>   			/* TODO use odp timer */
>   			usleep(args->appl.interval * 1000);
> -		} else {
> -			/* TODO maybe need a rating control */
> -			/* flood mode use '\r' instead of '\n' */
> -			printf("  [%02i] send pkt no:%ju seq %ju\r",
> -			       thr, counters.seq, counters.seq%0xffff);
> -		}
> +		}
>   		if (args->appl.number != -1 && counters.seq
>   		    >= (unsigned int)args->appl.number) {
>   			break;
> @@ -366,9 +361,9 @@ static void *gen_send_thread(void *arg)
>   
>   	/* print info */
>   	if (args->appl.mode == APPL_MODE_UDP) {
> -		printf("  [%02i] total send:%ju\n", thr, counters.seq);
> +		printf("  [%02i] total send: %ju\n", thr, counters.seq);
>   	} else if (args->appl.mode == APPL_MODE_PING) {
> -		printf("  [%02i] total send:%ju,total receiver %ju\n",
> +		printf("  [%02i] total send: %ju total receive: %ju\n",
>   		       thr, counters.seq, counters.icmp);
>   	}
>   	return arg;
diff mbox

Patch

diff --git a/example/generator/odp_generator.c b/example/generator/odp_generator.c
index e4a72fa..6aa27f7 100644
--- a/example/generator/odp_generator.c
+++ b/example/generator/odp_generator.c
@@ -341,12 +341,7 @@  static void *gen_send_thread(void *arg)
 			       thr, counters.seq, counters.seq%0xffff);
 			/* TODO use odp timer */
 			usleep(args->appl.interval * 1000);
-		} else {
-			/* TODO maybe need a rating control */
-			/* flood mode use '\r' instead of '\n' */
-			printf("  [%02i] send pkt no:%ju seq %ju\r",
-			       thr, counters.seq, counters.seq%0xffff);
-		}
+		} 
 		if (args->appl.number != -1 && counters.seq
 		    >= (unsigned int)args->appl.number) {
 			break;
@@ -366,9 +361,9 @@  static void *gen_send_thread(void *arg)
 
 	/* print info */
 	if (args->appl.mode == APPL_MODE_UDP) {
-		printf("  [%02i] total send:%ju\n", thr, counters.seq);
+		printf("  [%02i] total send: %ju\n", thr, counters.seq);
 	} else if (args->appl.mode == APPL_MODE_PING) {
-		printf("  [%02i] total send:%ju,total receiver %ju\n",
+		printf("  [%02i] total send: %ju total receive: %ju\n",
 		       thr, counters.seq, counters.icmp);
 	}
 	return arg;