| Message ID | 1342519796-19324-1-git-send-email-sachin.kamat@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On Tuesday, July 17, 2012, Sachin Kamat wrote: > Fixes the following sparse warnings: > drivers/base/power/main.c:48:1: warning: symbol 'dpm_prepared_list' was not declared. Should it be static? > drivers/base/power/main.c:49:1: warning: symbol 'dpm_suspended_list' was not declared. Should it be static? > drivers/base/power/main.c:50:1: warning: symbol 'dpm_late_early_list' was not declared. Should it be static? > drivers/base/power/main.c:51:1: warning: symbol 'dpm_noirq_list' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> I've applied all of the three patches in the series to the 'linux-next' branch of the linux-pm.git tree, but please don't send me any more of these before 3.6-rc1, because I won't take them for 3.6 anyway. Thanks, Rafael > --- > drivers/base/power/main.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c > index d791950..61a891d 100644 > --- a/drivers/base/power/main.c > +++ b/drivers/base/power/main.c > @@ -45,10 +45,10 @@ typedef int (*pm_callback_t)(struct device *); > */ > > LIST_HEAD(dpm_list); > -LIST_HEAD(dpm_prepared_list); > -LIST_HEAD(dpm_suspended_list); > -LIST_HEAD(dpm_late_early_list); > -LIST_HEAD(dpm_noirq_list); > +static LIST_HEAD(dpm_prepared_list); > +static LIST_HEAD(dpm_suspended_list); > +static LIST_HEAD(dpm_late_early_list); > +static LIST_HEAD(dpm_noirq_list); > > struct suspend_stats suspend_stats; > static DEFINE_MUTEX(dpm_list_mtx); >
On 18/07/2012, Rafael J. Wysocki <rjw@sisk.pl> wrote: > On Tuesday, July 17, 2012, Sachin Kamat wrote: >> Fixes the following sparse warnings: >> drivers/base/power/main.c:48:1: warning: symbol 'dpm_prepared_list' was >> not declared. Should it be static? >> drivers/base/power/main.c:49:1: warning: symbol 'dpm_suspended_list' was >> not declared. Should it be static? >> drivers/base/power/main.c:50:1: warning: symbol 'dpm_late_early_list' was >> not declared. Should it be static? >> drivers/base/power/main.c:51:1: warning: symbol 'dpm_noirq_list' was not >> declared. Should it be static? >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > I've applied all of the three patches in the series to the 'linux-next' > branch of the linux-pm.git tree, Thanks Rafael. but please don't send me any more of these > before 3.6-rc1, because I won't take them for 3.6 anyway. I will wait until the 3.6-rc1 release for any other patches. > > Thanks, > Rafael > > >> --- >> drivers/base/power/main.c | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c >> index d791950..61a891d 100644 >> --- a/drivers/base/power/main.c >> +++ b/drivers/base/power/main.c >> @@ -45,10 +45,10 @@ typedef int (*pm_callback_t)(struct device *); >> */ >> >> LIST_HEAD(dpm_list); >> -LIST_HEAD(dpm_prepared_list); >> -LIST_HEAD(dpm_suspended_list); >> -LIST_HEAD(dpm_late_early_list); >> -LIST_HEAD(dpm_noirq_list); >> +static LIST_HEAD(dpm_prepared_list); >> +static LIST_HEAD(dpm_suspended_list); >> +static LIST_HEAD(dpm_late_early_list); >> +static LIST_HEAD(dpm_noirq_list); >> >> struct suspend_stats suspend_stats; >> static DEFINE_MUTEX(dpm_list_mtx); >> > >
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c index d791950..61a891d 100644 --- a/drivers/base/power/main.c +++ b/drivers/base/power/main.c @@ -45,10 +45,10 @@ typedef int (*pm_callback_t)(struct device *); */ LIST_HEAD(dpm_list); -LIST_HEAD(dpm_prepared_list); -LIST_HEAD(dpm_suspended_list); -LIST_HEAD(dpm_late_early_list); -LIST_HEAD(dpm_noirq_list); +static LIST_HEAD(dpm_prepared_list); +static LIST_HEAD(dpm_suspended_list); +static LIST_HEAD(dpm_late_early_list); +static LIST_HEAD(dpm_noirq_list); struct suspend_stats suspend_stats; static DEFINE_MUTEX(dpm_list_mtx);
Fixes the following sparse warnings: drivers/base/power/main.c:48:1: warning: symbol 'dpm_prepared_list' was not declared. Should it be static? drivers/base/power/main.c:49:1: warning: symbol 'dpm_suspended_list' was not declared. Should it be static? drivers/base/power/main.c:50:1: warning: symbol 'dpm_late_early_list' was not declared. Should it be static? drivers/base/power/main.c:51:1: warning: symbol 'dpm_noirq_list' was not declared. Should it be static? Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/base/power/main.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)