diff mbox

[Xen-devel,v3,1/3] xen/x86: introduce is_domain_direct_mapped(d) as (0) on x86

Message ID 1406208666-23547-1-git-send-email-stefano.stabellini@eu.citrix.com
State New
Headers show

Commit Message

Stefano Stabellini July 24, 2014, 1:31 p.m. UTC 
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
 xen/include/asm-x86/domain.h |    1 +
 1 file changed, 1 insertion(+)

Comments

Julien Grall July 24, 2014, 1:41 p.m. UTC | #1 
Hi Stefano,

On 07/24/2014 02:31 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
>  xen/include/asm-x86/domain.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
> index abf55fb..5f9354b 100644
> --- a/xen/include/asm-x86/domain.h
> +++ b/xen/include/asm-x86/domain.h
> @@ -19,6 +19,7 @@
>  #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \
>          d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector)
>  #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
> +#define is_domain_direct_mapped(d) (0)

When I've implemented this defined in common/memory.c, Jan told me to
use [1]:

#define is_domain_is_direct_mapped(d) ((void)(d), 0)

I suspect you want the same things here.

Also, could you drop the define in common/memory.c. I don't think it's
useful now.

>  #define VCPU_TRAP_NMI          1
>  #define VCPU_TRAP_MCE          2
> 

Regards,

[1] https://patches.linaro.org/22523/
Stefano Stabellini July 24, 2014, 4:51 p.m. UTC | #2 
On Thu, 24 Jul 2014, Julien Grall wrote:
> Hi Stefano,
> 
> On 07/24/2014 02:31 PM, Stefano Stabellini wrote:
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > ---
> >  xen/include/asm-x86/domain.h |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
> > index abf55fb..5f9354b 100644
> > --- a/xen/include/asm-x86/domain.h
> > +++ b/xen/include/asm-x86/domain.h
> > @@ -19,6 +19,7 @@
> >  #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \
> >          d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector)
> >  #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
> > +#define is_domain_direct_mapped(d) (0)
> 
> When I've implemented this defined in common/memory.c, Jan told me to
> use [1]:
> 
> #define is_domain_is_direct_mapped(d) ((void)(d), 0)
> 
> I suspect you want the same things here.

OK


> Also, could you drop the define in common/memory.c. I don't think it's
> useful now.

I'll do

> 
> >  #define VCPU_TRAP_NMI          1
> >  #define VCPU_TRAP_MCE          2
> > 
> 
> Regards,
> 
> [1] https://patches.linaro.org/22523/
> 
> -- 
> Julien Grall
>
diff mbox

Patch

diff --git a/xen/include/asm-x86/domain.h b/xen/include/asm-x86/domain.h
index abf55fb..5f9354b 100644
--- a/xen/include/asm-x86/domain.h
+++ b/xen/include/asm-x86/domain.h
@@ -19,6 +19,7 @@ 
 #define is_hvm_pv_evtchn_domain(d) (has_hvm_container_domain(d) && \
         d->arch.hvm_domain.irq.callback_via_type == HVMIRQ_callback_vector)
 #define is_hvm_pv_evtchn_vcpu(v) (is_hvm_pv_evtchn_domain(v->domain))
+#define is_domain_direct_mapped(d) (0)
 
 #define VCPU_TRAP_NMI          1
 #define VCPU_TRAP_MCE          2