| Message ID | 1402397497-26737-8-git-send-email-ulf.hansson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
Ulf Hansson <ulf.hansson@linaro.org> writes: > The dev_irq_safe configuration is redundant, genpd don't have any > special treatmeant for handling it. Let's remove it. Why? The genpd core needs to handle irq_safe properly eventully (right now it just doesn't call power_off/power_on callbacks, but that needs to be implmenented. c.f commit 0aa2a22169) If we remove these flags from platforms, we're taking away information that the platform maintainers have specified tha will be useful when full support is avialble. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11 June 2014 20:13, Kevin Hilman <khilman@linaro.org> wrote: > Ulf Hansson <ulf.hansson@linaro.org> writes: > >> The dev_irq_safe configuration is redundant, genpd don't have any >> special treatmeant for handling it. Let's remove it. > > Why? > > The genpd core needs to handle irq_safe properly eventully (right now it > just doesn't call power_off/power_on callbacks, but that needs to be > implmenented. c.f commit 0aa2a22169) > > If we remove these flags from platforms, we're taking away information > that the platform maintainers have specified tha will be useful when > full support is avialble. For sure this is needed in _some_ form. But before we even figured out how to support irq_safe genpd's, why even bother to support a configuration for it? Currently I think it good enough to use the per device irq_safe option, and then let's see how handling of these devices evolves. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/mach-shmobile/pm-r8a7779.c b/arch/arm/mach-shmobile/pm-r8a7779.c index d6fe189..8cd2423 100644 --- a/arch/arm/mach-shmobile/pm-r8a7779.c +++ b/arch/arm/mach-shmobile/pm-r8a7779.c @@ -74,7 +74,6 @@ static void r8a7779_init_pm_domain(struct r8a7779_pm_domain *r8a7779_pd) genpd->dev_ops.stop = pm_clk_suspend; genpd->dev_ops.start = pm_clk_resume; genpd->dev_ops.active_wakeup = pd_active_wakeup; - genpd->dev_irq_safe = true; genpd->power_off = pd_power_down; genpd->power_on = pd_power_up;
The dev_irq_safe configuration is redundant, genpd don't have any special treatmeant for handling it. Let's remove it. Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> --- arch/arm/mach-shmobile/pm-r8a7779.c | 1 - 1 file changed, 1 deletion(-)