[v3,1/5,SCSI] ufshcd: UFS Host controller driver

Message ID	4F6FF179.5090600@toshiba.co.jp
State	Not Applicable
Headers	show Return-Path: <patch+caf_=linaro-patchwork=canonical.com@linaro.org> Received-SPF: pass (google.com: domain of yoshitake.kobayashi@toshiba.co.jp designates 61.202.160.132 as permitted sender) client-ip=61.202.160.132; Message-ID: <4F6FF179.5090600@toshiba.co.jp> Date: Mon, 26 Mar 2012 13:32:57 +0900 From: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp> User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:11.0) Gecko/20120312 Thunderbird/11.0 MIME-Version: 1.0 To: Santosh Y <santoshsy@gmail.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com>, linux-scsi@vger.kernel.org, patches@linaro.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, arnd.bergmann@linaro.org, saugata.das@linaro.org, dsaxena@linaro.org, stephen.doel@linaro.org, venkat@linaro.org, ilho215.lee@samsung.com, nala.la@samsung.com, girish.shivananjappa@linaro.org, vishak.g@samsung.com, k.rajesh@samsung.com, yejin.moon@samsung.com, sreekumar.c@samsung.com, vinholikatti@gmail.com, linkinjeon@gmail.com, michaelc@cs.wisc.edu Subject: Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver References: <1330497714-26504-2-git-send-email-santoshsy@gmail.com> In-Reply-To: <1330497714-26504-2-git-send-email-santoshsy@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit

Message ID

4F6FF179.5090600@toshiba.co.jp

State

Not Applicable

Headers

Received-SPF: pass (google.com: domain of yoshitake.kobayashi@toshiba.co.jp
	designates 61.202.160.132 as permitted sender)
	client-ip=61.202.160.132; 
Message-ID: <4F6FF179.5090600@toshiba.co.jp>
Date: Mon, 26 Mar 2012 13:32:57 +0900
From: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
User-Agent: Mozilla/5.0 (Windows NT 5.1;
	rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Santosh Y <santoshsy@gmail.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org, patches@linaro.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	arnd.bergmann@linaro.org, saugata.das@linaro.org, dsaxena@linaro.org, 
	stephen.doel@linaro.org, venkat@linaro.org, ilho215.lee@samsung.com, 
	nala.la@samsung.com, girish.shivananjappa@linaro.org,
	vishak.g@samsung.com, k.rajesh@samsung.com, yejin.moon@samsung.com,
	sreekumar.c@samsung.com, vinholikatti@gmail.com, linkinjeon@gmail.com,
	michaelc@cs.wisc.edu
Subject: Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver
References: <1330497714-26504-2-git-send-email-santoshsy@gmail.com>
In-Reply-To: <1330497714-26504-2-git-send-email-santoshsy@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Commit Message

KOBAYASHI Yoshitake March 26, 2012, 4:32 a.m. UTC

> > +        utrdlp[i].response_upiu_length =
> > +                cpu_to_le16(ALIGNED_UPIU_SIZE);

Response UPIU Length(RUL) shows the response UPIU length in Dword.
(JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor)
The following will be correct.

Comments

Santosh Yaraganavi March 27, 2012, 4:01 a.m. UTC | #1

On Mon, Mar 26, 2012 at 10:02 AM, KOBAYASHI Yoshitake
<yoshitake.kobayashi@toshiba.co.jp> wrote:
>> > +        utrdlp[i].response_upiu_length =
>> > +                cpu_to_le16(ALIGNED_UPIU_SIZE);
>
>
> Response UPIU Length(RUL) shows the response UPIU length in Dword.
> (JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor)
> The following will be correct.
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 07ec973..feffe65 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba
> *hba)
>                utrdlp[i].prd_table_offset =
>                                cpu_to_le16((prdt_offset >> 2));
>                utrdlp[i].response_upiu_length =
> -                               cpu_to_le16(ALIGNED_UPIU_SIZE);
> +                               cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);
>
>
>                hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
>                hba->lrb[i].ucd_cmd_ptr =
>

Thanks, i'll update it.

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 07ec973..feffe65 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -836,7 +836,7 @@  static void ufshcd_host_memory_configure(struct ufs_hba *hba)
                 utrdlp[i].prd_table_offset =
                                 cpu_to_le16((prdt_offset >> 2));
                 utrdlp[i].response_upiu_length =
-                               cpu_to_le16(ALIGNED_UPIU_SIZE);
+                               cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);

                 hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
                 hba->lrb[i].ucd_cmd_ptr =

[v3,1/5,SCSI] ufshcd: UFS Host controller driver

Commit Message

Comments

Patch