| Message ID | 1401196664-14223-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | 349b6c5355964d306d7d957c3af6179f3d6391ed |
| Headers | show |
Hi Linus, Le Tuesday 27 May 2014 à 15:17 +0200, Linus Walleij a écrit : > After change 3ff35cbcfa4bc7d7dbdd0279e32ea677567ded02 > "gpio-pch: Fix Kconfig dependencies" > which enabled COMPILE_TEST as an alternative for the PCH > driver, we get build failures like this: > > drivers/gpio/gpio-pch.c: In function 'pch_gpio_probe': > drivers/gpio/gpio-pch.c:359:2: error: implicit declaration > of function 'kzalloc' [-Werror=implicit-function-declaration] > drivers/gpio/gpio-pch.c:359:7: warning: assignment makes > pointer from integer without a cast [enabled by default] > drivers/gpio/gpio-pch.c:442:2: error: implicit declaration > of function 'kfree' [-Werror=implicit-function-declaration] > > Fix this by including <linux/slab.h> explicitly. > > Cc: Jean Delvare <jdelvare@suse.de> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/gpio/gpio-pch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c > index 83a156397474..d6eac9b17db9 100644 > --- a/drivers/gpio/gpio-pch.c > +++ b/drivers/gpio/gpio-pch.c > @@ -20,6 +20,7 @@ > #include <linux/gpio.h> > #include <linux/interrupt.h> > #include <linux/irq.h> > +#include <linux/slab.h> > > #define PCH_EDGE_FALLING 0 > #define PCH_EDGE_RISING BIT(0) Same patch already sent by Arnd Bergmann yesterday and acked by me. But thanks anyway :-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index 83a156397474..d6eac9b17db9 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -20,6 +20,7 @@ #include <linux/gpio.h> #include <linux/interrupt.h> #include <linux/irq.h> +#include <linux/slab.h> #define PCH_EDGE_FALLING 0 #define PCH_EDGE_RISING BIT(0)
After change 3ff35cbcfa4bc7d7dbdd0279e32ea677567ded02 "gpio-pch: Fix Kconfig dependencies" which enabled COMPILE_TEST as an alternative for the PCH driver, we get build failures like this: drivers/gpio/gpio-pch.c: In function 'pch_gpio_probe': drivers/gpio/gpio-pch.c:359:2: error: implicit declaration of function 'kzalloc' [-Werror=implicit-function-declaration] drivers/gpio/gpio-pch.c:359:7: warning: assignment makes pointer from integer without a cast [enabled by default] drivers/gpio/gpio-pch.c:442:2: error: implicit declaration of function 'kfree' [-Werror=implicit-function-declaration] Fix this by including <linux/slab.h> explicitly. Cc: Jean Delvare <jdelvare@suse.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpio-pch.c | 1 + 1 file changed, 1 insertion(+)