diff mbox

[2/3] drm/exynos: Remove duplicate inclusion of i2c.h

Message ID 1400734976-13809-2-git-send-email-sachin.kamat@linaro.org
State Accepted
Headers show

Commit Message

Sachin Kamat May 22, 2014, 5:02 a.m. UTC
i2c.h was included twice.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/gpu/drm/exynos/exynos_hdmi.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Andrzej Hajda May 23, 2014, 7:47 a.m. UTC | #1
Hi Sachin,

On 05/22/2014 07:02 AM, Sachin Kamat wrote:
> i2c.h was included twice.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index ed6176e..d3f9684 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -34,7 +34,6 @@
>  #include <linux/io.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
> -#include <linux/i2c.h>
>  #include <linux/of_gpio.h>
>  #include <linux/hdmi.h>
>  #include <linux/component.h>
> 

It would be also good to order headers alphabetically.

Regards
Andrzej
Sachin Kamat May 23, 2014, 7:53 a.m. UTC | #2
Hi Andrzej,

On 23 May 2014 13:17, Andrzej Hajda <a.hajda@samsung.com> wrote:
> Hi Sachin,
>
> On 05/22/2014 07:02 AM, Sachin Kamat wrote:
>> i2c.h was included twice.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> ---
>>  drivers/gpu/drm/exynos/exynos_hdmi.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> index ed6176e..d3f9684 100644
>> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
>> @@ -34,7 +34,6 @@
>>  #include <linux/io.h>
>>  #include <linux/of.h>
>>  #include <linux/of_address.h>
>> -#include <linux/i2c.h>
>>  #include <linux/of_gpio.h>
>>  #include <linux/hdmi.h>
>>  #include <linux/component.h>
>>
>
> It would be also good to order headers alphabetically.

That is outside the scope of this patch and can be taken up separately
if needed.
diff mbox

Patch

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index ed6176e..d3f9684 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -34,7 +34,6 @@ 
 #include <linux/io.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
-#include <linux/i2c.h>
 #include <linux/of_gpio.h>
 #include <linux/hdmi.h>
 #include <linux/component.h>